Skip to content

Commit d26f74a

Browse files
committed
Apply code auto-format for pool service.
Signed-off-by: Sergey Minaev <[email protected]>
1 parent 2f2865e commit d26f74a

File tree

11 files changed

+150
-236
lines changed

11 files changed

+150
-236
lines changed

libindy/src/services/pool/catchup.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
1-
use std::collections::HashMap;
2-
use std::collections::HashSet;
3-
use errors::pool::PoolError;
41
use errors::common::CommonError;
2+
use errors::pool::PoolError;
53
use services::ledger::merkletree::merkletree::MerkleTree;
64
use services::pool::merkle_tree_factory;
75
use services::pool::rust_base58::{FromBase58, ToBase58};
8-
use services::pool::types::{Message, CatchupReq};
9-
6+
use services::pool::types::{CatchupReq, Message};
7+
use std::collections::HashMap;
8+
use std::collections::HashSet;
109
use super::indy_crypto::utils::json::JsonEncodable;
1110

1211
pub enum CatchupProgress {
@@ -50,7 +49,7 @@ pub fn check_nodes_responses_on_status(nodes_votes: &HashMap<(String, usize, Opt
5049
if let Some((most_popular_vote, votes_cnt)) = nodes_votes.iter().map(|(key, val)| (key, val.len())).max_by_key(|entry| entry.1) {
5150
if votes_cnt == node_count - f {
5251
if most_popular_vote.0.eq("timeout") {
53-
return Err(PoolError::Timeout)
52+
return Err(PoolError::Timeout);
5453
}
5554
return _try_to_catch_up(most_popular_vote, merkle_tree).or_else(|err| {
5655
if merkle_tree_factory::drop_cache(pool_name).is_ok() {

libindy/src/services/pool/commander.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
extern crate byteorder;
22

3-
use self::byteorder::{ByteOrder, LittleEndian};
4-
5-
use super::zmq;
63
use errors::common::CommonError;
4+
use self::byteorder::{ByteOrder, LittleEndian};
75
use services::pool::events::PoolEvent;
6+
use super::zmq;
87

98
pub struct Commander {
109
cmd_socket: zmq::Socket,
@@ -30,15 +29,15 @@ impl Commander {
3029
CommonError::InvalidState(format!("Invalid command received: {:?}", err)))
3130
.map_err(map_err_trace!()) {
3231
Ok(cmd) => cmd,
33-
Err(_) => {return None;}
32+
Err(_) => { return None; }
3433
};
3534
let id = cmd.get(1).map(|cmd: &Vec<u8>| LittleEndian::read_i32(cmd.as_slice()))
3635
.unwrap_or(-1);
3736
if "exit".eq(cmd_s.as_str()) {
3837
Some(PoolEvent::Close(id))
3938
} else if "refresh".eq(cmd_s.as_str()) {
4039
Some(PoolEvent::Refresh(id))
41-
} else if "connect".eq(cmd_s.as_str()){
40+
} else if "connect".eq(cmd_s.as_str()) {
4241
Some(PoolEvent::CheckCache(id))
4342
} else {
4443
Some(PoolEvent::SendRequest(id, cmd_s))

libindy/src/services/pool/events.rs

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
1-
use services::pool::types::*;
2-
use errors::common::CommonError;
31
use domain::ledger::constants;
4-
2+
use errors::common::CommonError;
3+
use errors::pool::PoolError;
4+
use self::indy_crypto::utils::json::JsonEncodable;
55
use serde_json;
66
use serde_json::Value as SJsonValue;
7-
use std::error::Error;
87
use services::ledger::merkletree::merkletree::MerkleTree;
9-
use errors::pool::PoolError;
8+
use services::pool::types::*;
9+
use std::error::Error;
1010

1111
extern crate indy_crypto;
1212

13-
use self::indy_crypto::utils::json::JsonEncodable;
14-
1513

1614
pub const REQUESTS_FOR_STATE_PROOFS: [&'static str; 7] = [
1715
constants::GET_NYM,
@@ -84,20 +82,20 @@ pub enum PoolEvent {
8482
Timeout(
8583
String, //req_id
8684
String, //node alias
87-
)
85+
),
8886
}
8987

9088
#[derive(Clone, Debug)]
9189
pub enum RequestEvent {
9290
LedgerStatus(
9391
LedgerStatus,
9492
Option<String>, //node alias
95-
Option<MerkleTree>
93+
Option<MerkleTree>,
9694
),
9795
CatchupReq(
9896
MerkleTree,
9997
usize, // target mt size
100-
Vec<u8> // target mt root
98+
Vec<u8>, // target mt root
10199
),
102100
Timeout(
103101
String, //req_id
@@ -182,7 +180,7 @@ impl Into<Option<RequestEvent>> for PoolEvent {
182180
Message::ConsistencyProof(cp) => RequestEvent::ConsistencyProof(cp, node_alias),
183181
Message::Reply(rep) => {
184182
let req_id = rep.req_id();
185-
RequestEvent::Reply(rep, msg, node_alias,req_id.to_string())
183+
RequestEvent::Reply(rep, msg, node_alias, req_id.to_string())
186184
}
187185
Message::ReqACK(rep) => {
188186
let req_id = rep.req_id();
@@ -191,16 +189,16 @@ impl Into<Option<RequestEvent>> for PoolEvent {
191189
Message::ReqNACK(rep) => {
192190
let req_id = rep.req_id();
193191
RequestEvent::ReqNACK(rep, msg, node_alias, req_id.to_string())
194-
},
192+
}
195193
Message::Reject(rep) => {
196194
let req_id = rep.req_id();
197195
RequestEvent::Reject(rep, msg, node_alias, req_id.to_string())
198-
},
196+
}
199197
Message::PoolLedgerTxns(_) => RequestEvent::PoolLedgerTxns,
200198
Message::Ping => RequestEvent::Ping,
201199
Message::Pong => RequestEvent::Pong,
202200
})
203-
},
201+
}
204202
PoolEvent::SendRequest(_, msg) => {
205203
let req_id = _parse_req_id_and_op(&msg);
206204
match req_id {
@@ -223,7 +221,7 @@ impl Into<Option<NetworkerEvent>> for RequestEvent {
223221
RequestEvent::LedgerStatus(ls, _, _) => {
224222
let req_id = ls.merkleRoot.clone();
225223
Some(NetworkerEvent::SendAllRequest(Message::LedgerStatus(ls).to_json().expect("FIXME"), req_id))
226-
},
224+
}
227225
_ => None
228226
}
229227
}

libindy/src/services/pool/merkle_tree_factory.rs

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,20 @@
11
extern crate byteorder;
22
extern crate rmp_serde;
33

4-
use errors::pool::PoolError;
5-
use std::path::PathBuf;
6-
use services::ledger::merkletree::merkletree::MerkleTree;
7-
use std::fs;
8-
use std::str::from_utf8;
9-
use self::byteorder::{LittleEndian, WriteBytesExt, ReadBytesExt};
4+
use domain::ledger::request::ProtocolVersion;
105
use errors::common::CommonError;
11-
use std::io;
12-
use std::io::{Read, BufRead, Write};
13-
use utils::environment::EnvironmentUtils;
6+
use errors::pool::PoolError;
7+
use self::byteorder::{LittleEndian, ReadBytesExt, WriteBytesExt};
148
use serde_json;
159
use serde_json::Value as SJsonValue;
10+
use services::ledger::merkletree::merkletree::MerkleTree;
11+
use services::pool::types::{NodeTransaction, NodeTransactionV0, NodeTransactionV1};
12+
use std::{fs, io};
1613
use std::collections::HashMap;
17-
use services::pool::types::NodeTransactionV1;
18-
use services::pool::types::NodeTransaction;
19-
use domain::ledger::request::ProtocolVersion;
20-
use services::pool::types::NodeTransactionV0;
14+
use std::io::{BufRead, Read, Write};
15+
use std::path::PathBuf;
16+
use std::str::from_utf8;
17+
use utils::environment::EnvironmentUtils;
2118

2219
pub fn create(pool_name: &str) -> Result<MerkleTree, PoolError> {
2320
let mut p = EnvironmentUtils::pool_path(pool_name);
@@ -93,7 +90,7 @@ fn _from_genesis(file_name: &PathBuf) -> Result<MerkleTree, PoolError> {
9390
Ok(mt)
9491
}
9592

96-
pub fn dump_new_txns(pool_name: &str, txns: &Vec<Vec<u8>>) -> Result<(), PoolError>{
93+
pub fn dump_new_txns(pool_name: &str, txns: &Vec<Vec<u8>>) -> Result<(), PoolError> {
9794
let mut p = EnvironmentUtils::pool_path(pool_name);
9895

9996
p.push("stored");
@@ -127,7 +124,7 @@ fn _dump_genesis_to_stored(p: &PathBuf, pool_name: &str) -> Result<(), PoolError
127124
_dump_vec_to_file(&genesis_vec, &mut file)
128125
}
129126

130-
fn _dump_vec_to_file(v: &Vec<Vec<u8>>, file : &mut fs::File) -> Result<(), PoolError> {
127+
fn _dump_vec_to_file(v: &Vec<Vec<u8>>, file: &mut fs::File) -> Result<(), PoolError> {
131128
v.into_iter().map(|vec| {
132129
file.write_u64::<LittleEndian>(vec.len() as u64).map_err(map_err_trace!())?;
133130
file.write_all(vec).map_err(map_err_trace!())
@@ -220,14 +217,13 @@ pub fn from_file(txn_file: &str) -> Result<MerkleTree, PoolError> {
220217
}
221218

222219

223-
224220
#[cfg(test)]
225221
mod tests {
226-
use super::*;
227-
use utils::test::TestUtils;
228-
use std::fs;
229222
use byteorder::LittleEndian;
230223
use domain::ledger::request::ProtocolVersion;
224+
use std::fs;
225+
use super::*;
226+
use utils::test::TestUtils;
231227

232228
fn _set_protocol_version(version: usize) {
233229
ProtocolVersion::set(version);
@@ -376,8 +372,8 @@ mod tests {
376372

377373
_write_genesis_txns(&txns_src);
378374

379-
let merkle_tree =super::create("test").unwrap();
380-
let res =super::build_node_state(&merkle_tree);
375+
let merkle_tree = super::create("test").unwrap();
376+
let res = super::build_node_state(&merkle_tree);
381377
assert_match!(Err(PoolError::PoolIncompatibleProtocolVersion(_)), res);
382378
}
383379
}

libindy/src/services/pool/mod.rs

Lines changed: 7 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,23 @@
1-
mod types;
21
mod catchup;
3-
//mod transaction_handler;
4-
mod state_proof;
5-
//mod pool_worker;
6-
7-
mod pool;
8-
mod merkle_tree_factory;
9-
mod networker;
102
mod commander;
113
mod events;
4+
mod merkle_tree_factory;
5+
mod networker;
6+
mod pool;
127
mod request_handler;
8+
mod state_proof;
9+
mod types;
1310

1411
extern crate byteorder;
1512
extern crate digest;
1613
extern crate hex;
14+
extern crate indy_crypto;
1715
extern crate rand;
1816
extern crate rust_base58;
17+
extern crate rmp_serde;
1918
extern crate sha2;
2019
extern crate time;
2120
extern crate zmq;
22-
extern crate rmp_serde;
23-
extern crate indy_crypto;
2421

2522

2623
use self::byteorder::{ByteOrder, LittleEndian};
@@ -503,73 +500,6 @@ mod tests {
503500
drop_test();
504501
TestUtils::cleanup_storage();
505502
}
506-
//
507-
// impl Default for PoolWorker {
508-
// fn default() -> Self {
509-
// PoolWorker {
510-
// pool_id: 0,
511-
// cmd_sock: zmq::Context::new().socket(zmq::SocketType::PAIR).unwrap(),
512-
// open_cmd_id: 0,
513-
// name: "".to_string(),
514-
// handler: PoolWorkerHandler::CatchupHandler(CatchupHandler {
515-
// timeout: time::now_utc().add(Duration::seconds(2)),
516-
// ..Default::default()
517-
// }),
518-
// }
519-
// }
520-
// }
521-
522-
// #[test]
523-
// fn pool_worker_get_zmq_poll_items_works() {
524-
// TestUtils::cleanup_storage();
525-
//
526-
// let pw: PoolWorker = Default::default();
527-
//
528-
// let poll_items = pw.get_zmq_poll_items().unwrap();
529-
//
530-
// assert_eq!(poll_items.len(), pw.handler.nodes().len() + 1);
531-
// //TODO compare poll items
532-
// }
533-
534-
// #[test]
535-
// fn catchup_handler_start_catchup_works() {
536-
// TestUtils::cleanup_storage();
537-
//
538-
// let mut ch: CatchupHandler = Default::default();
539-
// let (gt, handle) = nodes_emulator::start();
540-
// ch.merkle_tree.append(rmp_serde::to_vec_named(&gt).unwrap()).unwrap();
541-
// let mut rn: RemoteNode = RemoteNode::new(&gt).unwrap();
542-
// rn.connect(&zmq::Context::new(), &zmq::CurveKeyPair::new().unwrap()).unwrap();
543-
// ch.nodes.push(rn);
544-
// ch.target_mt_size = 2;
545-
//
546-
// ch.start_catchup().unwrap();
547-
//
548-
// let emulator_msgs: Vec<String> = handle.join().unwrap();
549-
// assert_eq!(1, emulator_msgs.len());
550-
// let expected_resp: CatchupReq = CatchupReq {
551-
// ledgerId: 0,
552-
// seqNoStart: 2,
553-
// seqNoEnd: 2,
554-
// catchupTill: 2,
555-
// };
556-
// let act_resp = CatchupReq::from_json(emulator_msgs[0].as_str()).unwrap();
557-
// assert_eq!(expected_resp, act_resp);
558-
// }
559-
560-
// #[test]
561-
// fn remote_node_connect_works_and_can_ping_pong() {
562-
// TestUtils::cleanup_storage();
563-
//
564-
// let (gt, handle) = nodes_emulator::start();
565-
// let mut rn: RemoteNode = RemoteNode::new(&gt).unwrap();
566-
// let ctx = zmq::Context::new();
567-
// rn.connect(&ctx, &zmq::CurveKeyPair::new().unwrap()).unwrap();
568-
// rn.send_str("pi").expect("send");
569-
// rn.zsock.as_ref().expect("sock").poll(zmq::POLLIN, nodes_emulator::POLL_TIMEOUT).expect("poll");
570-
// assert_eq!("po", rn.zsock.as_ref().expect("sock").recv_string(zmq::DONTWAIT).expect("recv").expect("string").as_str());
571-
// handle.join().expect("join");
572-
// }
573503

574504
pub mod nodes_emulator {
575505
extern crate sodiumoxide;

libindy/src/services/pool/networker.rs

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
extern crate zmq;
22
extern crate time;
33

4-
use self::zmq::PollItem;
5-
use self::zmq::Socket as ZSocket;
6-
74
use errors::common::CommonError;
85
use errors::pool::PoolError;
6+
use self::zmq::PollItem;
7+
use self::zmq::Socket as ZSocket;
98
use services::pool::events::*;
109
use services::pool::types::*;
11-
use std::collections::{BTreeMap, HashMap};
1210
use std::cell::RefCell;
11+
use std::collections::{BTreeMap, HashMap};
1312
use super::time::Duration;
14-
use utils::sequence::SequenceUtils;
1513
use time::Tm;
14+
use utils::sequence::SequenceUtils;
1615

1716
pub trait Networker {
1817
fn new() -> Self;
@@ -354,12 +353,12 @@ impl Networker for MockNetworker {
354353

355354
#[cfg(test)]
356355
pub mod networker_tests {
357-
use super::*;
358-
use services::pool::tests::nodes_emulator;
359-
use utils::crypto::box_::CryptoBox;
360356
use services::pool::rust_base58::FromBase58;
357+
use services::pool::tests::nodes_emulator;
361358
use std;
362359
use std::thread;
360+
use super::*;
361+
use utils::crypto::box_::CryptoBox;
363362

364363
const REQ_ID: &'static str = "1";
365364
const MESSAGE: &'static str = "msg";
@@ -634,8 +633,8 @@ pub mod networker_tests {
634633

635634
#[cfg(test)]
636635
mod pool_connection {
637-
use super::*;
638636
use std::ops::Sub;
637+
use super::*;
639638

640639
#[test]
641640
fn pool_connection_new_works() {

0 commit comments

Comments
 (0)