Skip to content

Commit 550225f

Browse files
committed
Test Only: compare lowercase Etags for equivalency
* In 1.0.3 Etag values are becoming SHOULD* lowercase, so default our known value to lowercase and then lowercase the received value which should be a no-op for well behaved LRSs and not be invalid for non-SHOULD* following LRSs
1 parent 9b6ad80 commit 550225f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/test/java/com/rusticisoftware/tincan/RemoteLRSTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ public void testRetrieveState() throws Exception {
386386
Assert.assertTrue(save.getSuccess());
387387

388388
StateLRSResponse lrsRes = lrs.retrieveState("test", activity, agent, null);
389-
Assert.assertEquals("\"C140F82CB70E3884AD729B5055B7EAA81C795F1F\"", lrsRes.getContent().getEtag());
389+
Assert.assertEquals("\"c140f82cb70e3884ad729b5055b7eaa81c795f1f\"", lrsRes.getContent().getEtag().toLowerCase());
390390
Assert.assertTrue(lrsRes.getSuccess());
391391
}
392392

@@ -539,7 +539,7 @@ public void testRetrieveActivityProfile() throws Exception {
539539
Assert.assertTrue(save.getSuccess());
540540

541541
ActivityProfileLRSResponse lrsRes = lrs.retrieveActivityProfile("test", activity);
542-
Assert.assertEquals("\"6E6E6C11D7E0BFFE0369873A2A5FD751AB2EA64F\"", lrsRes.getContent().getEtag());
542+
Assert.assertEquals("\"6e6e6c11d7e0bffe0369873a2a5fd751ab2ea64f\"", lrsRes.getContent().getEtag().toLowerCase());
543543
Assert.assertTrue(lrsRes.getSuccess());
544544
}
545545

@@ -688,7 +688,7 @@ public void testRetrieveAgentProfile() throws Exception {
688688
Assert.assertTrue(save.getSuccess());
689689

690690
AgentProfileLRSResponse lrsRes = lrs.retrieveAgentProfile("test", agent);
691-
Assert.assertEquals("\"DA16D3E0CBD55E0F13558AD0ECFD2605E2238C71\"", lrsRes.getContent().getEtag());
691+
Assert.assertEquals("\"da16d3e0cbd55e0f13558ad0ecfd2605e2238c71\"", lrsRes.getContent().getEtag().toLowerCase());
692692
Assert.assertTrue(lrsRes.getSuccess());
693693
}
694694

0 commit comments

Comments
 (0)