Skip to content

ord argument not used for any instrument #53

@hematthi

Description

@hematthi

#max_col_default(::NEID2D, ord::Integer) = 8429 # DRS 0.5
#max_col_default(::NEID2D, ord::Integer) = 6214 # DRS 0.6, avoiding NaN in col 6215
#max_col_default(::NEID2D, ord::Integer) = 9215 # DRS 0.6, 0.7
min_col_default(::NEID2D, ord::Integer) = 1500 # Avoid where continuum normalization effected by edges/scattered light
max_col_default(::NEID2D, ord::Integer) = 8000 # Avoid where continuum normalization effected by edges/scattered light
import RvSpectMLBase: get_pixel_range
function get_pixel_range(inst::NEID2D, ord::Integer)
minc = max(min_col_default(inst, ord)) #, min_col_excalibur(inst,order), min_col_nonnan(inst,order))
maxc = min(max_col_default(inst, ord)) #, max_col_excalibur(inst,order), max_col_nonnan(inst,order))
return minc:maxc
end

Any reason why ord is a required argument for these functions even though the col numbers do not depend on order (this appears true for all the instruments)? Is this simply in anticipation for when it might be order dependent in the future?

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions