Skip to content

Commit 6be8593

Browse files
committed
Merge pull request #12 from ashfurrow/merge
Merge
2 parents 9a858f8 + 3f3af03 commit 6be8593

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

Action.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,7 @@ public extension Action {
7777
public func execute(input: Input) -> Observable<Element> {
7878

7979
// Buffer from the work to a replay subject.
80-
// TODO: The buffer size is set to ten because ten is "big enough"
81-
// We're tracking this here: https://github.com/ashfurrow/Action/issues/3
82-
let buffer = ReplaySubject<Element>.create(bufferSize: 10)
80+
let buffer = ReplaySubject<Element>.createUnbounded()
8381

8482
// See if we're already executing.
8583
var startedExecuting = false

Changelog.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@ Changelog
44
Current master
55
--------------
66

7-
Nothing yet!
7+
0.4.0
8+
-----
9+
10+
- Unbounded replaying of event values (see [#3](https://github.com/ashfurrow/Action/issues/3)).
811

912
0.3.0
1013
-----

Demo/DemoTests/ButtonTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class ButtonTests: QuickSpec {
7777
// Normally I'd use subject.sendActionsForControlEvents(.TouchUpInside) but it's not working
7878
for target in subject.allTargets() {
7979
for action in subject.actionsForTarget(target, forControlEvent: .TouchUpInside) ?? [] {
80-
target.performSelector(Selector(action))
80+
target.performSelector(Selector(action), withObject: subject)
8181
}
8282
}
8383

Demo/Podfile.lock

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
PODS:
2-
- Action (0.2.0):
2+
- Action (0.3.0):
33
- RxCocoa (~> 2.0.0-beta)
44
- RxSwift (~> 2.0.0-beta)
55
- Nimble (3.0.0)
66
- Quick (0.8.0)
7-
- RxBlocking (2.0.0-beta.3):
7+
- RxBlocking (2.0.0-beta.4):
88
- RxSwift (~> 2.0.0-beta)
9-
- RxCocoa (2.0.0-beta.3):
9+
- RxCocoa (2.0.0-beta.4):
1010
- RxSwift (~> 2.0.0-beta)
11-
- RxSwift (2.0.0-beta.3)
11+
- RxSwift (2.0.0-beta.4)
1212

1313
DEPENDENCIES:
1414
- Action (from `../`)
@@ -23,11 +23,11 @@ EXTERNAL SOURCES:
2323
:path: "../"
2424

2525
SPEC CHECKSUMS:
26-
Action: 836da3ae9615435467a3d1cddd384f4ea6036ba2
26+
Action: da3ac4ae245c10f909fd07db34680a90beb4aa21
2727
Nimble: 4c353d43735b38b545cbb4cb91504588eb5de926
2828
Quick: 563d0f6ec5f72e394645adb377708639b7dd38ab
29-
RxBlocking: 331f8bdedf77198f8ff1a37f09c492f1f4f631e5
30-
RxCocoa: 1472006304b296d03c847f78b21384523cc4902e
31-
RxSwift: 19fbe885b404d1d36d42ac8535134739a9b42952
29+
RxBlocking: 234b0c161315ff3ade25c11e48d74e9ca83158b5
30+
RxCocoa: 4a3e433e6dfe116362ff54423c841cc0f209e009
31+
RxSwift: 191c6b06da783a8671433cf35a54d2ad2fd2d9de
3232

3333
COCOAPODS: 0.39.0

0 commit comments

Comments
 (0)