Skip to content

[Swift Package] Add minimum platform version to conform to RxSwift dependency #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Swift Package] Add minimum platform version to conform to RxSwift dependency #224

wants to merge 4 commits into from

Conversation

frboulais
Copy link

Action framework needs to specify its minimum platforms versions to be sure they don't conflict with its dependency ones.

Screenshot 2020-12-15 at 15 25 25

@bobgodwinx
Copy link
Member

@frboulais Thanks for the update.

  • Can you please remove d66f5c3 and 02b1a26 from the history. That would be nice 😎

@frboulais
Copy link
Author

@bobgodwinx How am I supposed to remove the commits?
I can restart the PR if you prefer! 👍

@bobgodwinx
Copy link
Member

Use git rebase -- interactive eaf6866 and then add a d in the front of d66f5c3 and 02b1a26 then press esc and then :wq to save. That should do the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frboulais @bobgodwinx