Reduce computational complexity by using 'isEmpty'

Author: shoheiyokoyama

Sources/Differentiator/Changeset.swift

@@ -78,15 +78,15 @@ extension Changeset
         let serializedSections = "[\n" + finalSections.map { "\($0)" }.joined(separator: ",\n") + "\n]\n"
         return " >> Final sections"
         + "   \n\(serializedSections)"
-        + (insertedSections.count > 0 || deletedSections.count > 0 || movedSections.count > 0 || updatedSections.count > 0 ? "\nSections:" : "")
-        + (insertedSections.count > 0 ? "\ninsertedSections:\n\t\(insertedSections)" : "")
-        + (deletedSections.count > 0 ?  "\ndeletedSections:\n\t\(deletedSections)" : "")
-        + (movedSections.count > 0 ? "\nmovedSections:\n\t\(movedSections)" : "")
-        + (updatedSections.count > 0 ? "\nupdatesSections:\n\t\(updatedSections)" : "")
-            + (insertedItems.count > 0 || deletedItems.count > 0 || movedItems.count > 0 || updatedItems.count > 0 ? "\nItems:" : "")
-        + (insertedItems.count > 0 ? "\ninsertedItems:\n\t\(insertedItems)" : "")
-        + (deletedItems.count > 0 ? "\ndeletedItems:\n\t\(deletedItems)" : "")
-        + (movedItems.count > 0 ? "\nmovedItems:\n\t\(movedItems)" : "")
-        + (updatedItems.count > 0 ? "\nupdatedItems:\n\t\(updatedItems)" : "")
+        + (!insertedSections.isEmpty || !deletedSections.isEmpty || !movedSections.isEmpty || !updatedSections.isEmpty ? "\nSections:" : "")
+        + (!insertedSections.isEmpty ? "\ninsertedSections:\n\t\(insertedSections)" : "")
+        + (!deletedSections.isEmpty ?  "\ndeletedSections:\n\t\(deletedSections)" : "")
+        + (!movedSections.isEmpty ? "\nmovedSections:\n\t\(movedSections)" : "")
+        + (!updatedSections.isEmpty ? "\nupdatesSections:\n\t\(updatedSections)" : "")
+            + (!insertedItems.isEmpty || !deletedItems.isEmpty || !movedItems.isEmpty || !updatedItems.isEmpty ? "\nItems:" : "")
+        + (!insertedItems.isEmpty ? "\ninsertedItems:\n\t\(insertedItems)" : "")
+        + (!deletedItems.isEmpty ? "\ndeletedItems:\n\t\(deletedItems)" : "")
+        + (!movedItems.isEmpty ? "\nmovedItems:\n\t\(movedItems)" : "")
+        + (!updatedItems.isEmpty ? "\nupdatedItems:\n\t\(updatedItems)" : "")
     }
 }

Sources/Differentiator/Diff.swift

@@ -648,7 +648,7 @@ public enum Diff {
             }
             // }
 
-            if deletedItems.count == 0 && deletedSections.count == 0 && updatedItems.count == 0 {
+            if deletedItems.isEmpty && deletedSections.isEmpty && updatedItems.isEmpty {
                 return []
             }
 
@@ -687,7 +687,7 @@ public enum Diff {
                 }
             }
 
-            if insertedSections.count ==  0 && movedSections.count == 0 {
+            if insertedSections.isEmpty && movedSections.isEmpty {
                 return []
             }
 
@@ -780,7 +780,7 @@ public enum Diff {
             }
             // }
 
-            if insertedItems.count == 0 && movedItems.count == 0 {
+            if insertedItems.isEmpty && movedItems.isEmpty {
                 return []
             }
             return [Changeset(