fix(ci.yml): false positive triggers script validation failure on force push #153
Description
Tip
This issue hasn't been claimed yet. Comment /take if you'd like to work on it!
Describe your issue
The validate-scripts job in the ci.yml workflow fails when the commut history changes (e.g., via a force push) - this is an unintended failure.
Steps to reproduce
- A contributor pushes 2 commits to their PR.
- They realise they forgot something in their most recent commit, so they amend it (using
git commit --amend). - They force push their amended changes to update the PR.
- "Run script validation" in the
validate-scriptsjob ofci.ymlfails because the history has changed.
What was the expected result?
The job should have passed since no npm scripts were added - this wasn't the case because of a bad check.
Important
See the implementation in #153 - it is good but needs docs.