Skip to content

Commit 658d9a9

Browse files
committed
Fix Timestamp issue, minor fix on test
1 parent 3902ce3 commit 658d9a9

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

onelogin/saml/AuthRequest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def create(_clock=None, _uuid=None, _zlib=None, _base64=None,
5454
# http://docs.oasis-open.org/security/saml/v2.0/saml-core-2.0-os.pdf Section
5555
# 1.3.3
5656
now = now.replace(microsecond=0)
57-
now_iso = now.isoformat()
57+
now_iso = now.isoformat() + 'Z'
5858

5959
unique_id = _uuid()
6060
unique_id = unique_id.hex

onelogin/saml/test/TestAuthRequest.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ def fake_clock():
2323
fake_zlib = fudge.Fake('zlib')
2424
fake_zlib.remember_order()
2525
fake_compress = fake_zlib.expects('compress')
26-
fake_compress.with_args(
27-
"""<samlp:AuthnRequest xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol" ProtocolBinding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Version="2.0" IssueInstant="2011-07-09T19:24:52" ID="hex_uuid" AssertionConsumerServiceURL="http://foo.bar/consume"><saml:Issuer xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion">foo_issuer</saml:Issuer><samlp:NameIDPolicy AllowCreate="true" Format="urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress"/><samlp:RequestedAuthnContext Comparison="exact"><saml:AuthnContextClassRef xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion">urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport</saml:AuthnContextClassRef></samlp:RequestedAuthnContext></samlp:AuthnRequest>"""
28-
)
26+
uncompressed_req = """<samlp:AuthnRequest xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol" ProtocolBinding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Version="2.0" IssueInstant="2011-07-09T19:24:52" ID="hex_uuid" AssertionConsumerServiceURL="http://foo.bar/consume"><saml:Issuer xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion">foo_issuer</saml:Issuer><samlp:NameIDPolicy AllowCreate="true" Format="urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress"/><samlp:RequestedAuthnContext Comparison="exact"><saml:AuthnContextClassRef xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion">urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport</saml:AuthnContextClassRef></samlp:RequestedAuthnContext></samlp:AuthnRequest>"""
2927
fake_compress.returns('HDfoo_compressedCHCK')
3028

3129
fake_base64 = fudge.Fake('base64')

0 commit comments

Comments
 (0)