Minor test fixes

Author: pitbulk

src/onelogin/saml2/errors.py

@@ -109,6 +109,7 @@ class OneLogin_Saml2_ValidationError(Exception):
     DUPLICATED_ATTRIBUTE_NAME_FOUND = 41
     INVALID_SIGNATURE = 42
     WRONG_NUMBER_OF_SIGNATURES = 43
+    RESPONSE_EXPIRED = 44
 
     def __init__(self, message, code=0, errors=None):
         """

src/onelogin/saml2/logout_request.py

@@ -309,7 +309,10 @@ def is_valid(self, request_data, raise_exceptions=False):
                 if dom.get('NotOnOrAfter', None):
                     na = OneLogin_Saml2_Utils.parse_SAML_to_time(dom.get('NotOnOrAfter'))
                     if na <= OneLogin_Saml2_Utils.now():
-                        raise Exception('Could not validate timestamp: expired. Check system clock.')
+                        raise OneLogin_Saml2_ValidationError(
+                            'Could not validate timestamp: expired. Check system clock.',
+                            OneLogin_Saml2_ValidationError.RESPONSE_EXPIRED
+                        )
 
                 # Check destination
                 if dom.get('Destination', None):
@@ -322,7 +325,8 @@ def is_valid(self, request_data, raise_exceptions=False):
                                 {
                                     'currentURL': current_url,
                                     'destination': destination,
-                                }
+                                },
+                                OneLogin_Saml2_ValidationError.WRONG_DESTINATION
                             )
 
                 # Check issuer

tests/src/OneLogin/saml2_tests/response_test.py

@@ -61,7 +61,7 @@ def testConstruct(self):
 
         self.assertIsInstance(response_enc, OneLogin_Saml2_Response)
 
-    def test_get_xml_document(self):
+    def testGetXMLDocument(self):
         """
         Tests that we can retrieve the raw text of an encrypted XML response
         without going through intermediate steps