Skip to content

Commit d1bd595

Browse files
committed
Discourage the use of fingerprint on production environments
1 parent d8e0109 commit d1bd595

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ In production, the **strict** parameter MUST be set as **"true"**. Otherwise
132132
your environment is not secure and will be exposed to attacks.
133133

134134

135+
In production also we highly recommend to register on the settings the IdP certificate instead of using the fingerprint method. The fingerprint, is a hash, so at the end is open to a collision attack that can end on a signature validation bypass. Other SAML toolkits deprecated that mechanism, we maintain it for compatibility and also to be used on test environment.
136+
135137
Getting started
136138
---------------
137139

@@ -326,7 +328,9 @@ This is the settings.json file:
326328
"x509cert": "<onelogin_connector_cert>"
327329
/*
328330
* Instead of using the whole x509cert you can use a fingerprint in order to
329-
* validate a SAMLResponse, but you will need it to validate LogoutRequest and LogoutResponse using the HTTP-Redirect binding.
331+
* validate a SAMLResponse (but you still need the x509cert to validate LogoutRequest and LogoutResponse using the HTTP-Redirect binding).
332+
* But take in mind that the fingerprint, is a hash, so at the end is open to a collision attack that can end on a signature validation bypass,
333+
* that why we don't recommend it use for production environments.
330334
*
331335
* (openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
332336
* or add for example the -sha256 , -sha384 or -sha512 parameter)
@@ -337,6 +341,7 @@ This is the settings.json file:
337341
*
338342
* Notice that if you want to validate any SAML Message sent by the HTTP-Redirect binding, you
339343
* will need to provide the whole x509cert.
344+
*
340345
*/
341346
// 'certFingerprint': '',
342347
// 'certFingerprintAlgorithm': 'sha1',

0 commit comments

Comments
 (0)