Skip to content

Commit ef91db1

Browse files
committed
Improve previous commited tests
1 parent 30cbe7c commit ef91db1

File tree

2 files changed

+202
-71
lines changed

2 files changed

+202
-71
lines changed

src/onelogin/saml2/response.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -425,8 +425,6 @@ def get_nameid_data(self):
425425
is_strict = self.__settings.is_strict()
426426
want_nameid = self.__settings.get_security_data().get('wantNameId', True)
427427
if nameid is None:
428-
security = self.__settings.get_security_data()
429-
430428
if is_strict and want_nameid:
431429
raise OneLogin_Saml2_ValidationError(
432430
'NameID not found in the assertion of the Response',
@@ -443,7 +441,7 @@ def get_nameid_data(self):
443441
for attr in ['Format', 'SPNameQualifier', 'NameQualifier']:
444442
value = nameid.get(attr, None)
445443
if value:
446-
if self.__settings.is_strict() and attr == 'SPNameQualifier':
444+
if is_strict and attr == 'SPNameQualifier':
447445
sp_data = self.__settings.get_sp_data()
448446
sp_entity_id = sp_data.get('entityId', '')
449447
if sp_entity_id != value:

0 commit comments

Comments
 (0)