Don't use Exception, use StandardError

It's bad Ruby practice to have Error classes inherit directly from
Exception, or to raise instances of Exception itself. It is highly
recommended that any custom error classes inherit instead from
StandardError. StandardError is also the go-to exception class for when
you need to raise an error without a custom class.

Signed-off-by: David Celis <[email protected]>

Author: davidcelis

lib/onelogin/ruby-saml/logoutresponse.rb

@@ -105,7 +105,7 @@ def valid_saml?(soft = true)
         if soft
           @schema.validate(@xml).map{ return false }
         else
-          @schema.validate(@xml).map{ |error| raise(Exception.new("#{error.message}\n\n#{@xml.to_s}")) }
+          @schema.validate(@xml).map{ |error| raise(StandardError.new("#{error.message}\n\n#{@xml.to_s}")) }
         end
       end
 
@@ -151,4 +151,4 @@ def validation_error(message)
       end
     end
   end
-end
+end

lib/onelogin/ruby-saml/validation_error.rb

@@ -1,6 +1,6 @@
 module Onelogin
   module Saml
-    class ValidationError < Exception
+    class ValidationError < StandardError
     end
   end
 end

test/logoutresponse_test.rb

@@ -102,7 +102,7 @@ class RubySamlTest < Test::Unit::TestCase
       should "raise error for invalid xml" do
         logoutresponse = Onelogin::Saml::Logoutresponse.new(invalid_xml_response, settings)
 
-        assert_raises(Exception) { logoutresponse.validate! }
+        assert_raises(StandardError) { logoutresponse.validate! }
       end
     end