Merge pull request #578 from onelogin/fix_xpath

pitbulk · web-flow · commit 3ed4da363fc0 · 2021-04-05T22:58:02.000+02:00
See #577. Fix XPath typo incompatible with Rexml 3.2.5
diff --git a/lib/onelogin/ruby-saml/response.rb b/lib/onelogin/ruby-saml/response.rb
@@ -828,7 +828,7 @@ def validate_signature
         # otherwise, review if the decrypted assertion contains a signature
         sig_elements = REXML::XPath.match(
           document,
-          "/p:Response[@ID=$id]/ds:Signature]",
+          "/p:Response[@ID=$id]/ds:Signature",
           { "p" => PROTOCOL, "ds" => DSIG },
           { 'id' => document.signed_element_id }
         )

Original file line number	Diff line number	Diff line change
`@@ -828,7 +828,7 @@ def validate_signature`
`828`	`828`	`# otherwise, review if the decrypted assertion contains a signature`
`829`	`829`	`sig_elements = REXML::XPath.match(`
`830`	`830`	`document,`
`831`		`- "/p:Response[@ID=$id]/ds:Signature]",`
	`831`	`+ "/p:Response[@ID=$id]/ds:Signature",`
`832`	`832`	`{ "p" => PROTOCOL, "ds" => DSIG },`
`833`	`833`	`{ 'id' => document.signed_element_id }`
`834`	`834`	`)`