Commit 43b0bb6
committed
Make IdpMetadataParser#get_idp_metadata public
I have a use-case for being able to cache the intermediate fetch of
metadata in case of temporary failures, so rather than:
parser.parse_remote(url)
I'd like to
begin
metadata = parser.get_idp_metadata(url, true)
do_my_caching(metadata)
parser.parse(metadata)
rescue HttpError
load_cache
end
There's a fair amount of logic in the get_idp_metadata method that I'd
rather not need to re-implement. Right now I have this implemented with
`parser.send(:get_idp_metadata, url, true)` which is obviously not great
if the internals of this class change in the future. Can we move this
method to the public API?1 parent f40c59b commit 43b0bb6
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
190 | | - | |
191 | 189 | | |
192 | 190 | | |
193 | 191 | | |
| |||
220 | 218 | | |
221 | 219 | | |
222 | 220 | | |
| 221 | + | |
| 222 | + | |
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
| |||
0 commit comments