Merge pull request #632 from onelogin/minor_test_fix

Make the uuid editable and make a minor test fix

Author: pitbulk

lib/onelogin/ruby-saml/authrequest.rb

@@ -15,7 +15,7 @@ module RubySaml
     class Authrequest < SamlMessage
 
       # AuthNRequest ID
-      attr_reader :uuid
+      attr_accessor :uuid
 
       # Initializes the AuthNRequest. An Authrequest Object that is an extension of the SamlMessage class.
       # Asigns an ID, a random uuid.

lib/onelogin/ruby-saml/logoutrequest.rb

@@ -12,7 +12,7 @@ module RubySaml
     class Logoutrequest < SamlMessage
 
       # Logout Request ID
-      attr_reader :uuid
+      attr_accessor :uuid
 
       # Initializes the Logout Request. A Logoutrequest Object that is an extension of the SamlMessage class.
       # Asigns an ID, a random uuid.

lib/onelogin/ruby-saml/slo_logoutresponse.rb

@@ -13,7 +13,7 @@ module RubySaml
     class SloLogoutresponse < SamlMessage
 
       # Logout Response ID
-      attr_reader :uuid
+      attr_accessor :uuid
 
       # Initializes the Logout Response. A SloLogoutresponse Object that is an extension of the SamlMessage class.
       # Asigns an ID, a random uuid.

test/logoutrequest_test.rb

@@ -308,5 +308,16 @@ class RequestTest < Minitest::Test
         assert cert.public_key.verify(signature_algorithm.new, Base64.decode64(params['Signature']), query_string)
       end
     end
+
+    describe "#manipulate request_id" do
+      it "be able to modify the request id" do
+        logoutrequest = OneLogin::RubySaml::Logoutrequest.new
+        request_id = logoutrequest.request_id
+        assert_equal request_id, logoutrequest.uuid
+        logoutrequest.uuid = "new_uuid"
+        assert_equal logoutrequest.request_id, logoutrequest.uuid
+        assert_equal "new_uuid", logoutrequest.request_id
+      end
+    end
   end
 end

test/request_test.rb

@@ -388,5 +388,16 @@ class RequestTest < Minitest::Test
         assert cert.public_key.verify(signature_algorithm.new, Base64.decode64(params['Signature']), query_string)
       end
     end
+
+    describe "#manipulate request_id" do
+      it "be able to modify the request id" do
+        authnrequest = OneLogin::RubySaml::Authrequest.new
+        request_id = authnrequest.request_id
+        assert_equal request_id, authnrequest.uuid
+        authnrequest.uuid = "new_uuid"
+        assert_equal authnrequest.request_id, authnrequest.uuid
+        assert_equal "new_uuid", authnrequest.request_id
+      end
+    end
   end
 end

test/saml_message_test.rb

@@ -72,7 +72,7 @@ class RubySamlTest < Minitest::Test
 
       describe 'with a custom setting for message_max_bytesize' do
         let(:message_max_bytesize) { 100_00 }
-        let(:settings) { OneLogin::RubySaml::Settings.new(message_max_bytesize: message_max_bytesize) }
+        let(:settings) { OneLogin::RubySaml::Settings.new({:message_max_bytesize => message_max_bytesize}) }
 
         it 'uses the custom setting' do
           assert_raises(OneLogin::RubySaml::ValidationError, "Encoded SAML Message exceeds #{message_max_bytesize} bytes, so was rejected") do
@@ -83,4 +83,4 @@ class RubySamlTest < Minitest::Test
       end
     end
   end
-end
+end

test/slo_logoutresponse_test.rb

@@ -309,5 +309,16 @@ class SloLogoutresponseTest < Minitest::Test
         assert cert.public_key.verify(signature_algorithm.new, Base64.decode64(params['Signature']), query_string)
       end
     end
+
+    describe "#manipulate response_id" do
+      it "be able to modify the response id" do
+        logoutresponse = OneLogin::RubySaml::SloLogoutresponse.new
+        response_id = logoutresponse.response_id
+        assert_equal response_id, logoutresponse.uuid
+        logoutresponse.uuid = "new_uuid"
+        assert_equal logoutresponse.response_id, logoutresponse.uuid
+        assert_equal "new_uuid", logoutresponse.response_id
+      end
+    end
   end
 end