Merge pull request #585 from caioeps/fix-trailing-char-on-status-code

Do not append " | " to OneLogin::RubySaml::Response#status_code unnecessarily

Author: pitbulk

lib/onelogin/ruby-saml/response.rb

@@ -227,11 +227,10 @@ def status_code
               statuses = nodes.collect do |inner_node|
                 inner_node.attributes["Value"]
               end
-              extra_code = statuses.join(" | ")
-              if extra_code
-                code = "#{code} | #{extra_code}"
-              end
+
+              code = [code, statuses].flatten.join(" | ")
             end
+
             code
           end
         end

test/response_test.rb

@@ -1635,6 +1635,16 @@ def generate_audience_error(expected, actual)
       end
 
     end
+
+    describe "#status_code" do
+      it 'urn:oasis:names:tc:SAML:2.0:status:Responder' do
+        assert_equal response_statuscode_responder.status_code, 'urn:oasis:names:tc:SAML:2.0:status:Responder'
+      end
+
+      it 'urn:oasis:names:tc:SAML:2.0:status:Requester and urn:oasis:names:tc:SAML:2.0:status:UnsupportedBinding' do
+        assert_equal response_double_statuscode.status_code, 'urn:oasis:names:tc:SAML:2.0:status:Requester | urn:oasis:names:tc:SAML:2.0:status:UnsupportedBinding'
+      end
+    end
     describe "test qualified name id in attributes" do
 
       it "parsed the nameid" do