Skip to content

Commit 8757701

Browse files
committed
Prefer rescuing StandardError over Exception
1 parent b3f2191 commit 8757701

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

.deepsource.toml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
version = 1
2+
3+
test_patterns = ["test/**/*_test.rb"]
4+
5+
exclude_patterns = ["gemfiles/**"]
6+
7+
[[analyzers]]
8+
name = "ruby"
9+
enabled = true

lib/onelogin/ruby-saml/saml_message.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def valid_saml?(document, soft = true)
6969
xml = Nokogiri::XML(document.to_s) do |config|
7070
config.options = XMLSecurity::BaseDocument::NOKOGIRI_OPTIONS
7171
end
72-
rescue Exception => error
72+
rescue StandardError => error
7373
return false if soft
7474
raise ValidationError.new("XML load failed: #{error.message}")
7575
end

0 commit comments

Comments
 (0)