Merge pull request #199 from Umofomia/nokogiri-dependency

Change Nokogiri's runtime dependency to fix support for Ruby 1.8.7.

Author: Lordnibbler

.travis.yml

@@ -5,3 +5,12 @@ rvm:
   - 2.0.0
   - 2.1.5
   - ree
+gemfile:
+  - Gemfile
+  - gemfiles/nokogiri-1.5.gemfile
+matrix:
+  exclude:
+    - rvm: 1.8.7
+      gemfile: Gemfile
+    - rvm: ree
+      gemfile: Gemfile

README.md

@@ -41,7 +41,7 @@ gem 'ruby-saml', '~> 0.9.1'
 gem 'ruby-saml', :github => 'onelogin/ruby-saml'
 ```
 
-Using Bundler
+Using RubyGems
 
 ```sh
 gem install ruby-saml
@@ -58,6 +58,22 @@ or just the required components individually:
 require 'onelogin/ruby-saml/authrequest'
 ```
 
+### Installation on Ruby 1.8.7
+
+This gem has a dependency on Nokogiri, which dropped support for Ruby 1.8.x in Nokogiri 1.6. When installing this gem on Ruby 1.8.7, you will need to make sure a version of Nokogiri prior to 1.6 is installed or specified if it hasn't been already.
+
+Using `Gemfile`
+
+```ruby
+gem 'nokogiri', '~> 1.5.10'
+```
+
+Using RubyGems
+
+```sh
+gem install nokogiri --version '~> 1.5.10'
+````
+
 ## The Initialization Phase
 
 This is the first request you will get from the identity provider. It will hit your application at a specific URL (that you've announced as being your SAML initialization point). The response to this initialization, is a redirect back to the identity provider, which can look something like this (ignore the saml_settings method call for now):

gemfiles/nokogiri-1.5.gemfile

@@ -0,0 +1,5 @@
+source 'http://rubygems.org'
+
+gem "nokogiri", "~> 1.5.10"
+
+gemspec :path => "../"

ruby-saml.gemspec

@@ -26,12 +26,11 @@ Gem::Specification.new do |s|
   s.test_files = `git ls-files test/*`.split("\n")
 
   s.add_runtime_dependency('uuid', '~> 2.3')
-  if RUBY_VERSION < '1.9'
-    # 1.8.7
-    s.add_runtime_dependency('nokogiri', '~> 1.5.10')
-  else
-    s.add_runtime_dependency('nokogiri', '~> 1.6.0')
-  end
+
+  # Because runtime dependencies are determined at build time, we cannot make
+  # Nokogiri's version dependent on the Ruby version, even though we would
+  # have liked to constrain Ruby 1.8.7 to install only the 1.5.x versions.
+  s.add_runtime_dependency('nokogiri', '>= 1.5.10')
 
   s.add_development_dependency('minitest', '~> 5.5')
   s.add_development_dependency('mocha',    '~> 0.14')