Skip to content

Commit b6b4de7

Browse files
committed
Updating readme using same comment as in php-saml
1 parent 61a1dbf commit b6b4de7

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

README.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ However, ruby-saml never enables this dangerous Nokogiri configuration;
6666
ruby-saml never enables DTDLOAD, and it never disables NONET.
6767

6868
The OneLogin::RubySaml::IdpMetadataParser class does not validate in any way the URL
69-
that is introduced in order to be parsed.
69+
that is introduced in order to be parsed.
7070

7171
Usually the same administrator that handles the Service Provider also sets the URL to
7272
the IdP, which should be a trusted resource.
@@ -767,7 +767,13 @@ Here is an example that we could add to our previous controller to process a SAM
767767
# Method to handle IdP initiated logouts
768768
def idp_logout_request
769769
settings = Account.get_saml_settings
770-
logout_request = OneLogin::RubySaml::SloLogoutrequest.new(params[:SAMLRequest])
770+
# ADFS URL-Encodes SAML data as lowercase, and the toolkit by default uses
771+
# uppercase. Turn it True for ADFS compatibility on signature verification
772+
settings.security[:lowercase_url_encoding] = true
773+
774+
logout_request = OneLogin::RubySaml::SloLogoutrequest.new(
775+
params[:SAMLRequest], settings: settings
776+
)
771777
if !logout_request.is_valid?
772778
logger.error "IdP initiated LogoutRequest was not valid!"
773779
return render :inline => logger.error

0 commit comments

Comments
 (0)