Skip to content

Commit da2d0cc

Browse files
committed
Modified readme as suggested
1 parent e89a31b commit da2d0cc

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,12 @@ can create an XML External Entity (XXE) vulnerability if the XML data is not tru
152152
However, ruby-saml never enables this dangerous Nokogiri configuration;
153153
ruby-saml never enables DTDLOAD, and it never disables NONET.
154154

155-
The OneLogin::RubySaml::IdpMetadataParser class does not validate in any way the URL that is introduced in order to be parsed. Usually is the same administrator that handles the Service Provider the ones that set the URL that should belong to a trusted third-party IdPs.
156-
But there are other scenarios, like a SAAS app where the administrator of the app delegates on other administrators. In such case, extra protection should be taken in order to validate such URL inputs and avoid attacks like SSRF, that could be prevented with the use of the [ssrf_filter](https://rubygems.org/gems/ssrf_filter) gem.
157155

156+
The OneLogin::RubySaml::IdpMetadataParser class does not validate in any way the URL that is introduced in order to be parsed.
158157

158+
Usually the same administrator that handles the Service Provider also sets the URL to the IdP, which should be a trusted resource.
159+
160+
But there are other scenarios, like a SAAS app where the administrator of the app delegates this functionality to other users. In this case, extra precaution should be taken in order to validate such URL inputs and avoid attacks like SSRF.
159161

160162
## Getting Started
161163
In order to use the toolkit you will need to install the gem (either manually or using Bundler), and require the library in your Ruby application:

0 commit comments

Comments
 (0)