Skip to content

Commit 97bfe6d

Browse files
authored
Merge pull request #12 from SAP-samples/docs/modules
docs: module variable descriptions
2 parents 79a253c + 05aa30d commit 97bfe6d

File tree

9 files changed

+29
-23
lines changed

9 files changed

+29
-23
lines changed

sample-setups/basic-setup/directory-setup/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ variable "directory_inputs" {
1212
}))
1313
description = <<-EOT
1414
The inputs for the directory module.
15-
- `business_unit`: Business unit of the project e.g., HR, IT or Sales
15+
- `business_unit`: Business unit of the project, such as HR, IT, or Sales
1616
- `costcenter`: Cost center to be used for subaccounts
1717
- `directory_contacts`: Contact persons to be used for directories, added as label
1818
- `region`: The geographical region for a directory. The parameter is optional

sample-setups/basic-setup/subaccount-setup/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ variable "globalaccount" {
55

66
variable "business_unit" {
77
type = string
8-
description = "Business unit of the project e.g., HR, IT or Sales"
8+
description = "Business unit of the project, such as HR, IT, or Sales"
99
}
1010

1111
variable "region" {

sample-setups/modules/base-directory-setup/outputs.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ output "directory_name" {
1010

1111
output "business_unit" {
1212
value = var.business_unit
13-
description = "Business unit of the project e.g., HR, IT or Sales"
13+
description = "Business unit of the project, such as HR, IT, or Sales"
1414
}
1515

1616
output "costcenter" {

sample-setups/modules/base-directory-setup/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
variable "business_unit" {
22
type = string
3-
description = "Business unit of the project e.g., HR, IT or Sales"
3+
description = "Business unit of the project, such as HR, IT, or Sales"
44
}
55

66
variable "region" {
@@ -20,5 +20,5 @@ variable "costcenter" {
2020

2121
variable "directory_contacts" {
2222
type = list(string)
23-
description = "Contact persons to be used for directory, added as label"
23+
description = "Contact persons to be used for the directory, added as label"
2424
}

sample-setups/modules/sap-btp-environment/cloudfoundry/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ variable "subaccount_id" {
55

66
variable "instance_name" {
77
type = string
8-
description = "Name of the Cloud Foundry environment instance."
8+
description = "Name of the Cloud Foundry runtime instance."
99

1010
validation {
1111
condition = can(regex("^[a-zA-Z0-9_\\-\\.]{1,32}$", var.instance_name))
@@ -15,7 +15,7 @@ variable "instance_name" {
1515

1616
variable "plan_name" {
1717
type = string
18-
description = "Desired service plan for the Cloud Foundry environment instance."
18+
description = "Desired service plan for the Cloud Foundry runtime instance."
1919
default = "standard"
2020
}
2121

sample-setups/modules/sap-btp-environment/kyma/variables.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
variable "subaccount_id" {
22
type = string
3-
description = "ID of the subaccount where the Cloud Foundry environment will be created."
3+
description = "ID of the subaccount where the Kyma runtime is created."
44
}
55

66
variable "instance_name" {
77
type = string
8-
description = "Name of the Kyma environment instance."
8+
description = "Name of the Kyma runtime instance."
99

1010
validation {
1111
condition = can(regex("^[a-zA-Z0-9_\\-\\.]{1,32}$", var.instance_name))
@@ -16,7 +16,7 @@ variable "instance_name" {
1616
variable "plan_name" {
1717
type = string
1818
description = <<-EOT
19-
Desired service plan for the Kyma environment instance.
19+
Desired service plan for the Kyma runtime instance.
2020
If not provided it will be set to the default value of the region.
2121
EOT
2222
default = null
@@ -31,7 +31,7 @@ variable "kyma_administrators" {
3131
variable "oidc" {
3232
description = "Custom OpenID Connect IdP configuration to authenticate users in your Kyma runtime."
3333
type = object({
34-
# the URL of the OpenID issuer (use the https schema)
34+
# the URL of the OpenID issuer (use the HTTPS schema)
3535
issuer_url = string
3636

3737
# the client ID for the OpenID client

sample-setups/modules/sap-btp-naming-conventions-directory/outputs.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ output "directory_labels" {
1515

1616
output "business_unit" {
1717
value = var.business_unit
18-
description = "Business unit of the project e.g., HR, IT or Sales"
18+
description = "Business unit of the project, such as HR, IT, or Sales"
1919
}
2020

2121
output "costcenter" {

sample-setups/modules/sap-btp-naming-conventions-directory/variables.tf

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
variable "business_unit" {
22
type = string
3-
description = "Business unit of the project e.g., HR, IT or Sales"
3+
description = "Business unit of the project, such as HR, IT, or Sales"
44
}
55

66
variable "region" {
77
type = string
88
default = null
99
description = <<-EOT
1010
The geographical region for a directory. The parameter is optional
11-
If you set it the possible values are: `EMEA`, `APAC`, `AMER`.
11+
If you set it, the possible values are: `EMEA`, `APAC`, `AMER`.
1212
Default value: `null`.
1313
EOT
1414

@@ -30,14 +30,17 @@ variable "directory_contacts" {
3030

3131
variable "add_managed_by_label" {
3232
type = bool
33-
description = "Add label that resource is managed by Terraform"
33+
description = <<-EOT
34+
Add label that the resource is managed by Terraform
35+
Default value: `true`
36+
EOT
3437
default = true
3538
}
3639

3740
variable "management_tool" {
3841
type = string
3942
description = <<-EOT
40-
Defines which tool is used for management of infrastructure.
43+
The tool that's used to manage the infrastructure.
4144
Possible values: `Terraform`, `OpenTofu`.
4245
Default value: `Terraform`.
4346
EOT
@@ -59,7 +62,7 @@ variable "label_name_case" {
5962
type = string
6063
default = "title"
6164
description = <<-EOT
62-
Controls the letter case of the `label` names for labels generated by this module.
65+
Controls the capitalization of the `label` names for labels generated by this module.
6366
Possible values: `lower`, `title`, `upper`.
6467
Default value: `title`.
6568
EOT
@@ -74,7 +77,7 @@ variable "label_value_case" {
7477
type = string
7578
default = "lower"
7679
description = <<-EOT
77-
Controls the letter case of the `label` values for labels generated by this module.
80+
Controls the capitalization of the `label` values for labels generated by this module.
7881
Possible values: `lower`, `title`, `upper` and `none` (no transformation).
7982
Default value: `lower`.
8083
EOT

sample-setups/modules/sap-btp-naming-conventions-subaccount/variables.tf

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
variable "business_unit" {
22
type = string
3-
description = "Business unit of the project e.g., HR, IT or Sales"
3+
description = "Business unit of the project, such as HR, IT, or Sales"
44
}
55

66
variable "stage" {
@@ -37,14 +37,17 @@ variable "subaccount_contacts" {
3737

3838
variable "add_managed_by_label" {
3939
type = bool
40-
description = "Add label that resource is managed by Terraform"
40+
description = <<-EOT
41+
Add label that the resource is managed by Terraform
42+
Default value: `true`
43+
EOT
4144
default = true
4245
}
4346

4447
variable "management_tool" {
4548
type = string
4649
description = <<-EOT
47-
Defines which tool is used for management of infrastructure.
50+
The tool that's used to manage the infrastructure.
4851
Possible values: `Terraform`, `OpenTofu`.
4952
Default value: `Terraform`.
5053
EOT
@@ -66,7 +69,7 @@ variable "label_name_case" {
6669
type = string
6770
default = "title"
6871
description = <<-EOT
69-
Controls the letter case of the `label` names for labels generated by this module.
72+
Controls the capitalization of the `label` names for labels generated by this module.
7073
Possible values: `lower`, `title`, `upper`.
7174
Default value: `title`.
7275
EOT
@@ -81,7 +84,7 @@ variable "label_value_case" {
8184
type = string
8285
default = "lower"
8386
description = <<-EOT
84-
Controls the letter case of the `label` values for labels generated by this module.
87+
Controls the capitalization of the `label` values for labels generated by this module.
8588
Possible values: `lower`, `title`, `upper` and `none` (no transformation).
8689
Default value: `lower`.
8790
EOT

0 commit comments

Comments
 (0)