From 377ef2666c01d54cb541ed8b3a45f96cbbcf6add Mon Sep 17 00:00:00 2001 From: Christian Lechner <22294087+lechnerc77@users.noreply.github.com.> Date: Mon, 5 May 2025 13:48:55 +0200 Subject: [PATCH 1/3] docs: review comments --- sample-setups/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sample-setups/README.md b/sample-setups/README.md index 246011b..54ff30d 100644 --- a/sample-setups/README.md +++ b/sample-setups/README.md @@ -13,7 +13,7 @@ We follow the paradigms of a simple and clear Terraform configuration as laid ou - Name with underscores, not dashes. - Using locals makes code descriptive and maintainable. -Another important paradigm is avoiding a monolithic Terraform state (*"Terralith"*). Hence, there is no single Terraform configuration for a complete SAP BTP account. Instead, we split the setup in configurations that are provisioned and managed separately. +It's important to avoid a monolithic Terraform state (*"Terralith"*). Because of that, we don't provide a single Terraform configuration for a complete SAP BTP account. Instead, we split the setup in configurations that are provisioned and managed separately. ## Overview @@ -31,7 +31,7 @@ The folder `basic-setup/subaccount-setup` contains the setup of subaccounts. For ## Modules -We have created a set of modules to encapsulate the reusable parts of the setup. The modules are located in the folder `modules`. Each module has its own README file that describes the module and its usage. +We have created a set of modules to encapsulate the reusable parts of the setup. You find the modules in the folder modules. Learn about the modules and their usage in their respective `README` files ### Naming Conventions and Labeling From e3a814ff1441a5e3665abb05a77113de06d9ed1d Mon Sep 17 00:00:00 2001 From: Christian Lechner <22294087+lechnerc77@users.noreply.github.com.> Date: Mon, 5 May 2025 13:50:43 +0200 Subject: [PATCH 2/3] docs: review comments --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b860fac..c3df2ee 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ ## Description -This repository provides samples based on the recommendations given in the [SAP BTP Administrator's Guide](https://help.sap.com/docs/btp/btp-admin-guide/btp-admin-guide) specifically the section ["Setting Up Your Account Model"](https://help.sap.com/docs/btp/btp-admin-guide/setting-up-your-account-model). +This repository provides samples based on the recommendations given in the [SAP BTP Administrator's Guide](https://help.sap.com/docs/btp/btp-admin-guide/btp-admin-guide) specifically the section [Setting Up Your Account Model](https://help.sap.com/docs/btp/btp-admin-guide/setting-up-your-account-model). These samples show the implementation of the recommendations using Infrastructure as Code, namely [Terraform](https://www.terraform.io/) or [OpenTofu](https://opentofu.org/). They help you getting started with a sustainable setup of your SAP BTP accounts following our best practices. From 6120ae3ed8528e2bb894209b7b4ddb718496f866 Mon Sep 17 00:00:00 2001 From: Nina Hingerl <76950046+NHingerl@users.noreply.github.com> Date: Mon, 5 May 2025 14:58:10 +0200 Subject: [PATCH 3/3] add full stop --- sample-setups/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sample-setups/README.md b/sample-setups/README.md index 54ff30d..1142e68 100644 --- a/sample-setups/README.md +++ b/sample-setups/README.md @@ -31,7 +31,7 @@ The folder `basic-setup/subaccount-setup` contains the setup of subaccounts. For ## Modules -We have created a set of modules to encapsulate the reusable parts of the setup. You find the modules in the folder modules. Learn about the modules and their usage in their respective `README` files +We have created a set of modules to encapsulate the reusable parts of the setup. You find the modules in the folder modules. Learn about the modules and their usage in their respective `README` files. ### Naming Conventions and Labeling