fix typos and update images

Author: CHERIANS

released/SAP-Inside-Tracks/SITBLR_DEC_2024/README.md

@@ -2,20 +2,7 @@
 
 ## Goal of this HandsOn 🎯
 
-In this HandsOn you will learn how to use the [Terraform Provider for SAP BTP](https://registry.terraform.io/providers/SAP/cp/latest/docs) to provision and manage resources in SAP BTP.
-
-## Scenario 📚
-
-In this HandsOn we want to make you familiar with the Terraform Provider for SAP BTP. We will use the provider to provision and manage resources in SAP BTP. To achieve this we will walk through the following steps:
-
-1. [Exercise 1 - Configure the Terraform Provider for SAP BTP](exercises/EXERCISE1/README.md)
-1. [Exercise 2 - Setup of a subaccount](exercises/EXERCISE2/README.md)
-1. [Exercise 3 - Assign entitlement,Subscription and its role assignments to a subaccount](exercises/EXERCISE3/README.md)
-1. [Exercise 4 - Setup a Cloud Foundry environment and a space (optional)](exercises/EXERCISE4/README.md)
-1. [Exercise 5 - Exercise 5 - Assignment of subaccount emergency administrators](exercises/EXERCISE5/README.md)
-1. [Exercise 6 - Cleanup](exercises/EXERCISE6/README.md)
-
-The level of the exercises is beginner. You don't need any prior knowledge about Terraform or the Terraform Provider for SAP BTP. We will guide you through the exercises step by step.
+In this HandsOn you will learn how to use the [Terraform Provider for SAP BTP](https://registry.terraform.io/providers/SAP/cp/latest/docs) to provision and manage resources in SAP BTP. The level of the exercises is beginner. You don't need any prior knowledge about Terraform or the Terraform Provider for SAP BTP. We will guide you through the exercises step by step.
 
 ## Prerequisites 📝
 
@@ -25,16 +12,11 @@ Make sure that the following prerequisites are met:
 - Make sure that your SAP Universal ID is configured correctly. You can find the instructions in [SAP Note 3085908](https://me.sap.com/notes/3085908).
 - The Terraform provider does not support SSO or 2FA. Make sure that these options are not enforced for your account.
 
+
 ## Tools 🛠️
 
 To execute the exercises you have the following options concerning the required tools installed:
 
-- local installation
-- usage of the provided dev container
-- usage of GitHub Codespaces
-
-You find details about the installation of the tools in the following sections
-
 In general you must clone this GitHub repository. You must have the Git client installed on your machine. You can find the installation instructions [here](https://git-scm.com/downloads).
 
 You can then clone the repository via the following command:
@@ -43,67 +25,14 @@ You can then clone the repository via the following command:
 git clone https://github.com/SAP-samples/btp-terraform-samples.git
 ```
 
-you find the exercises in the folder `released/dsag/betriebstag2024/exercises`.
+you find the exercises in the folder `released/SAP-Inside-Tracks/SITBLR_DEC_2024/exercises`.
 
-### Local Installation
 
 You can install the required tools locally on your machine. The following tools are required:
 
 - [Terraform CLI](https://developer.hashicorp.com/terraform/install?product_intent=terraform)
 - An editor of your choice. We recommend [Visual Studio Code](https://code.visualstudio.com/Download) with the [Terraform extension](https://marketplace.visualstudio.com/items?itemName=HashiCorp.terraform).
 
-### Dev Container
-
-As an alternative to the local installation you can use the provided dev container that contains all required tools. This requires that you have [Docker](https://www.docker.com/products/docker-desktop) installed on your machine. In addition you need the dev container extension for Visual Studio Code. You can find detailed instructions about the setup [here](https://code.visualstudio.com/docs/devcontainers/containers#_getting-started).
-
-To start a dev container Docker must be running on your machine.
-
-To use the dev container you must open the folder that contains the cloned repository in Visual Studio Code. You will be asked if you want to reopen the folder in the dev container. Confirm this.
-
-If this is not the case execute the following steps:
-
-1. Open the command palette in Visual Studio Code:
-
-    - Windows / Linux: `Ctrl + Shift + P`
-    - Mac: `Cmd + Shift + P`
-
-2. Enter `Dev Containers: Reopen in Container` and confirm with `Enter`.
-
-3. You will then be asked to select a dev container. Select the `Terraform provider for SAP BTP - Default` container:
-
-    ![Select dev container](assets/devcontainer-selection.png)
-
-The dev container will automatically start and you are ready to go
-
-### GitHub Codespaces
-
-To use [Codespaces](https://docs.github.com/codespaces/overview) you must have a GitHub account. If you don't have one so far, please [sign-up on GitHub](https://github.com/signup) before going through the exercises.
-
-You can then access the Codespace following these steps:
-
-1. Open the [GitHub repository of the Terraform samples](https://github.com/SAP-samples/btp-terraform-samples).
-
-    ![Screenshot of GitHub repository Terraform samples](assets/repo-terraform-samples.png)
-
-2. Click on this button and create the code space:
-
-   [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://github.com/codespaces/new?hide_repo_select=true&ref=main&repo=656281656&skip_quickstart=true&machine=basicLinux32gb&geo=EuropeWest&devcontainer_path=.devcontainer%2Fdevcontainer.json)
-
-    This will take a few minutes. Be patient 🙂
-
-    ![Screenshot of navigation to Codespace creation in the repository Terraform samples](assets/codespace-creation.png)
-
-3. While the Codespace is created for you, you will see this screen
-
-    ![Screenshot of setup screen for Codespace](assets/codespace-setup-process.png)
-
-4. Once all is done, you are in your Codespace.
-
-    ![Screenshot of GitHub Codespace view on the repository Terraform samples](assets/codespace-screen.png)
-
-> [!IMPORTANT]
-> GitHub codespaces are free for a certain amount of time per month. For the hands-on session the free time is more than enough. **Don't forget to delete your codespace again after the hands-on session!**
-
 
 ## Exporting environment variables
 
@@ -128,17 +57,24 @@ Validate that the values are set via:
 - Windows: `$env:BTP_USERNAME` and `$env:BTP_PASSWORD`
 - Linux/MacOS/GitHub Codeapses: `echo $BTP_USERNAME` and `echo $BTP_PASSWORD`
 
-## Folder layout
 
-You find all exercises of this tutorial in the folder `released/dsag/betriebstag2024/exercises`. Each exercise is contained in a dedicated folder containing:
+## Summary
 
-- A `README.md` file with the instructions for the exercise
-- A folder `SOLUTION_EX<number>` which contains the solution for the exercise if needed including the file `terraform.tfvars-sample` contains the definition of the local variables. In case you get stuck you can check the content of this folder.  
+You've now prepared your development environment and have all information to finally start using Terraform provider for SAP BTP.  
+
+
+
+## Exercises 📚
+
+In this HandsOn we want to make you familiar with the Terraform Provider for SAP BTP. We will use the provider to provision and manage resources in SAP BTP. To achieve this we will walk through the following steps:
+
+1. [Exercise 1 - Configure the Terraform Provider for SAP BTP](exercises/EXERCISE1/README.md)
+1. [Exercise 2 - Setup of a subaccount](exercises/EXERCISE2/README.md)
+1. [Exercise 3 - Assign entitlement,Subscription and its role assignments to a subaccount](exercises/EXERCISE3/README.md)
+1. [Exercise 4 - Setup a Cloud Foundry environment and a space (optional)](exercises/EXERCISE4/README.md)
+1. [Exercise 5 - Exercise 5 - Assignment of subaccount emergency administrators](exercises/EXERCISE5/README.md)
+1. [Exercise 6 - Cleanup](exercises/EXERCISE6/README.md)
 
-In addition the folder `solution` contains the final configuration setup if you have gone through all exercises.
 
-## Summary
 
-You've now prepared your development environment and have all information to finally start using Terraform provider for SAP BTP.  
 
-Continue to - [Exercise 1 - Configure the Terraform Provider for SAP BTP](exercises/EXERCISE1/README.md).

released/SAP-Inside-Tracks/SITBLR_DEC_2024/exercises/EXERCISE1/README.md

@@ -58,6 +58,9 @@ the file `terraform.tfvars` and add the following content:
 globalaccount = "<YOUR GLOBAL ACCOUNT SUBDOMAIN>"
 ```
 
+The SAP BTP Global Account Subdomain can be found in the SAP BTP Cockpit as shown below
+<img width="600px" src="assets/trial-account.png" alt="SAP BTP Global Account Subdomain">
+
  > [!NOTE]
  > We are using here a naming convention of Terraform to define the variable values. The file `terraform.tfvars` is used to define the variable values. The file is not checked into the source code repository. This is important to keep sensitive information out of the source code repository. When you run Terraform, it will automatically load the variable values from this file.
 

released/SAP-Inside-Tracks/SITBLR_DEC_2024/exercises/EXERCISE1/assets/trial-account.png

@@ -23,6 +23,12 @@ variable "bas_developers" {
   type        = list(string)
   description = "List of users to assign the Developer role."
 }
+variable "bas_service_name" {
+  type        =  string
+  description = "Service name for Business Application Studio."
+  default     = "sapappstudio"
+
+}
 variable "bas_plan" {
   type        = string
   description = "Plan name for Business Application Studio."
@@ -43,8 +49,8 @@ We want to add the following entitlements to the subaccount:
 Open the `terraform.tfvars` file and add the following code:
 
 ```terraform
+bas_service_name = "sapappstudiotrial"
 bas_plan = "trial"
-
 bas_admins = ["[email protected]", "[email protected]"]
 bas_developers = ["[email protected]", "[email protected]"]
 ```
@@ -56,14 +62,14 @@ As we have the variable and the values for the `BAS` in place, we can now add th
 ```terraform
 resource "btp_subaccount_entitlement" "bas" {
   subaccount_id = btp_subaccount.project.id
-  service_name  = "sapappstudio"
+  service_name  = var.bas_service_name
   plan_name     = var.bas_plan
   amount        = 1
 }
 
 resource "btp_subaccount_subscription" "bas" {
   subaccount_id = btp_subaccount.project.id
-  app_name      = "sapappstudio"
+  app_name      = var.bas_service_name
   plan_name     = var.bas_plan
   depends_on    = [btp_subaccount_entitlement.bas]
 }
@@ -102,7 +108,7 @@ Now we can apply the changes to our subaccount. Run the following commands:
 
     You should see the following output:
 
-    <img width="600px" src="assets/ex4_1.png" alt="terraform plan output for entitlements">
+    <img width="600px" src="assets/ex3_1.png" alt="terraform plan output for entitlements">
 
 2. Apply the Terraform configuration to add the entitlements:
 
@@ -112,7 +118,7 @@ Now we can apply the changes to our subaccount. Run the following commands:
 
     You will be prompted to confirm the creation of the entitlements. Type `yes` and press `Enter` to continue. You should see the following output:
 
-    <img width="600px" src="assets/ex4_2.png" alt="terraform apply output for entitlements">
+    <img width="600px" src="assets/ex3_2.png" alt="terraform apply output for entitlements">
 
 You can also check that everything is in place via the SAP BTP cockpit. You should see the assigned entitlements in the subaccount.