chore: update for SIT

Author: prajin-op

released/SAP-Inside-Tracks/SITBLR_DEC_2024/exercises/EXERCISE3/README.md

@@ -1,25 +1,32 @@
-# Exercise 4 - Assign entitlements to a subaccount
+# Exercise 3 - Assign entitlement,Subscription and its role assignments to a subaccount
 
 ## Goal of this Exercise 🎯
 
-In this exercise, you will learn how to assign entitlements to a subaccount using Terraform. In addition, you will learn how to work with complex variables.
+In this exercise, you will learn how add an entitlement to a subaccount using Terraform.
 
-## Entitle the subaccount
+## Entitle the subaccount with Business Application Stuido (BAS)
 
-## Step 1: Enhance the variables
+## Step 1: Configure BAS
+
+Our goal is to configure Business Application Studio (BAS) for the subaccount by defining the necessary resources for entitlement, subscription, and role assignments.
+
+We will define the variables in the `variable.tf` file. Open the `variable.tf` file and add the following code.
 
-Our goal is to have one variable that contains the list of entitlements that we want to assign to the subaccount. An entitlement is an object that consists of several attributes, such as the service name, the plan name, and if necessary the amount.
-We will define the variable `entitlements` in the `variables.tf` file. Open the `variables.tf` file and add the following code:
 
 ```terraform
-variable "entitlements" {
-  type = list(object({
-    name   = string
-    plan   = string
-    amount = number
-  }))
-  description = "List of entitlements for the subaccount."
-  default     = []
+variable "bas_admins" {
+  type        = list(string)
+  description = "List of users to assign the Administrator role."
+
+}
+variable "bas_developers" {
+  type        = list(string)
+  description = "List of users to assign the Developer role."
+}
+variable "bas_plan" {
+  type        = string
+  description = "Plan name for Business Application Studio."
+  default     = "standard"
 }
 ```
 
@@ -32,45 +39,53 @@ Now we need to specify the entitlements we want to create to the `terraform.tfva
 We want to add the following entitlements to the subaccount:
 
 - `sapappstudiotrial` application with the `trial` plan
-- `cf_application_runtime` runtime with memory`1 GB`
 
 Open the `terraform.tfvars` file and add the following code:
 
 ```terraform
-entitlements = [
-  {
-    name   = "sapappstudiotrial"
-    plan   = "trial"
-    amount = null
-  },
-  {
-    name   = "application_runtime"
-    plan   = "memory"
-    amount = "null"
-  }
-]
-```
+bas_plan = "trial"
 
-As you can see, we define a list of objects, where each object has the attributes `name`, `plan`, and `amount`. We set the `amount` attribute to `null` for all entitlements. Save the changes.
+bas_admins = ["[email protected]", "[email protected]"]
+bas_developers = ["[email protected]", "[email protected]"]
+```
 
 ## Step 3: Add the entitlements configuration
 
-As we have the variable and the values for the entitlements in place, we can now add the configuration to assign the entitlements to the subaccount. We use the resource [btp_subaccount_entitlement](https://registry.terraform.io/providers/SAP/btp/latest/docs/resources/subaccount_entitlement) to achieve this. Open the `main.tf` file and add the following code:
+As we have the variable and the values for the `BAS` in place, we can now add the configuration to assign the entitlement to the subaccount. We use the resource [btp_subaccount_entitlement](https://registry.terraform.io/providers/SAP/btp/latest/docs/resources/subaccount_entitlement) to achieve this. Open the `main.tf` file and add the following code:
 
 ```terraform
-resource "btp_subaccount_entitlement" "entitlements" {
-  for_each = {
-    for index, entitlement in var.entitlements :
-    index => entitlement
-  }
+resource "btp_subaccount_entitlement" "bas" {
+  subaccount_id = btp_subaccount.project.id
+  service_name  = "sapappstudio"
+  plan_name     = var.bas_plan
+  amount        = 1
+}
 
+resource "btp_subaccount_subscription" "bas" {
   subaccount_id = btp_subaccount.project.id
-  service_name  = each.value.name
-  plan_name     = each.value.plan
+  app_name      = "sapappstudio"
+  plan_name     = var.bas_plan
+  depends_on    = [btp_subaccount_entitlement.bas]
+}
+
+resource "btp_subaccount_role_collection_assignment" "bas_admin" {
+  for_each             = toset(var.bas_admins)
+  subaccount_id        = btp_subaccount.project.id
+  role_collection_name = "Business_Application_Studio_Administrator"
+  user_name            = each.value
+  depends_on           = [btp_subaccount_subscription.bas]
+}
+
+resource "btp_subaccount_role_collection_assignment" "bas_developer" {
+  for_each             = toset(var.bas_developers)
+  subaccount_id        = btp_subaccount.project.id
+  role_collection_name = "Business_Application_Studio_Developer"
+  user_name            = each.value
+  depends_on           = [btp_subaccount_subscription.bas]
 }
 ```
 
-We iterate through the list of entitlements and create a resource for each entitlement. We use the[`for_each` meta-argument](https://developer.hashicorp.com/terraform/language/meta-arguments/for_each) to achieve this. The `for_each` argument works on a map, so we must transform our list of entitlements into a map leveraging Terraform's automatic type conversion via the [`for` expression](https://developer.hashicorp.com/terraform/language/expressions/for#result-types) for setting up the map. As for the subaccount administrators we access the value of the current iteration via `each.value` and reference the corresponding attributes of the object. The `subaccount_id` is set to the id of the subaccount we created in the previous exercise. Save the changes.
+We iterate through the list of entitlement and create a resource for `BAS`. We use the[`for_each` meta-argument](https://developer.hashicorp.com/terraform/language/meta-arguments/for_each) to achieve this. The `for_each` argument works on a map, so we must transform our list of users into a map leveraging Terraform's automatic type conversion via the [`for` expression](https://developer.hashicorp.com/terraform/language/expressions/for#result-types) for setting up the map. As for the subaccount administrators we access the value of the current iteration via `each.value` and reference the corresponding attributes of the object. The `subaccount_id` is set to the id of the subaccount we created in the previous exercise. Save the changes.
 
 ## Step 4: Apply the changes
 

released/SAP-Inside-Tracks/SITBLR_DEC_2024/exercises/EXERCISE3/SOLUTION_EX3/terraform.tfvars-sample

@@ -1,29 +1,6 @@
 globalaccount = "<YOUR GLOBAL ACCOUT SUBDOMAIN>"
 
-entitlements = [
-  {
-    name   = "alert-notification"
-    plan   = "standard"
-    amount = null
-  },
-  {
-    name   = "SAPLaunchpad"
-    plan   = "standard"
-    amount = null
-  },
-  {
-    name   = "hana-cloud-trial"
-    plan   = "hana"
-    amount = null
-  },
-  {
-    name   = "hana"
-    plan   = "hdi-shared"
-    amount = null
-  },
-  {
-    name   = "sapappstudiotrial"
-    plan   = "trial"
-    amount = null
-  }
-]
+bas_plan = "trial"
+
+bas_admins = ["[email protected]", "[email protected]"]
+bas_developers = ["[email protected]", "[email protected]"]

released/SAP-Inside-Tracks/SITBLR_DEC_2024/exercises/EXERCISE3/SOLUTION_EX3/variables.tf

@@ -77,14 +77,19 @@ variable "emergency_admins" {
 
 
 ###
-# Entitlements for Subaccount
+# Entitlement for BAS
 ###
-variable "entitlements" {
-  type = list(object({
-    name   = string
-    plan   = string
-    amount = number
-  }))
-  description = "List of entitlements for the subaccount."
-  default     = []
+variable "bas_admins" {
+  type        = list(string)
+  description = "List of users to assign the Administrator role."
+
 }
+variable "bas_developers" {
+  type        = list(string)
+  description = "List of users to assign the Developer role."
+}
+variable "bas_plan" {
+  type        = string
+  description = "Plan name for Business Application Studio."
+  default     = "standard"
+}