Skip to content

Commit c687ab6

Browse files
authored
increase timeouts, remove email validation (#263)
1 parent ead3624 commit c687ab6

File tree

3 files changed

+3
-81
lines changed

3 files changed

+3
-81
lines changed

released/discovery_center/mission_3061/step1/variables.tf

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -48,73 +48,34 @@ variable "cf_space_name" {
4848
variable "cf_org_managers" {
4949
type = list(string)
5050
description = "List of Cloud Foundry org managers."
51-
default = []
52-
53-
# add validation to check if admins contains a list of valid email addresses
54-
validation {
55-
condition = length([for email in var.cf_org_managers : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_org_managers)
56-
error_message = "Please enter a valid email address for the subaccount admins."
57-
}
5851
}
5952

6053
variable "cf_org_billing_managers" {
6154
type = list(string)
6255
description = "List of Cloud Foundry org billing managers."
6356
default = []
64-
65-
# add validation to check if admins contains a list of valid email addresses
66-
validation {
67-
condition = length([for email in var.cf_org_billing_managers : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_org_billing_managers)
68-
error_message = "Please enter a valid email address for the subaccount admins."
69-
}
7057
}
7158

7259
variable "cf_org_auditors" {
7360
type = list(string)
7461
description = "List of Cloud Foundry org auditors."
7562
default = []
76-
77-
# add validation to check if admins contains a list of valid email addresses
78-
validation {
79-
condition = length([for email in var.cf_org_auditors : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_org_auditors)
80-
error_message = "Please enter a valid email address for the subaccount admins."
81-
}
8263
}
8364

8465
variable "cf_space_managers" {
8566
type = list(string)
8667
description = "List of managers for the Cloud Foundry space."
87-
default = []
88-
89-
# add validation to check if admins contains a list of valid email addresses
90-
validation {
91-
condition = length([for email in var.cf_space_managers : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_space_managers)
92-
error_message = "Please enter a valid email address for the subaccount admins."
93-
}
9468
}
9569

9670
variable "cf_space_developers" {
9771
type = list(string)
9872
description = "List of developers for the Cloud Foundry space."
99-
default = []
100-
101-
# add validation to check if admins contains a list of valid email addresses
102-
validation {
103-
condition = length([for email in var.cf_space_developers : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_space_developers)
104-
error_message = "Please enter a valid email address for the subaccount admins."
105-
}
10673
}
10774

10875
variable "cf_space_auditors" {
10976
type = list(string)
11077
description = "The list of Cloud Foundry space auditors."
11178
default = []
112-
113-
# add validation to check if admins contains a list of valid email addresses
114-
validation {
115-
condition = length([for email in var.cf_space_auditors : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_space_auditors)
116-
error_message = "Please enter a valid email address for the subaccount admins."
117-
}
11879
}
11980

12081
variable "abap_sid" {

released/discovery_center/mission_3061/step2/main.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,9 @@ resource "cloudfoundry_service_instance" "abap_si" {
9292
login_attribute = "email"
9393
})
9494
timeouts = {
95-
create = "2h"
96-
delete = "2h"
97-
update = "2h"
95+
create = "4h"
96+
delete = "4h"
97+
update = "4h"
9898
}
9999
}
100100

released/discovery_center/mission_3061/step2/variables.tf

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -18,73 +18,34 @@ variable "origin" {
1818
variable "cf_org_managers" {
1919
type = list(string)
2020
description = "List of Cloud Foundry org managers."
21-
default = []
22-
23-
# add validation to check if admins contains a list of valid email addresses
24-
validation {
25-
condition = length([for email in var.cf_org_managers : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_org_managers)
26-
error_message = "Please enter a valid email address for the Cloud Foundry org managers."
27-
}
2821
}
2922

3023
variable "cf_org_billing_managers" {
3124
type = list(string)
3225
description = "List of Cloud Foundry org billing managers."
3326
default = []
34-
35-
# add validation to check if admins contains a list of valid email addresses
36-
validation {
37-
condition = length([for email in var.cf_org_billing_managers : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_org_billing_managers)
38-
error_message = "Please enter a valid email address for the subaccount admins."
39-
}
4027
}
4128

4229
variable "cf_org_auditors" {
4330
type = list(string)
4431
description = "List of Cloud Foundry org auditors."
4532
default = []
46-
47-
# add validation to check if admins contains a list of valid email addresses
48-
validation {
49-
condition = length([for email in var.cf_org_auditors : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_org_auditors)
50-
error_message = "Please enter a valid email address for the subaccount admins."
51-
}
5233
}
5334

5435
variable "cf_space_managers" {
5536
type = list(string)
5637
description = "List of managers for the Cloud Foundry space."
57-
default = []
58-
59-
# add validation to check if admins contains a list of valid email addresses
60-
validation {
61-
condition = length([for email in var.cf_space_managers : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_space_managers)
62-
error_message = "Please enter a valid email address for the subaccount admins."
63-
}
6438
}
6539

6640
variable "cf_space_developers" {
6741
type = list(string)
6842
description = "List of developers for the Cloud Foundry space."
69-
default = []
70-
71-
# add validation to check if admins contains a list of valid email addresses
72-
validation {
73-
condition = length([for email in var.cf_space_developers : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_space_developers)
74-
error_message = "Please enter a valid email address for the subaccount admins."
75-
}
7643
}
7744

7845
variable "cf_space_auditors" {
7946
type = list(string)
8047
description = "The list of Cloud Foundry space auditors."
8148
default = []
82-
83-
# add validation to check if admins contains a list of valid email addresses
84-
validation {
85-
condition = length([for email in var.cf_space_auditors : can(regex("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,}$", email))]) == length(var.cf_space_auditors)
86-
error_message = "Please enter a valid email address for the subaccount admins."
87-
}
8849
}
8950

9051
variable "cf_space_name" {

0 commit comments

Comments
 (0)