fix cf requirement for sbpa instance

Author: mahesh0431

released/discovery_center/mission_4033/step1/README.md

@@ -45,13 +45,13 @@ To deploy the resources you must:
 5. Apply your configuration to provision the resources:
 
    ```bash
-   terraform apply -var-file="samples.tfvars"
+   terraform apply -var-file="sample.tfvars"
    ```
 
 ## In the end
 
 You probably want to remove the assets after trying them out to avoid unnecessary costs. To do so execute the following command:
 
 ```bash
-terraform destroy -var-file="samples.tfvars"
+terraform destroy -var-file="sample.tfvars"
 ```

released/discovery_center/mission_4033/step1/main.tf

@@ -6,6 +6,7 @@ resource "random_uuid" "uuid" {}
 locals {
   random_uuid       = random_uuid.uuid.result
   subaccount_domain = lower(replace("mission-4033-${local.random_uuid}", "_", "-"))
+  subaccount_cf_org = substr(replace("${local.subaccount_domain}", "-", ""), 0, 32)
 }
 
 locals {
@@ -128,6 +129,33 @@ resource "btp_subaccount_environment_instance" "kyma" {
   depends_on = [btp_subaccount_entitlement.kymaruntime]
 }
 
+# ------------------------------------------------------------------------------------------------------
+# Extract list of CF landscape labels from environments
+# ------------------------------------------------------------------------------------------------------
+data "btp_subaccount_environments" "all" {
+  subaccount_id = data.btp_subaccount.dc_mission.id
+}
+
+# Take the landscape label from the first CF environment if no environment label is provided
+resource "terraform_data" "cf_landscape_label" {
+  input = length(var.cf_landscape_label) > 0 ? var.cf_landscape_label : [for env in data.btp_subaccount_environments.all.values : env if env.service_name == "cloudfoundry" && env.environment_type == "cloudfoundry"][0].landscape_label
+}
+
+# ------------------------------------------------------------------------------------------------------
+# Creation of Cloud Foundry environment
+# ------------------------------------------------------------------------------------------------------
+resource "btp_subaccount_environment_instance" "cloudfoundry" {
+  subaccount_id    = data.btp_subaccount.dc_mission.id
+  name             = var.cf_org_name
+  environment_type = "cloudfoundry"
+  service_name     = "cloudfoundry"
+  plan_name        = "standard"
+  landscape_label  = terraform_data.cf_landscape_label.output
+  parameters = jsonencode({
+    instance_name = local.subaccount_cf_org
+  })
+}
+
 # ------------------------------------------------------------------------------------------------------
 # Create app subscription to SAP Integration Suite
 # ------------------------------------------------------------------------------------------------------
@@ -230,7 +258,7 @@ resource "btp_subaccount_entitlement" "process_automation_service" {
   depends_on    = [btp_subaccount_subscription.build_process_automation]
 }
 
-# Get plan for SAP AI Core service
+# Get plan for SAP Build Process Automation service
 data "btp_subaccount_service_plan" "process_automation_service" {
   subaccount_id = data.btp_subaccount.dc_mission.id
   offering_name = local.service_name__sap_process_automation_service
@@ -243,7 +271,7 @@ resource "btp_subaccount_service_instance" "process_automation_service_instance"
   subaccount_id  = data.btp_subaccount.dc_mission.id
   serviceplan_id = data.btp_subaccount_service_plan.process_automation_service.id
   name           = "build-process-automation-service-instance"
-  depends_on     = [btp_subaccount_entitlement.process_automation_service]
+  depends_on     = [btp_subaccount_entitlement.process_automation_service, btp_subaccount_environment_instance.cloudfoundry]
 }
 
 # Create service binding to SAP Build Process Automation Service (exposed for a specific user group)

released/discovery_center/mission_4033/step1/variables.tf

@@ -34,6 +34,20 @@ variable "cli_server_url" {
   default     = "https://cli.btp.cloud.sap"
 }
 
+# cf org name
+variable "cf_org_name" {
+  type        = string
+  description = "Cloud Foundry Org Name"
+  default     = "cloud-foundry"
+}
+
+# cf landscape label
+variable "cf_landscape_label" {
+  type        = string
+  description = "The Cloud Foundry landscape (format example eu10-004)."
+  default     = ""
+}
+
 variable "subaccount_admins" {
   type        = list(string)
   description = "Defines the colleagues who are added to each subaccount as Subaccount administrators."
@@ -190,4 +204,15 @@ variable "create_tfvars_file_for_step2" {
   type        = bool
   description = "Switch to enable the creation of the tfvars file for step 2."
   default     = true
+}
+
+variable "cf_space_name" {
+  type        = string
+  description = "Name of the Cloud Foundry space."
+  default     = "dev"
+
+  validation {
+    condition     = can(regex("^.{1,255}$", var.cf_space_name))
+    error_message = "The Cloud Foundry space name must not be emtpy and not exceed 255 characters."
+  }
 }