review feedback

Author: mofterdinger

db/books.cds

@@ -8,7 +8,6 @@ using {
 } from '@sap/cds/common';
 using my.bookshop.Reviews from './reviews';
 using my.bookshop.TechnicalBooleanFlag from './common';
-using {sap.attachments.Attachments} from `com.sap.cds/cds-feature-attachments`;
 
 @fiori.draft.enabled
 entity Books : cuid, managed {
@@ -23,7 +22,6 @@ entity Books : cuid, managed {
     reviews      : Association to many Reviews
                        on reviews.book = $self;
     isReviewable : TechnicalBooleanFlag not null default true;
-    covers       : Composition of many Attachments;
 }
 
 entity Authors : cuid, managed {

db/pom.xml

@@ -32,7 +32,6 @@
 	</properties>
 
 	<modules>
-		<module>db</module>
 		<module>srv</module>
 		<module>integration-tests</module>
 	</modules>
@@ -76,14 +75,6 @@
 		</dependencies>
 	</dependencyManagement>
 
-	<dependencies>
-		<dependency>
-			<groupId>com.sap.cds</groupId>
-			<artifactId>cds-feature-attachments</artifactId>
-			<version>${cds-feature-attachments.version}</version>
-		</dependency>
-	</dependencies>
-
 	<build>
 		<plugins>
 			<!-- JAVA VERSION -->

pom.xml

@@ -1,6 +1,7 @@
 using {sap.common.Languages as CommonLanguages} from '@sap/cds/common';
 using {my.bookshop as my} from '../db/index';
 using {sap.changelog as changelog} from 'com.sap.cds/change-tracking';
+using {sap.attachments.Attachments} from `com.sap.cds/cds-feature-attachments`;
 
 extend my.Orders with changelog.changeTracked;
 
@@ -62,4 +63,9 @@ annotate AdminService.Orders with @changelog: [OrderNo];
 annotate AdminService.OrderItems with @changelog: [
     parent.OrderNo,
     book.title,
-  ];
+  ];
+
+// Extends the Books entity with the Attachments composition
+extend my.Books with {
+    covers : Composition of many Attachments;
+};

srv/admin-service.cds

@@ -74,6 +74,13 @@
 			<artifactId>connectivity-apache-httpclient4</artifactId>
 		</dependency>
 
+		<!-- RE-USE PLUGIN DEPENDENCIES -->
+		<dependency>
+			<groupId>com.sap.cds</groupId>
+			<artifactId>cds-feature-attachments</artifactId>
+			<version>${cds-feature-attachments.version}</version>
+		</dependency>
+
 		<!-- OTHER DEPENDENCIES -->
 		<dependency>
 			<groupId>com.h2database</groupId>