Merge pull request #12 from SAP-samples/refactor/P13nTable-SelectionController-remove-getKeyForItem

refactor(P13nTable): remove 'getKeyForItem' from SelectionController …

Author: koeppel

exercises/ex04/README.md

@@ -26,10 +26,7 @@ private initP13n(): void {
 		controller: {
 			Columns: new SelectionController({
 				control: this,
-				targetAggregation: "columns",
-				getKeyForItem: (column: Column) => {
-					return column.data("p13nKey")
-				}
+				targetAggregation: "columns"
 			})
 		}
 	})

exercises/ex04/sample.p13n/webapp/control/P13nTable.ts

@@ -56,10 +56,7 @@ export default class P13nTable extends Table {
 				// @ts-ignore TODO: FIX constructor
 				Columns: new SelectionController({
 					control: this,
-					targetAggregation: "columns",
-					getKeyForItem: (column: Column) => {
-						return column.data("p13nKey")
-					}
+					targetAggregation: "columns"
 				})
 			}
 		})

exercises/ex05/README.md

@@ -37,10 +37,7 @@ private initP13n(): void {
 		controller: {
 			Columns: new SelectionController({
 				control: this,
-				targetAggregation: "columns",
-				getKeyForItem: (column: Column) => {
-					return column.data("p13nKey")
-				}
+				targetAggregation: "columns"
 			}),
 			Sorter: new SortController({
 				control: this

exercises/ex05/sample.p13n/webapp/control/P13nTable.ts

@@ -56,10 +56,7 @@ export default class P13nTable extends Table {
 			controller: {
 				Columns: new SelectionController({
 					control: this,
-					targetAggregation: "columns",
-					getKeyForItem: (column: Column) => {
-						return column.data("p13nKey")
-					}
+					targetAggregation: "columns"
 				}),
 				Sorter: new SortController({
 					control: this

exercises/ex06/README.md

@@ -19,10 +19,7 @@ this.engine.register(this, {
 	controller: {
 		Columns: new SelectionController({
 			control: this,
-			targetAggregation: "columns",
-			getKeyForItem: (column: Column) => {
-				return column.data("p13nKey")
-			}
+			targetAggregation: "columns"
 		}),
 		Sorter: new SortController({
 			control: this

exercises/ex06/sample.p13n/webapp/control/P13nTable.ts

@@ -63,10 +63,7 @@ export default class P13nTable extends Table {
 			controller: {
 				Columns: new SelectionController({
 					control: this,
-					targetAggregation: "columns",
-					getKeyForItem: (column: Column) => {
-						return column.data("p13nKey")
-					}
+					targetAggregation: "columns"
 				}),
 				Sorter: new SortController({
 					control: this

exercises/ex07/sample.p13n/webapp/control/P13nTable.ts

@@ -62,10 +62,7 @@ export default class P13nTable extends Table {
 			controller: {
 				Columns: new SelectionController({
 					control: this,
-					targetAggregation: "columns",
-					getKeyForItem: (column: Column) => {
-						return column.data("p13nKey")
-					}
+					targetAggregation: "columns"
 				}),
 				Sorter: new SortController({
 					control: this

exercises/ex08/sample.p13n/webapp/control/P13nTable.ts

@@ -62,10 +62,7 @@ export default class P13nTable extends Table {
 			controller: {
 				Columns: new SelectionController({
 					control: this,
-					targetAggregation: "columns",
-					getKeyForItem: (column: Column) => {
-						return column.data("p13nKey")
-					}
+					targetAggregation: "columns"
 				}),
 				Sorter: new SortController({
 					control: this

exercises/ex09/README.md

@@ -116,10 +116,7 @@ export default class MountainsController extends Controller {
 			controller: {
 				Items: new SelectionController({
 					control: gridList,
-					targetAggregation: "items",
-					getKeyForItem: (gridListItem: GridListItem) => {
-						return gridListItem.getSelected()
-					}
+					targetAggregation: "items"
 				})
 			}
 		})

exercises/ex09/sample.p13n/webapp/control/P13nTable.ts

@@ -63,10 +63,7 @@ export default class P13nTable extends Table {
 			controller: {
 				Columns: new SelectionController({
 					control: this,
-					targetAggregation: "columns",
-					getKeyForItem: (column: Column) => {
-						return column.data("p13nKey")
-					}
+					targetAggregation: "columns"
 				}),
 				Sorter: new SortController({
 					control: this