fix: [Core] Remove any logging of response request body (#504)

* Remove logging response/request

- error messages updated and cut error object logging

* minor

* update release notes

---------

Co-authored-by: Roshin Rajan Panackal <[email protected]>

Author: rpanackal

core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java

@@ -78,11 +78,10 @@ private T parseResponse(@Nonnull final ClassicHttpResponse response) throws E {
       throw exceptionConstructor.apply("Response was empty.", null);
     }
     val content = getContent(responseEntity);
-    log.debug("Parsing response from JSON response: {}", content);
     try {
       return objectMapper.readValue(content, responseType);
     } catch (final JsonProcessingException e) {
-      log.error("Failed to parse the following response: {}", content);
+      log.error("Failed to parse response to type {}", responseType);
       throw exceptionConstructor.apply("Failed to parse response", e);
     }
   }
@@ -92,7 +91,7 @@ private String getContent(@Nonnull final HttpEntity entity) {
     try {
       return EntityUtils.toString(entity, StandardCharsets.UTF_8);
     } catch (IOException | ParseException e) {
-      throw exceptionConstructor.apply("Failed to read response content.", e);
+      throw exceptionConstructor.apply("Failed to read response content", e);
     }
   }
 
@@ -122,7 +121,10 @@ public void buildExceptionAndThrow(@Nonnull final ClassicHttpResponse response)
       throw exception;
     }
 
-    log.error("The service responded with an HTTP error and the following content: {}", content);
+    log.error(
+        "The service responded with an HTTP {} ({})",
+        response.getCode(),
+        response.getReasonPhrase());
     val contentType = ContentType.parse(entity.getContentType());
     if (!ContentType.APPLICATION_JSON.isSameMimeType(contentType)) {
       throw exception;

core/src/main/java/com/sap/ai/sdk/core/common/ClientStreamingHandler.java

@@ -77,8 +77,8 @@ public Stream<D> handleStreamingResponse(@Nonnull final ClassicHttpResponse resp
               try {
                 return objectMapper.readValue(data, responseType);
               } catch (final IOException e) { // exception message e gets lost
-                log.error("Failed to parse the following response: {}", line);
-                throw exceptionConstructor.apply("Failed to parse delta message: " + line, e);
+                log.error("Failed to parse delta chunk to type {}", responseType);
+                throw exceptionConstructor.apply("Failed to parse delta chunk", e);
               }
             });
   }

core/src/main/java/com/sap/ai/sdk/core/common/IterableStreamConverter.java

@@ -70,7 +70,7 @@ public boolean hasNext() {
     } catch (final Exception e) {
       isDone = true;
       stopHandler.run();
-      log.debug("Error while reading next element.", e);
+      log.debug("Reading next element failed with error {})", e.getClass().getSimpleName());
       throw errorHandler.apply(e);
     }
     return !isDone;
@@ -114,7 +114,13 @@ static Stream<String> lines(
 
     final var reader = new BufferedReader(new InputStreamReader(inputStream, UTF_8), BUFFER_SIZE);
     final Runnable closeHandler =
-        () -> Try.run(reader::close).onFailure(e -> log.error("Could not close input stream", e));
+        () ->
+            Try.run(reader::close)
+                .onFailure(
+                    e ->
+                        log.debug(
+                            "Could not close input stream with error: {} (ignored)",
+                            e.getClass().getSimpleName()));
     final Function<Exception, RuntimeException> errHandler =
         e -> exceptionType.apply("Parsing response content was interrupted.", e);
 

docs/release_notes.md

@@ -50,3 +50,4 @@
 ### 🐛 Fixed Issues
 
 - [Orchestration] Resolved duplicate JSON property issue, enabling Anthropic Claude chat completions.
+- Remove logging of any request/response payloads to avoid potential exposure of sensitive data.

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationHttpExecutor.java

@@ -40,7 +40,7 @@ <T> T execute(
       @Nonnull final Class<T> responseType) {
     try {
       val json = JACKSON.writeValueAsString(payload);
-      log.debug("Serialized request into JSON payload: {}", json);
+      log.debug("Successfully serialized request into JSON payload");
       val request = new HttpPost(path);
       request.setEntity(new StringEntity(json, ContentType.APPLICATION_JSON));