Skip to content

Commit 03a2270

Browse files
Jonas-IsrJonas-Isr
authored
Merge branch 'main' into spec-update/core/main
2 parents d029a7d + f6bd536 commit 03a2270

File tree

79 files changed

+926
-723
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+926
-723
lines changed

‎.github/ISSUE_TEMPLATE/bug-report.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Bug Report
1+
name: Problem/Bug Report
22
description: Released feature does not work as expected in the SAP Cloud SDK for AI (Java).
33
labels:
44
- bug
@@ -11,8 +11,8 @@ body:
1111
**Missing information may result in delayed response**
1212
- type: textarea
1313
attributes:
14-
label: "Describe the Bug"
15-
description: "A clear and concise description of what the bug is."
14+
label: "Describe the Problem/Bug"
15+
description: "A clear and concise description of what the problem/bug is."
1616
validations:
1717
required: true
1818
- type: textarea

‎.github/ISSUE_TEMPLATE/question.yml‎

Lines changed: 0 additions & 15 deletions
This file was deleted.

‎.github/workflows/prepare-release.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,12 +201,12 @@ jobs:
201201
run: |
202202
PR_TITLE="Java: Add release notes for release ${{ needs.bump-version.outputs.release-version }}"
203203
204-
# if the minor version is a multiple of 15, then change the PR_BODY to "# ⚠️Update the `docs-java/release-notes/index.jsx` file⚠️"
204+
# if the minor version is a multiple of 15, then change the PR_BODY to "# ⚠️Update the `docs-java/release-notes.mdx` file⚠️"
205205
# else the PR_BODY will be "Add the SAP Cloud SDK ${{ needs.bump-version.outputs.release-version }} release notes"
206206
207207
minor_version=$(echo ${{ needs.bump-version.outputs.release-version }} | cut -d '.' -f 2)
208208
if [[ $((minor_version % 15)) -eq 0 ]]; then
209-
PR_BODY="# ⚠️Update the \`docs-java/release-notes/index.jsx\` file⚠️"
209+
PR_BODY="# ⚠️Update the \`docs-java/release-notes.mdx\` file⚠️"
210210
else
211211
PR_BODY="Add the SAP Cloud SDK ${{ needs.bump-version.outputs.release-version }} release notes"
212212
fi

‎.github/workflows/spec-update.yaml‎

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ env:
3434
jobs:
3535
generate:
3636
name: "Download, Generate, Compile and Push"
37-
runs-on: [ubuntu-latest]
37+
runs-on: [ ubuntu-latest ]
3838
permissions:
3939
pull-requests: write
4040
contents: write
@@ -119,7 +119,11 @@ jobs:
119119
id: generate
120120
if: steps.spec_diff.outputs.spec_diff == 'true'
121121
run: |
122-
mvn install -DskipTests -Dgenerate ${{ env.MVN_MULTI_THREADED_ARGS }}
122+
if mvn install -DskipTests -Dgenerate ${{ env.MVN_MULTI_THREADED_ARGS }} ; then
123+
echo "generation_result=success" >> "$GITHUB_OUTPUT"
124+
else
125+
echo "generation_result=failure" >> "$GITHUB_OUTPUT"
126+
fi
123127
124128
- name: "Compile and Test"
125129
id: compile
@@ -196,9 +200,15 @@ jobs:
196200
echo "| Spec File Changes | ${{ steps.spec_diff.outputs.spec_diff == 'true' && '🔄 Changes Detected' || '⏹️ No Changes' }}" >> $GITHUB_STEP_SUMMARY
197201
198202
if ${{ steps.spec_diff.outputs.spec_diff == 'true' }}; then
199-
echo "| Client Generation | ${{ steps.generate.outcome == 'success' && '✅' || '❌' }} ${{ steps.generate.outcome }}" >> $GITHUB_STEP_SUMMARY
203+
echo "| Client Generation | ${{ steps.generate.outputs.generation_result == 'success' && '✅' || '❌' }} ${{ steps.generate.outputs.generation_result }}" >> $GITHUB_STEP_SUMMARY
200204
echo "| Client Compilation | ${{ steps.compile.outputs.compilation_result == 'success' && '✅' || '❌' }} ${{ steps.compile.outputs.compilation_result }}" >> $GITHUB_STEP_SUMMARY
201205
echo "| Client Testing | ${{ steps.compile.outputs.test_result == 'success' && '✅' || steps.compile.outputs.test_result == 'skipped' && '⏩' || '❌' }} ${{ steps.compile.outputs.test_result }}" >> $GITHUB_STEP_SUMMARY
202206
echo "| Branch Creation | ${{ steps.push.outcome == 'success' && '✅ [Branch Link]($DIFF_URL)' || '❌ failure' }}" >> $GITHUB_STEP_SUMMARY
203207
echo "| Pull Request Creation | ${{ env.CREATE_PR == 'false' && '⏩ skipped' || '' }}${{ env.CREATE_PR == 'true' && steps.push.outcome == 'success' && '✅ [PR Link]($PR_URL)' || '' }}" >> $GITHUB_STEP_SUMMARY
204208
fi
209+
210+
- name: "Fail if generation failed"
211+
if: steps.generate.outputs.generation_result == 'failure'
212+
run: |
213+
echo "Client generation failed. Please check the Generate step logs for details."
214+
exit 1

‎README.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
![CodeQL](https://github.com/SAP/ai-sdk-java/actions/workflows/github-code-scanning/codeql/badge.svg)
33
[![REUSE status](https://api.reuse.software/badge/git.fsfe.org/reuse/api)](https://api.reuse.software/info/git.fsfe.org/reuse/api)
44
[![Fosstars security rating](https://github.com/SAP/ai-sdk-java/actions/workflows/fosstars-report.yml/badge.svg?branch=main)](https://github.com/SAP/ai-sdk-java/blob/fosstars-report/fosstars_report.md)
5+
[![Ask DeepWiki](https://deepwiki.com/badge.svg)](https://deepwiki.com/SAP/ai-sdk-java)
56

67
# <img src="https://sap.github.io/cloud-sdk/img/logo.svg" alt="SAP Cloud SDK" width="30"/> SAP Cloud SDK for AI (for Java)
78

‎core-services/document-grounding/src/main/java/com/sap/ai/sdk/grounding/model/BasePipelineMinimalResponse.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public void setId(@Nonnull final String id) {
7979
* @return The same instance of this {@link BasePipelineMinimalResponse} class
8080
*/
8181
@Nonnull
82-
public BasePipelineMinimalResponse status(@Nonnull final PipelineExecutionStatus status) {
82+
public BasePipelineMinimalResponse status(@Nullable final PipelineExecutionStatus status) {
8383
this.status = status;
8484
return this;
8585
}
@@ -89,7 +89,7 @@ public BasePipelineMinimalResponse status(@Nonnull final PipelineExecutionStatus
8989
*
9090
* @return status The status of this {@link BasePipelineMinimalResponse} instance.
9191
*/
92-
@Nonnull
92+
@Nullable
9393
public PipelineExecutionStatus getStatus() {
9494
return status;
9595
}
@@ -99,7 +99,7 @@ public PipelineExecutionStatus getStatus() {
9999
*
100100
* @param status The status of this {@link BasePipelineMinimalResponse}
101101
*/
102-
public void setStatus(@Nonnull final PipelineExecutionStatus status) {
102+
public void setStatus(@Nullable final PipelineExecutionStatus status) {
103103
this.status = status;
104104
}
105105

@@ -231,6 +231,6 @@ public interface Builder1 {
231231
* @param status The status of this {@link BasePipelineMinimalResponse}
232232
* @return The BasePipelineMinimalResponse instance.
233233
*/
234-
BasePipelineMinimalResponse status(@Nonnull final PipelineExecutionStatus status);
234+
BasePipelineMinimalResponse status(@Nullable final PipelineExecutionStatus status);
235235
}
236236
}

‎core-services/document-grounding/src/main/java/com/sap/ai/sdk/grounding/model/CreatePipeline.java‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,6 @@
2222
@JsonSubTypes.Type(value = SDMPipelineCreateRequest.class, name = "SDM"),
2323
@JsonSubTypes.Type(value = SFTPPipelineCreateRequest.class, name = "SFTP"),
2424
@JsonSubTypes.Type(value = WorkZonePipelineCreateRequest.class, name = "WorkZone"),
25-
@JsonSubTypes.Type(
26-
value = MSSharePointPipelineCreateRequest.class,
27-
name = "MSSharePointPipelineCreateRequest"),
28-
@JsonSubTypes.Type(value = S3PipelineCreateRequest.class, name = "S3PipelineCreateRequest"),
29-
@JsonSubTypes.Type(value = SDMPipelineCreateRequest.class, name = "SDMPipelineCreateRequest"),
30-
@JsonSubTypes.Type(value = SFTPPipelineCreateRequest.class, name = "SFTPPipelineCreateRequest"),
31-
@JsonSubTypes.Type(
32-
value = WorkZonePipelineCreateRequest.class,
33-
name = "WorkZonePipelineCreateRequest"),
3425
})
3526
public interface CreatePipeline {
3627
Object getType();

‎core-services/document-grounding/src/main/java/com/sap/ai/sdk/grounding/model/DocumentStatus.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,6 @@ public static DocumentStatus fromValue(@Nonnull final String value) {
6969
return b;
7070
}
7171
}
72-
return UNKNOWN_DEFAULT_OPEN_API;
72+
return null;
7373
}
7474
}

‎core-services/document-grounding/src/main/java/com/sap/ai/sdk/grounding/model/DocumentsStatusResponseResourcesInner.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public DocumentsStatusResponseResourcesInner status(@Nullable final DocumentStat
111111
*
112112
* @return status The status of this {@link DocumentsStatusResponseResourcesInner} instance.
113113
*/
114-
@Nonnull
114+
@Nullable
115115
public DocumentStatus getStatus() {
116116
return status;
117117
}

‎core-services/document-grounding/src/main/java/com/sap/ai/sdk/grounding/model/GetPipeline.java‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,6 @@
2222
@JsonSubTypes.Type(value = SDMPipelineGetResponse.class, name = "SDM"),
2323
@JsonSubTypes.Type(value = SFTPPipelineGetResponse.class, name = "SFTP"),
2424
@JsonSubTypes.Type(value = WorkZonePipelineGetResponse.class, name = "WorkZone"),
25-
@JsonSubTypes.Type(
26-
value = MSSharePointPipelineGetResponse.class,
27-
name = "MSSharePointPipelineGetResponse"),
28-
@JsonSubTypes.Type(value = S3PipelineGetResponse.class, name = "S3PipelineGetResponse"),
29-
@JsonSubTypes.Type(value = SDMPipelineGetResponse.class, name = "SDMPipelineGetResponse"),
30-
@JsonSubTypes.Type(value = SFTPPipelineGetResponse.class, name = "SFTPPipelineGetResponse"),
31-
@JsonSubTypes.Type(
32-
value = WorkZonePipelineGetResponse.class,
33-
name = "WorkZonePipelineGetResponse"),
3425
})
3526
public interface GetPipeline {
3627
Object getType();

0 commit comments

Comments
 (0)