Format, Syntax, checks

Author: a-d

grounding/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.sap.ai.sdk</groupId>
     <artifactId>sdk-parent</artifactId>
-    <version>1.3.0-SNAPSHOT</version>
+    <version>1.4.0-SNAPSHOT</version>
   </parent>
   <artifactId>grounding</artifactId>
   <name>Grounding client</name>

sample-code/spring-app/pom.xml

@@ -65,6 +65,10 @@
       <groupId>com.sap.cloud.sdk.cloudplatform</groupId>
       <artifactId>cloudplatform-core</artifactId>
     </dependency>
+    <dependency>
+      <groupId>com.sap.cloud.sdk.datamodel</groupId>
+      <artifactId>openapi-core</artifactId>
+    </dependency>
     <dependency>
       <groupId>org.springframework.ai</groupId>
       <artifactId>spring-ai-core</artifactId>

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/GroundingController.java

@@ -92,7 +92,7 @@ Object getAllRepositories(
    *
    * <p>Only UNKNOWN and STOPPED deployments can be DELETED
    */
-  @GetMapping("/retrieval/repositories")
+  @GetMapping("/retrieval/search")
   Object searchInDocuments(
       @Nullable @RequestParam(value = "format", required = false) final String format) {
     final var filter =
@@ -191,10 +191,10 @@ Object deleteDocuments(
     final var ids = documents.getResources().stream().map(DocumentWithoutChunks::getId).toList();
     log.info("Deleting collection {} with {} documents: {}", collectionId, ids.size(), ids);
 
-    for (UUID documentId : ids) {
+    for (final var documentId : ids) {
       final var del = CLIENT_VECTOR.deleteDocumentById(RESOURCE_GROUP, collectionId, documentId);
       if (del.getStatusCode() >= 400) {
-        final var msg = "Document {} could not be deleted, status code [{}], headers: ";
+        final var msg = "Document {} could not be deleted, status code [{}], headers: {}";
         log.error(msg, documentId, del.getStatusCode(), del.getHeaders());
         throw new IllegalStateException("Document deletion failed for id " + documentId);
       }

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/GroundingTest.java

@@ -47,7 +47,7 @@ void getRepositoriesGetAll() {
     final var repositoryCount = ((DataRepositories) result).getCount();
 
     assertThat(repositoryCount).isGreaterThan(0);
-    for (var repository : repositoryList) {
+    for (final var repository : repositoryList) {
       assertThat(repository.getId()).isNotNull();
       assertThat(repository.getTitle()).isNotNull();
     }
@@ -98,14 +98,14 @@ void testCreateDeleteCollection() {
 
   private void assertDocumentSearchResult(RetievalSearchResults search, String dayOfWeek) {
     assertThat(search.getResults()).isNotEmpty();
-    for (var resultsByFilter : search.getResults()) {
+    for (final var resultsByFilter : search.getResults()) {
       assertThat(resultsByFilter.getFilterId()).isEqualTo("question");
       assertThat(resultsByFilter.getResults()).isNotEmpty();
-      for (var result : resultsByFilter.getResults()) {
+      for (final var result : resultsByFilter.getResults()) {
         assertThat(result.getDataRepository().getDocuments()).isNotEmpty();
-        for (var document : result.getDataRepository().getDocuments()) {
+        for (final var document : result.getDataRepository().getDocuments()) {
           assertThat(document.getChunks()).isNotEmpty();
-          for (var chunk : document.getChunks()) {
+          for (final var chunk : document.getChunks()) {
             assertThat(chunk.getContent()).contains(dayOfWeek);
           }
         }
@@ -122,7 +122,7 @@ void testCollectionsGetAll() {
     final var collectionsCount = ((CollectionsListResponse) result).getCount();
 
     assertThat(collectionsCount).isGreaterThan(0);
-    for (var collection : collectionsList) {
+    for (final var collection : collectionsList) {
       assertThat(collection.getId()).isNotNull();
       assertThat(collection.getTitle()).isNotEmpty();
       assertThat(collection.getEmbeddingConfig()).isNotNull();
@@ -138,7 +138,7 @@ void testGetDocumentById(UUID collectionId, UUID documentId) {
     final var chunks = ((DocumentResponse) result).getChunks();
 
     assertThat(chunks).isNotEmpty();
-    for (var chunk : chunks) {
+    for (final var chunk : chunks) {
       assertThat(chunk.getContent()).isNotEmpty();
       assertThat(chunk.getMetadata()).isNotNull().isNotEmpty();
     }