Skip to content

Commit 0aee603

Browse files
committed
Improve one plus list construction
1 parent fe88ff5 commit 0aee603

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiChatCompletionRequest.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
package com.sap.ai.sdk.foundationmodels.openai;
22

33
import com.google.common.annotations.Beta;
4+
import com.google.common.collect.Lists;
45
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionStreamOptions;
56
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionTool;
67
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionToolChoiceOption;
78
import com.sap.ai.sdk.foundationmodels.openai.generated.model.CreateChatCompletionRequest;
89
import com.sap.ai.sdk.foundationmodels.openai.generated.model.CreateChatCompletionRequestAllOfResponseFormat;
910
import com.sap.ai.sdk.foundationmodels.openai.generated.model.CreateChatCompletionRequestAllOfStop;
1011
import java.math.BigDecimal;
11-
import java.util.ArrayList;
12-
import java.util.Arrays;
1312
import java.util.List;
1413
import java.util.Map;
1514
import java.util.Objects;
@@ -113,9 +112,8 @@ public OpenAiChatCompletionRequest(@Nonnull final String message) {
113112
@Tolerate
114113
public OpenAiChatCompletionRequest(
115114
@Nonnull final OpenAiMessage message, @Nonnull final OpenAiMessage... messages) {
116-
// Keeps default values for boolean fields. @With introduces bug comparison of Boolean
117115
this(
118-
new ArrayList<OpenAiMessage>(),
116+
Lists.asList(message, messages),
119117
null,
120118
null,
121119
null,
@@ -134,9 +132,6 @@ public OpenAiChatCompletionRequest(
134132
null,
135133
null,
136134
null);
137-
138-
this.messages.add(message);
139-
this.messages.addAll(Arrays.asList(messages));
140135
}
141136

142137
/**
@@ -150,12 +145,7 @@ public OpenAiChatCompletionRequest(
150145
@Nonnull
151146
public OpenAiChatCompletionRequest withStop(
152147
@Nonnull final String sequence, @Nonnull final String... sequences) {
153-
final var allSequences = new ArrayList<String>();
154-
155-
allSequences.add(sequence);
156-
allSequences.addAll(Arrays.asList(sequences));
157-
158-
return this.withStop(allSequences);
148+
return this.withStop(Lists.asList(sequence, sequences));
159149
}
160150

161151
/**

0 commit comments

Comments
 (0)