Skip to content

Commit 11c93c1

Browse files
committed
Rebase fix and make message class constructors package private
1 parent 585dc32 commit 11c93c1

File tree

9 files changed

+49
-22
lines changed

9 files changed

+49
-22
lines changed

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiAssistantMessage.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
package com.sap.ai.sdk.foundationmodels.openai;
22

3+
import static lombok.AccessLevel.PACKAGE;
4+
35
import com.google.common.annotations.Beta;
46
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestAssistantMessage;
57
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestAssistantMessageContent;
68
import java.util.List;
79
import javax.annotation.Nonnull;
10+
import lombok.AllArgsConstructor;
811
import lombok.Getter;
912
import lombok.Value;
1013
import lombok.experimental.Accessors;
@@ -17,6 +20,7 @@
1720
@Beta
1821
@Value
1922
@Accessors(fluent = true)
23+
@AllArgsConstructor(access = PACKAGE)
2024
public class OpenAiAssistantMessage implements OpenAiMessage {
2125

2226
/** The role associated with this message. */
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
package com.sap.ai.sdk.foundationmodels.openai;
22

3+
import com.google.common.annotations.Beta;
4+
35
/**
46
* Represents an item in a {@link OpenAiMessageContent} object.
57
*
6-
* @since 1.3.0
8+
* @since 1.4.0
79
*/
10+
@Beta
811
public sealed interface OpenAiContentItem permits OpenAiTextItem, OpenAiImageItem {}

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiImageItem.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.sap.ai.sdk.foundationmodels.openai;
22

3+
import com.google.common.annotations.Beta;
34
import java.util.Locale;
45
import javax.annotation.Nonnull;
56

@@ -8,8 +9,9 @@
89
*
910
* @param imageUrl the URL of the image
1011
* @param detailLevel the detail level of the image (optional)
11-
* @since 1.3.0
12+
* @since 1.4.0
1213
*/
14+
@Beta
1315
public record OpenAiImageItem(@Nonnull String imageUrl, @Nonnull DetailLevel detailLevel)
1416
implements OpenAiContentItem {
1517

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
package com.sap.ai.sdk.foundationmodels.openai;
22

3+
import com.google.common.annotations.Beta;
34
import java.util.List;
45
import javax.annotation.Nonnull;
56

67
/**
78
* Represents the content of a chat message.
89
*
910
* @param items a list of the content items
10-
* @since 1.3.0
11+
* @since 1.4.0
1112
*/
13+
@Beta
1214
public record OpenAiMessageContent(@Nonnull List<OpenAiContentItem> items) {}

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiSystemMessage.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.sap.ai.sdk.foundationmodels.openai;
22

3+
import static lombok.AccessLevel.PACKAGE;
4+
35
import com.google.common.annotations.Beta;
46
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestMessageContentPartText;
57
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestSystemMessage;
@@ -8,6 +10,7 @@
810
import java.util.LinkedList;
911
import java.util.List;
1012
import javax.annotation.Nonnull;
13+
import lombok.AllArgsConstructor;
1114
import lombok.Getter;
1215
import lombok.Value;
1316
import lombok.experimental.Accessors;
@@ -21,6 +24,7 @@
2124
@Beta
2225
@Value
2326
@Accessors(fluent = true)
27+
@AllArgsConstructor(access = PACKAGE)
2428
public class OpenAiSystemMessage implements OpenAiMessage {
2529

2630
/** The role associated with this message. */
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
package com.sap.ai.sdk.foundationmodels.openai;
22

3+
import com.google.common.annotations.Beta;
34
import javax.annotation.Nonnull;
45

56
/**
67
* Represents a text item in a {@link OpenAiMessageContent} object.
78
*
89
* @param text the text of the item
9-
* @since 1.3.0
10+
* @since 1.4.0
1011
*/
12+
@Beta
1113
public record OpenAiTextItem(@Nonnull String text) implements OpenAiContentItem {}

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiToolMessage.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,32 @@
11
package com.sap.ai.sdk.foundationmodels.openai;
22

3-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestMessageContentPartText;
4-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestToolMessage;
5-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestToolMessageContent;
6-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestToolMessageContentPart;
3+
import static lombok.AccessLevel.PACKAGE;
4+
5+
import com.google.common.annotations.Beta;
6+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestMessageContentPartText;
7+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestToolMessage;
8+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestToolMessageContent;
9+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestToolMessageContentPart;
710
import java.util.LinkedList;
811
import java.util.List;
912
import javax.annotation.Nonnull;
13+
import lombok.AllArgsConstructor;
1014
import lombok.Value;
1115
import lombok.experimental.Accessors;
1216
import lombok.experimental.Tolerate;
1317

1418
/**
1519
* Represents a tool message in the OpenAI service.
1620
*
17-
* @since 1.3.0
21+
* @since 1.4.0
1822
*/
23+
@Beta
1924
@Value
2025
@Accessors(fluent = true)
26+
@AllArgsConstructor(access = PACKAGE)
2127
public class OpenAiToolMessage implements OpenAiMessage {
2228

23-
/** The role of the message, which is "tool". */
29+
/** The role associated with this message. */
2430
String role = "tool";
2531

2632
/** The content of the message. */

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiUserMessage.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.sap.ai.sdk.foundationmodels.openai;
22

3+
import static lombok.AccessLevel.PACKAGE;
4+
35
import com.google.common.annotations.Beta;
46
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestMessageContentPartImage;
57
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestMessageContentPartImageImageUrl;
@@ -12,6 +14,7 @@
1214
import java.util.LinkedList;
1315
import java.util.List;
1416
import javax.annotation.Nonnull;
17+
import lombok.AllArgsConstructor;
1518
import lombok.Getter;
1619
import lombok.Value;
1720
import lombok.experimental.Accessors;
@@ -25,6 +28,7 @@
2528
@Beta
2629
@Value
2730
@Accessors(fluent = true)
31+
@AllArgsConstructor(access = PACKAGE)
2832
public class OpenAiUserMessage implements OpenAiMessage {
2933

3034
/** The role associated with this message. */

foundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/MessageConvenienceTest.java renamed to foundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/OpenAIMessageTest.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22

33
import static org.assertj.core.api.Assertions.assertThat;
44

5-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestAssistantMessage;
6-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestAssistantMessageContent;
7-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestMessageContentPartImage;
8-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestMessageContentPartImageImageUrl;
9-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestMessageContentPartText;
10-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestSystemMessage;
11-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestSystemMessageContent;
12-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestToolMessage;
13-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestToolMessageContent;
14-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestUserMessage;
15-
import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestUserMessageContent;
5+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestAssistantMessage;
6+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestAssistantMessageContent;
7+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestMessageContentPartImage;
8+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestMessageContentPartImageImageUrl;
9+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestMessageContentPartText;
10+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestSystemMessage;
11+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestSystemMessageContent;
12+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestToolMessage;
13+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestToolMessageContent;
14+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestUserMessage;
15+
import com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionRequestUserMessageContent;
1616
import java.net.URI;
1717
import java.util.List;
1818
import java.util.stream.Stream;
@@ -23,7 +23,7 @@
2323
import org.junit.jupiter.params.provider.Arguments;
2424
import org.junit.jupiter.params.provider.MethodSource;
2525

26-
class MessageConvenienceTest {
26+
class OpenAIMessageTest {
2727
static String validText = "Some string";
2828
static String validImageUrl = "http://valid-url.com";
2929

0 commit comments

Comments
 (0)