Skip to content

Commit 2517065

Browse files
committed
Apply additional review suggestion
1 parent 1aa952b commit 2517065

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ public ClientResponseHandler<T, R, E> objectMapper(@Nonnull final ObjectMapper j
6868
@Override
6969
public T handleResponse(@Nonnull final ClassicHttpResponse response) throws E {
7070
if (response.getCode() >= 300) {
71-
7271
buildAndThrowException(response);
7372
}
7473
return parseSuccess(response);

core/src/main/java/com/sap/ai/sdk/core/common/RequestLogContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,9 @@ public enum Mode {
132132
@RequiredArgsConstructor
133133
public enum Service {
134134
/** OpenAI service */
135-
OPENAI("openai"),
135+
OPENAI("OpenAI"),
136136
/** Orchestration service */
137-
ORCHESTRATION("orchestration");
137+
ORCHESTRATION("Orchestration");
138138
@Getter private final String value;
139139
}
140140
}

core/src/test/java/com/sap/ai/sdk/core/common/RequestLogContextTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ void testRequestLogContextLifecycle() {
1919
RequestLogContext.setEndpoint("/api/endpoint");
2020
RequestLogContext.setDestination("http://localhost:8000");
2121

22-
assertThat(MDC.get("service")).isEqualTo("openai");
22+
assertThat(MDC.get("service")).isEqualTo("OpenAI");
2323
assertThat(MDC.get("mode")).isEqualTo("streaming");
2424
assertThat(MDC.get("endpoint")).isEqualTo("/api/endpoint");
2525
assertThat(MDC.get("destination")).isEqualTo("http://localhost:8000");

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ private <T> T executeRequest(
455455
final BasicClassicHttpRequest request, @Nonnull final Class<T> responseType) {
456456
try {
457457
final var client = ApacheHttpClient5Accessor.getHttpClient(destination);
458-
RequestLogContext.setDestination(((HttpDestination) destination).getUri().toString());
458+
RequestLogContext.setDestination(destination.asHttp().getUri().toString());
459459
RequestLogContext.setMode(SYNCHRONOUS);
460460
RequestLogContext.setService(OPENAI);
461461
RequestLogContext.logRequestStart();
@@ -473,7 +473,7 @@ private <D extends StreamedDelta> Stream<D> streamRequest(
473473
final BasicClassicHttpRequest request, @Nonnull final Class<D> deltaType) {
474474
try {
475475
final var client = ApacheHttpClient5Accessor.getHttpClient(destination);
476-
RequestLogContext.setDestination(((HttpDestination) destination).getUri().toASCIIString());
476+
RequestLogContext.setDestination(destination.asHttp().getUri().toString());
477477
RequestLogContext.setMode(STREAMING);
478478
RequestLogContext.setService(OPENAI);
479479
RequestLogContext.logRequestStart();

0 commit comments

Comments
 (0)