Skip to content

Commit 2b6f8fe

Browse files
committed
Fix minor naming issues
1 parent 3cc5581 commit 2b6f8fe

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationEmbeddingRequest.java

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,18 @@ public class OrchestrationEmbeddingRequest {
3535
@Nonnull OrchestrationEmbeddingModel model;
3636

3737
/** The list of text inputs to be converted into embeddings. */
38-
@Nonnull List<String> tokens;
38+
@Nonnull List<String> inputs;
3939

4040
/** Optional masking providers for data privacy and security. */
4141
@With(value = PRIVATE)
4242
@Nullable
4343
List<MaskingProvider> masking;
4444

45-
/** Optional token type classification to optimize embedding generation. */
45+
/** Optional embedding input type classification to optimize embedding generation. */
4646
@With(value = PRIVATE)
4747
@Getter(NONE)
4848
@Nullable
49-
EmbeddingsInput.TypeEnum tokenType;
49+
EmbeddingsInput.TypeEnum inputType;
5050

5151
/**
5252
* Create an embedding request using fluent API starting with model selection.
@@ -60,7 +60,7 @@ public class OrchestrationEmbeddingRequest {
6060
*/
6161
@Nonnull
6262
public static InputStep forModel(@Nonnull final OrchestrationEmbeddingModel model) {
63-
return tokens -> new OrchestrationEmbeddingRequest(model, List.copyOf(tokens), null, null);
63+
return inputs -> new OrchestrationEmbeddingRequest(model, List.copyOf(inputs), null, null);
6464
}
6565

6666
/** Builder step for specifying text inputs to embed. */
@@ -70,21 +70,22 @@ public interface InputStep {
7070
/**
7171
* Specifies text inputs to be embedded.
7272
*
73-
* @param tokens the text strings to embed
73+
* @param inputs the text strings to embed
7474
* @return a new embedding request instance
7575
*/
7676
@Nonnull
77-
OrchestrationEmbeddingRequest forInputs(@Nonnull final List<String> tokens);
77+
OrchestrationEmbeddingRequest forInputs(@Nonnull final List<String> inputs);
7878

7979
/**
8080
* Specifies multiple text inputs using variable arguments.
8181
*
82-
* @param tokens one or more strings to embed
82+
* @param inputs one or more strings to embed
8383
* @return a new embedding request instance
8484
*/
8585
@Nonnull
86-
default OrchestrationEmbeddingRequest forInputs(@Nonnull final String... tokens) {
87-
return forInputs(List.of(tokens));
86+
default OrchestrationEmbeddingRequest forInputs(
87+
@Nonnull final String firstInput, String... inputs) {
88+
return forInputs(Lists.asList(firstInput, inputs));
8889
}
8990
}
9091

@@ -111,7 +112,7 @@ public OrchestrationEmbeddingRequest withMasking(
111112
*/
112113
@Nonnull
113114
public OrchestrationEmbeddingRequest asDocument() {
114-
return withTokenType(EmbeddingsInput.TypeEnum.DOCUMENT);
115+
return withInputType(EmbeddingsInput.TypeEnum.DOCUMENT);
115116
}
116117

117118
/**
@@ -121,7 +122,7 @@ public OrchestrationEmbeddingRequest asDocument() {
121122
*/
122123
@Nonnull
123124
public OrchestrationEmbeddingRequest asText() {
124-
return withTokenType(EmbeddingsInput.TypeEnum.TEXT);
125+
return withInputType(EmbeddingsInput.TypeEnum.TEXT);
125126
}
126127

127128
/**
@@ -131,14 +132,14 @@ public OrchestrationEmbeddingRequest asText() {
131132
*/
132133
@Nonnull
133134
public OrchestrationEmbeddingRequest asQuery() {
134-
return withTokenType(EmbeddingsInput.TypeEnum.QUERY);
135+
return withInputType(EmbeddingsInput.TypeEnum.QUERY);
135136
}
136137

137138
@Nonnull
138139
EmbeddingsPostRequest createEmbeddingsPostRequest() {
139140

140141
final var input =
141-
EmbeddingsInput.create().text(EmbeddingsInputText.create(tokens)).type(tokenType);
142+
EmbeddingsInput.create().text(EmbeddingsInputText.create(inputs)).type(inputType);
142143
final var embeddingsModelConfig =
143144
EmbeddingsModelConfig.create().model(model.createEmbeddingsModelDetails());
144145
final var modules =

0 commit comments

Comments
 (0)