Skip to content

Commit 2ef5716

Browse files
committed
Fix merge and update test
1 parent 7d240ae commit 2ef5716

File tree

2 files changed

+23
-6
lines changed
  • foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai
  • sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers

2 files changed

+23
-6
lines changed

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiModel.java

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,19 @@ public record OpenAiModel(@Nonnull String name, @Nullable String version) implem
1919
/** Azure OpenAI dall-e-3 image generate model */
2020
public static final OpenAiModel DALL_E_3 = new OpenAiModel("dall-e-3", null);
2121

22-
/** Azure OpenAI GPT-3.5 Turbo chat completions model */
23-
public static final OpenAiModel GPT_35_TURBO = new OpenAiModel("gpt-35-turbo", null);
22+
/**
23+
* Azure OpenAI GPT-3.5 Turbo chat completions model
24+
*
25+
* @deprecated This model is not usable anymore. It is retired on AI Core since 2024-11-17.
26+
*/
27+
@Deprecated public static final OpenAiModel GPT_35_TURBO = new OpenAiModel("gpt-35-turbo", null);
2428

25-
/** Azure OpenAI GPT-3.5 Turbo chat completions model */
29+
/**
30+
* Azure OpenAI GPT-3.5 Turbo chat completions model
31+
*
32+
* @deprecated This model is not usable anymore. It is retired on AI Core since 2025-02-22.
33+
*/
34+
@Deprecated
2635
public static final OpenAiModel GPT_35_TURBO_1025 = new OpenAiModel("gpt-35-turbo-0125", null);
2736

2837
/**
@@ -36,8 +45,12 @@ public record OpenAiModel(@Nonnull String name, @Nullable String version) implem
3645
/** Azure OpenAI GPT-4 chat completions model */
3746
public static final OpenAiModel GPT_4 = new OpenAiModel("gpt-4", null);
3847

39-
/** Azure OpenAI GPT-4-32k chat completions model */
40-
public static final OpenAiModel GPT_4_32K = new OpenAiModel("gpt-4-32k", null);
48+
/**
49+
* Azure OpenAI GPT-4-32k chat completions model
50+
*
51+
* @deprecated This model will not be usable anymore on 2025-05-30.
52+
*/
53+
@Deprecated public static final OpenAiModel GPT_4_32K = new OpenAiModel("gpt-4-32k", null);
4154

4255
/** Azure OpenAI GPT-4o chat completions model */
4356
public static final OpenAiModel GPT_4O = new OpenAiModel("gpt-4o", null);

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/ScenarioTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import java.util.HashMap;
1010
import java.util.Optional;
1111
import lombok.SneakyThrows;
12+
import org.assertj.core.api.SoftAssertions;
1213
import org.junit.jupiter.api.DisplayName;
1314
import org.junit.jupiter.api.Test;
1415
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;
@@ -46,14 +47,17 @@ void openAiModelAvailability() {
4647

4748
// Assert that the declared OpenAI models match the expected list
4849
assertThat(declaredOpenAiModelList.keySet()).containsAll(availableOpenAiModels.keySet());
50+
51+
SoftAssertions softly = new SoftAssertions();
4952
for (var model : availableOpenAiModels.entrySet()) {
5053
Boolean declaredDeprecated = declaredOpenAiModelList.get(model.getKey());
51-
assertThat(declaredDeprecated)
54+
softly.assertThat(declaredDeprecated)
5255
.withFailMessage(
5356
"%s is deprecated:%s on AI Core but deprecated:%s in AI SDK",
5457
model.getKey(), model.getValue(), declaredDeprecated)
5558
.isEqualTo(model.getValue());
5659
}
60+
softly.assertAll();
5761
}
5862

5963
private static boolean isDeprecated(AiModelBaseData model) {

0 commit comments

Comments
 (0)