logback config file

Author: CharlesDuboisSAP

core/src/main/java/com/sap/ai/sdk/core/AiCoreServiceKeyAccessor.java

@@ -29,8 +29,6 @@ class AiCoreServiceKeyAccessor implements ServiceBindingAccessor {
 
   private final Lazy<Dotenv> dotenv;
 
-  static List<ServiceBinding> serviceBindings;
-
   AiCoreServiceKeyAccessor() {
     this(Dotenv.configure().ignoreIfMissing().ignoreIfMalformed());
   }
@@ -42,14 +40,6 @@ class AiCoreServiceKeyAccessor implements ServiceBindingAccessor {
   @Nonnull
   @Override
   public List<ServiceBinding> getServiceBindings() throws ServiceBindingAccessException {
-    // service bindings are immutable for the lifetime of the application
-    if (serviceBindings == null) {
-      serviceBindings = fetchServiceBindings();
-    }
-    return serviceBindings;
-  }
-
-  private List<ServiceBinding> fetchServiceBindings() throws ServiceBindingAccessException {
     final String serviceKey;
     try {
       serviceKey = dotenv.get().get(ENV_VAR_KEY);

core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java

@@ -88,11 +88,13 @@ private T parseSuccess(@Nonnull final ClassicHttpResponse response) throws E {
             .getOrElseThrow(e -> exceptionFactory.build(message, e).setHttpResponse(response));
     try {
       final T value = objectMapper.readValue(content, successType);
-      log.info("Response content: {}", content);
       val timeHeaders = response.getHeaders("x-upstream-service-time");
       if (timeHeaders.length > 0) {
         log.info("LLM request success with duration:{}", timeHeaders[0].getValue());
+      } else {
+        log.info("LLM request success");
       }
+      log.debug("Response content:\n{}", content);
       return value;
     } catch (final JsonProcessingException e) {
       log.error("Failed to parse response to type {}", successType);

core/src/test/java/com/sap/ai/sdk/core/AiCoreServiceKeyAccessorTest.java

@@ -9,16 +9,10 @@
 import com.sap.cloud.environment.servicebinding.api.exception.ServiceBindingAccessException;
 import io.github.cdimascio.dotenv.Dotenv;
 import java.util.Map;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 class AiCoreServiceKeyAccessorTest {
 
-  @BeforeEach
-  void resetServiceBindings() {
-    AiCoreServiceKeyAccessor.serviceBindings = null;
-  }
-
   @Test
   void testValidDotenv() {
     var dotenv = spy(Dotenv.configure().filename("valid.testenv"));

logback.xml

@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+	<property name="LOG_PATTERN" value="%d{HH:mm:ss.SSS} %-5level [%thread] %logger{36} - %msg%n"/>
+
+	<appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
+		<encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder">
+			<pattern>${LOG_PATTERN}</pattern>
+		</encoder>
+	</appender>
+
+	<root level="INFO">
+		<appender-ref ref="CONSOLE"/>
+	</root>
+
+	<!--  <logger name="org.apache.hc.client5.http.wire" level="DEBUG"/>-->
+	<!--  <logger name="org.apache.http.wire" level="DEBUG"/>-->
+	<logger name="com.sap.ai.sdk" level="DEBUG"/>
+	<!-- Disable org.eclipse.jetty logging -->
+	<logger name="org.eclipse.jetty" level="OFF"/>
+</configuration>

pom.xml

@@ -71,6 +71,7 @@
     <javaparser.version>3.27.1</javaparser.version>
     <jsonschema-generator.version>4.38.0</jsonschema-generator.version>
     <jackson.version>2.20.0</jackson.version>
+    <logback.version>1.5.20</logback.version>
     <!-- conflicts resolution -->
     <micrometer.version>1.15.5</micrometer.version>
     <json.version>20250517</json.version>
@@ -260,7 +261,7 @@
     <dependency>
       <groupId>ch.qos.logback</groupId>
       <artifactId>logback-classic</artifactId>
-      <version>1.5.20</version>
+      <version>${logback.version}</version>
       <scope>test</scope>
     </dependency>
   </dependencies>
@@ -596,6 +597,11 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
         <version>${surefire.version}</version>
+        <configuration>
+          <systemPropertyVariables>
+            <logback.configurationFile>${project.rootdir}/logback.xml</logback.configurationFile>
+          </systemPropertyVariables>
+        </configuration>
       </plugin>
       <!-- phase: verify -->
       <plugin>