Skip to content

Commit 35e8fce

Browse files
committed
Further Modifications
1 parent b2c475a commit 35e8fce

File tree

2 files changed

+4
-24
lines changed

2 files changed

+4
-24
lines changed

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ public OrchestrationModuleConfig withTemplateConfig(
331331
@Nonnull
332332
public OrchestrationModuleConfig withInputTranslationConfig(
333333
@Nonnull final TranslationConfig translationConfig) {
334-
return this.withInputTranslationConfig(translationConfig.createSAPDocumentTranslationInput());
334+
return this.withInputTranslationConfig(translationConfig.getInputConfig());
335335
}
336336

337337
/**
@@ -344,6 +344,6 @@ public OrchestrationModuleConfig withInputTranslationConfig(
344344
@Nonnull
345345
public OrchestrationModuleConfig withOutputTranslationConfig(
346346
@Nonnull final TranslationConfig translationConfig) {
347-
return this.withOutputTranslationConfig(translationConfig.createSAPDocumentTranslationOutput());
347+
return this.withOutputTranslationConfig(translationConfig.getOutputConfig());
348348
}
349349
}

orchestration/src/main/java/com/sap/ai/sdk/orchestration/TranslationConfig.java

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
* @link <a
2020
* href="https://help.sap.com/docs/sap-ai-core/sap-ai-core-service-guide/sap-document-translation">SAP
2121
* AI Core: Orchestration - SAP Document Translation</a>
22+
* @since 1.14.0
2223
*/
2324
@Value
2425
@With
@@ -63,8 +64,7 @@ public static TranslationConfig createOutput(@Nonnull final String targetLanguag
6364
.config(
6465
SAPDocumentTranslationOutputConfig.create()
6566
.targetLanguage(
66-
SAPDocumentTranslationOutputTargetLanguage.create(targetLanguage))
67-
.sourceLanguage("en-US"));
67+
SAPDocumentTranslationOutputTargetLanguage.create(targetLanguage)));
6868
return new TranslationConfig(null, outputConfig, null);
6969
}
7070

@@ -78,24 +78,4 @@ public static TranslationConfig createOutput(@Nonnull final String targetLanguag
7878
public TranslationConfig sourceLanguage(@Nonnull final String language) {
7979
return this.withSourceLanguage(language);
8080
}
81-
82-
/**
83-
* Build and return the input translation configuration
84-
*
85-
* @return The SAPDocumentTranslationInput configuration
86-
*/
87-
@Nonnull
88-
SAPDocumentTranslationInput createSAPDocumentTranslationInput() {
89-
return inputConfig;
90-
}
91-
92-
/**
93-
* Build and return the output translation configuration
94-
*
95-
* @return The SAPDocumentTranslationOutput configuration
96-
*/
97-
@Nonnull
98-
SAPDocumentTranslationOutput createSAPDocumentTranslationOutput() {
99-
return outputConfig;
100-
}
10181
}

0 commit comments

Comments
 (0)