add test for call and use low level api

Author: rpanackal

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiSpringEmbeddingModel.java

@@ -1,11 +1,14 @@
 package com.sap.ai.sdk.foundationmodels.openai.spring;
 
 import com.sap.ai.sdk.foundationmodels.openai.OpenAiClient;
-import com.sap.ai.sdk.foundationmodels.openai.OpenAiEmbeddingRequest;
-import com.sap.ai.sdk.foundationmodels.openai.OpenAiEmbeddingResponse;
 import com.sap.ai.sdk.foundationmodels.openai.OpenAiModel;
+import com.sap.ai.sdk.foundationmodels.openai.generated.model.EmbeddingsCreate200Response;
+import com.sap.ai.sdk.foundationmodels.openai.generated.model.EmbeddingsCreateRequest;
+import com.sap.ai.sdk.foundationmodels.openai.generated.model.EmbeddingsCreateRequestInput;
+import java.util.Objects;
 import java.util.stream.IntStream;
 import javax.annotation.Nonnull;
+import lombok.NoArgsConstructor;
 import org.springframework.ai.chat.metadata.DefaultUsage;
 import org.springframework.ai.document.Document;
 import org.springframework.ai.embedding.Embedding;
@@ -14,14 +17,17 @@
 import org.springframework.ai.embedding.EmbeddingResponse;
 import org.springframework.ai.embedding.EmbeddingResponseMetadata;
 
+@NoArgsConstructor
 public class OpenAiSpringEmbeddingModel implements EmbeddingModel {
 
   @Override
   public EmbeddingResponse call(@Nonnull final EmbeddingRequest request) {
-
-    var modelName = request.getOptions().getModel();
+    var modelName =
+        Objects.requireNonNull(
+            request.getOptions().getModel(), "Model name is required if client is not set");
     var client = OpenAiClient.forModel(new OpenAiModel(modelName, null));
-    var openAiRequest = createOpenAiEmbeddingRequest(request);
+
+    var openAiRequest = createEmbeddingCreateRequest(request);
     var openAiResponse = client.embedding(openAiRequest);
 
     return createSpringAiEmbeddingResponse(openAiResponse);
@@ -36,20 +42,22 @@ public float[] embed(@Nonnull final Document document) {
         "Only text type document supported. Metadata contains " + document.getMetadata());
   }
 
-  private OpenAiEmbeddingRequest createOpenAiEmbeddingRequest(
+  private EmbeddingsCreateRequest createEmbeddingCreateRequest(
       @Nonnull final EmbeddingRequest request) {
-    return new OpenAiEmbeddingRequest(request.getInstructions())
-        .withDimensions(request.getOptions().getDimensions());
+    return new EmbeddingsCreateRequest()
+        .dimensions(request.getOptions().getDimensions())
+        .input(EmbeddingsCreateRequestInput.create(request.getInstructions()));
   }
 
-  private EmbeddingResponse createSpringAiEmbeddingResponse(OpenAiEmbeddingResponse response) {
-    var vectors = response.getEmbeddingVectors();
+  private EmbeddingResponse createSpringAiEmbeddingResponse(EmbeddingsCreate200Response response) {
     var embeddings =
-        IntStream.range(0, vectors.size()).mapToObj(i -> new Embedding(vectors.get(i), i)).toList();
+        IntStream.range(0, response.getData().size())
+            .mapToObj(i -> new Embedding(response.getData().get(i).getEmbedding(), i))
+            .toList();
 
-    var openAiUsage = response.getOriginalResponse().getUsage();
+    var openAiUsage = response.getUsage();
     var usage = new DefaultUsage(openAiUsage.getPromptTokens(), null, openAiUsage.getTotalTokens());
-    var metadata = new EmbeddingResponseMetadata(response.getOriginalResponse().getModel(), usage);
+    var metadata = new EmbeddingResponseMetadata(response.getModel(), usage);
 
     return new EmbeddingResponse(embeddings, metadata);
   }

foundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/spring/EmbeddingModelTest.java

@@ -0,0 +1,63 @@
+package com.sap.ai.sdk.foundationmodels.openai.spring;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockStatic;
+import static org.mockito.Mockito.when;
+
+import com.sap.ai.sdk.foundationmodels.openai.OpenAiClient;
+import com.sap.ai.sdk.foundationmodels.openai.generated.model.EmbeddingsCreate200Response;
+import com.sap.ai.sdk.foundationmodels.openai.generated.model.EmbeddingsCreate200ResponseDataInner;
+import com.sap.ai.sdk.foundationmodels.openai.generated.model.EmbeddingsCreate200ResponseUsage;
+import com.sap.ai.sdk.foundationmodels.openai.generated.model.EmbeddingsCreateRequest;
+import java.util.List;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.springframework.ai.chat.metadata.DefaultUsage;
+import org.springframework.ai.embedding.Embedding;
+import org.springframework.ai.embedding.EmbeddingOptionsBuilder;
+import org.springframework.ai.embedding.EmbeddingRequest;
+import org.springframework.ai.embedding.EmbeddingResponse;
+import org.springframework.ai.embedding.EmbeddingResponseMetadata;
+
+class EmbeddingModelTest {
+  private OpenAiSpringEmbeddingModel model;
+  private OpenAiClient client;
+
+  @BeforeEach
+  void setUp() {
+    client = mock(OpenAiClient.class);
+    model = new OpenAiSpringEmbeddingModel();
+  }
+
+  @Test
+  void testCall() {
+    var request =
+        new EmbeddingRequest(
+            List.of("instructions"),
+            EmbeddingOptionsBuilder.builder().withModel("model").withDimensions(128).build());
+
+    var vector = new float[] {0.0f};
+    var expectedResponse =
+        new EmbeddingResponse(
+            List.of(new Embedding(vector, 0)),
+            new EmbeddingResponseMetadata("model", new DefaultUsage(0, null, 0)));
+
+    var openAiResponse =
+        new EmbeddingsCreate200Response()
+            .data(List.of(new EmbeddingsCreate200ResponseDataInner().embedding(vector)))
+            .model("model")
+            .usage(new EmbeddingsCreate200ResponseUsage().promptTokens(0).totalTokens(0));
+
+    when(client.embedding(any(EmbeddingsCreateRequest.class))).thenReturn(openAiResponse);
+
+    try (var mockedStatic = mockStatic(OpenAiClient.class)) {
+      mockedStatic.when(() -> OpenAiClient.forModel(any())).thenReturn(client);
+
+      var actualResponse = model.call(request);
+
+      assertThat(expectedResponse).usingRecursiveComparison().isEqualTo(actualResponse);
+    }
+  }
+}