Skip to content

Commit 44e86bb

Browse files
committed
Minor test and release note changes
- prefix with "test" on all test method - update link in release note - update test display name
1 parent 74682ba commit 44e86bb

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

docs/release-notes/release_notes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
- [Orchestration] [Add Spring AI Chat Memory support](https://github.com/SAP/ai-sdk-java/tree/main/docs/guides/SPRING_AI_INTEGRATION.md#chat-memory)
1616
- [Orchestration] [Prompt templates can be consumed from registry.](https://github.com/SAP/ai-sdk-java/tree/main/docs/guides/ORCHESTRATION_CHAT_COMPLETION.md#Chat-completion-with-Templates)
1717
- [Orchestration] [Grounding via *help.sap.com* is enabled.](https://github.com/SAP/ai-sdk-java/tree/main/docs/guides/ORCHESTRATION_CHAT_COMPLETION.md#grounding)
18-
- [OpenAI] [Spring AI integration for embedding calls.](../guides/SPRING_AI_INTEGRATION.md#embedding)
18+
- [OpenAI] [Spring AI integration for embedding calls.](https://github.com/SAP/ai-sdk-java/tree/main/docs/guides/SPRING_AI_INTEGRATION.md#embedding)
1919

2020
### 📈 Improvements
2121

foundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/spring/EmbeddingModelTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ void setUp() {
3636

3737
@Test
3838
@DisplayName("Call with embedding request containing valid options")
39-
void callWithValidEmbeddingRequest() {
39+
void testCallWithValidEmbeddingRequest() {
4040
val texts = List.of("Some text");
4141
val springAiRequest =
4242
new EmbeddingRequest(texts, EmbeddingOptionsBuilder.builder().withDimensions(128).build());
@@ -69,8 +69,8 @@ void callWithValidEmbeddingRequest() {
6969
}
7070

7171
@Test
72-
@DisplayName("Call with embedding request with model option set")
73-
void callWithModelOptionSetThrowsException() {
72+
@DisplayName("Call with embedding request with model option set throws exception")
73+
void testCallWithModelOptionSetThrows() {
7474
val springAiRequest =
7575
new EmbeddingRequest(
7676
List.of("Some text"), EmbeddingOptionsBuilder.builder().withModel("model").build());
@@ -85,7 +85,7 @@ void callWithModelOptionSetThrowsException() {
8585

8686
@Test
8787
@DisplayName("Embed document with text content")
88-
void embedDocument() {
88+
void testEmbedDocument() {
8989
Document document = new Document("Some content");
9090

9191
val vector = new float[] {1, 2, 3};
@@ -107,8 +107,8 @@ void embedDocument() {
107107
}
108108

109109
@Test
110-
@DisplayName("Embed document with missing text content")
111-
void embedDocumentNonTextThrowsException() {
110+
@DisplayName("Embed document with missing text content throws exception")
111+
void testEmbedNonTextDocumentThrows() {
112112
val document = mock(Document.class);
113113
when(document.isText()).thenReturn(false);
114114

0 commit comments

Comments
 (0)