minor fixes

- final keyword
- remove redundant assertion
- variable naming

Author: rpanackal

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OpenAiService.java

@@ -164,8 +164,8 @@ public OpenAiChatCompletionOutput chatCompletionToolExecution(
     try {
       final var weatherRequest =
           JACKSON.readValue(toolCall.getFunction().getArguments(), WeatherMethod.Request.class);
-      final var toolResponse = new WeatherMethod().getCurrentWeather(weatherRequest);
-      toolResponseJson = JACKSON.writeValueAsString(toolResponse);
+      final var currentWeather = new WeatherMethod().getCurrentWeather(weatherRequest);
+      toolResponseJson = JACKSON.writeValueAsString(currentWeather);
     } catch (JsonProcessingException e) {
       throw new IllegalArgumentException("Error parsing tool call arguments", e);
     }

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OpenAiTest.java

@@ -108,7 +108,6 @@ void chatCompletionToolExecution() {
 
     String content = completion.getContent();
 
-    assertThat(content).isNotEmpty();
     assertThat(content).contains("°C");
   }
 }

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OpenAiV2Test.java

@@ -109,7 +109,6 @@ void chatCompletionToolExecution() {
 
     String content = completion.getChoices().get(0).getMessage().getContent();
 
-    assertThat(content).isNotEmpty();
     assertThat(content).contains("°C");
   }
 }

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/services/OpenAiServiceV2.java

@@ -138,7 +138,7 @@ public CreateChatCompletionResponse chatCompletionToolExecution(
     final var jsonSchemaGenerator = new JsonSchemaGenerator(JACKSON);
     Map<String, Object> schemaMap;
     try {
-      var schema = jsonSchemaGenerator.generateSchema(WeatherMethod.Request.class);
+      final var schema = jsonSchemaGenerator.generateSchema(WeatherMethod.Request.class);
       schemaMap = JACKSON.convertValue(schema, new TypeReference<>() {});
     } catch (JsonMappingException e) {
       throw new IllegalArgumentException("Could not generate schema for WeatherMethod.Request", e);
@@ -152,7 +152,7 @@ public CreateChatCompletionResponse chatCompletionToolExecution(
 
     final var tool = new ChatCompletionTool().type(FUNCTION).function(function);
 
-    var userMessage =
+    final var userMessage =
         new ChatCompletionRequestUserMessage()
             .role(ChatCompletionRequestUserMessage.RoleEnum.USER)
             .content(
@@ -167,15 +167,15 @@ public CreateChatCompletionResponse chatCompletionToolExecution(
 
     OpenAiClient client = OpenAiClient.forModel(GPT_4O_MINI);
 
-    final var initialResponse = client.chatCompletion(request);
+    final var response = client.chatCompletion(request);
 
-    final var toolCall = initialResponse.getChoices().get(0).getMessage().getToolCalls().get(0);
+    final var toolCall = response.getChoices().get(0).getMessage().getToolCalls().get(0);
     String toolResponseJson;
     try {
-      var weatherRequest =
+      final var weatherRequest =
           JACKSON.readValue(toolCall.getFunction().getArguments(), WeatherMethod.Request.class);
-      final var toolResponse = new WeatherMethod().getCurrentWeather(weatherRequest);
-      toolResponseJson = JACKSON.writeValueAsString(toolResponse);
+      final var currentWeather = new WeatherMethod().getCurrentWeather(weatherRequest);
+      toolResponseJson = JACKSON.writeValueAsString(currentWeather);
     } catch (JsonProcessingException e) {
       throw new IllegalArgumentException("Error parsing tool call arguments", e);
     }
@@ -185,7 +185,7 @@ public CreateChatCompletionResponse chatCompletionToolExecution(
             .role(ChatCompletionRequestAssistantMessage.RoleEnum.ASSISTANT)
             .content(
                 ChatCompletionRequestAssistantMessageContent.create(
-                    initialResponse.getChoices().get(0).getMessage().getContent()))
+                    response.getChoices().get(0).getMessage().getContent()))
             .toolCalls(List.of(toolCall));
     request.addMessagesItem(assistantMessage);