Fixing approach

Author: n-o-u-r-h-a-n

orchestration/pom.xml

@@ -41,7 +41,7 @@
     <coverage.instruction>94%</coverage.instruction>
     <coverage.branch>75%</coverage.branch>
     <coverage.method>93%</coverage.method>
-    <coverage.class>98%</coverage.class>
+    <coverage.class>100%</coverage.class>
   </properties>
 
   <dependencies>

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfig.java

@@ -320,4 +320,30 @@ public OrchestrationModuleConfig withTemplateConfig(
       @Nonnull final TemplateConfig templateConfig) {
     return this.withTemplateConfig(templateConfig.toLowLevel());
   }
+
+  /**
+   * Configure input translation using a high-level TranslationConfig.
+   *
+   * @param translationConfig The translation configuration
+   * @return A new OrchestrationModuleConfig with input translation configured
+   */
+  @Tolerate
+  @Nonnull
+  public OrchestrationModuleConfig withInputTranslationConfig(
+      @Nonnull final TranslationConfig translationConfig) {
+    return this.withInputTranslationConfig(translationConfig.createSAPDocumentTranslationInput());
+  }
+
+  /**
+   * Configure output translation using a high-level TranslationConfig.
+   *
+   * @param translationConfig The translation configuration
+   * @return A new OrchestrationModuleConfig with output translation configured
+   */
+  @Tolerate
+  @Nonnull
+  public OrchestrationModuleConfig withOutputTranslationConfig(
+      @Nonnull final TranslationConfig translationConfig) {
+    return this.withOutputTranslationConfig(translationConfig.createSAPDocumentTranslationOutput());
+  }
 }

orchestration/src/main/java/com/sap/ai/sdk/orchestration/TranslationConfig.java

@@ -10,6 +10,8 @@
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 import lombok.Value;
+import lombok.With;
+import lombok.val;
 
 /**
  * Configuration helper for SAP Document Translation.
@@ -19,70 +21,81 @@
  *     AI Core: Orchestration - SAP Document Translation</a>
  */
 @Value
+@With
 @Getter(AccessLevel.PACKAGE)
 @RequiredArgsConstructor(access = AccessLevel.PRIVATE)
 public class TranslationConfig {
-  @Nonnull SAPDocumentTranslationInput.TypeEnum translationType;
+  SAPDocumentTranslationInput inputConfig;
+  SAPDocumentTranslationOutput outputConfig;
+  String sourceLanguage;
 
   /**
-   * Create a builder for the SAP_DOCUMENT_TRANSLATION translation provider
+   * Create a new input translation configuration.
    *
-   * @return The Builder instance.
+   * @param targetLanguage The target language code
+   * @return A TranslationConfig configured for input translation
    */
   @Nonnull
-  public static Builder inputTranslation() {
-    return new TranslationConfig.Builder(
-        SAPDocumentTranslationInput.TypeEnum.SAP_DOCUMENT_TRANSLATION);
+  public static TranslationConfig createInputConfig(@Nonnull final String targetLanguage) {
+    val translationType = SAPDocumentTranslationInput.TypeEnum.SAP_DOCUMENT_TRANSLATION;
+    val inputConfig =
+        SAPDocumentTranslationInput.create()
+            .type(translationType)
+            .config(
+                SAPDocumentTranslationInputConfig.create()
+                    .targetLanguage(targetLanguage)
+                    .applyTo(null));
+    return new TranslationConfig(inputConfig, null, null);
   }
 
   /**
-   * Create a builder for the SAP_DOCUMENT_TRANSLATION translation provider
+   * Create a new output translation configuration.
    *
-   * @return The Builder2 instance.
+   * @param targetLanguage The target language code
+   * @return A TranslationConfig configured for output translation
    */
   @Nonnull
-  public static Builder2 outputTranslation() {
-    return new TranslationConfig.Builder2(
-        SAPDocumentTranslationOutput.TypeEnum.SAP_DOCUMENT_TRANSLATION);
+  public static TranslationConfig createOutputConfig(@Nonnull final String targetLanguage) {
+    val translationType = SAPDocumentTranslationOutput.TypeEnum.SAP_DOCUMENT_TRANSLATION;
+    val outputConfig =
+        SAPDocumentTranslationOutput.create()
+            .type(translationType)
+            .config(
+                SAPDocumentTranslationOutputConfig.create()
+                    .targetLanguage(
+                        SAPDocumentTranslationOutputTargetLanguage.create(targetLanguage))
+                    .sourceLanguage("en-US"));
+    return new TranslationConfig(null, outputConfig, null);
   }
 
-  /** Builder helper class. */
-  @RequiredArgsConstructor(access = AccessLevel.PRIVATE)
-  public static class Builder {
-
-    private final SAPDocumentTranslationInput.TypeEnum translationType;
-
-    /**
-     * Get the input translation config with default values.
-     *
-     * @return The SAPDocumentTranslationInput instance.
-     */
-    @Nonnull
-    public SAPDocumentTranslationInput getInputTranslationConfig() {
-      return SAPDocumentTranslationInput.create()
-          .type(translationType)
-          .config(SAPDocumentTranslationInputConfig.create().targetLanguage("en-US").applyTo(null));
-    }
+  /**
+   * Set the source language for translation
+   *
+   * @param language The source language code
+   * @return A new TranslationConfig with the specified source language
+   */
+  @Nonnull
+  public TranslationConfig sourceLanguage(@Nonnull final String language) {
+    return this.withSourceLanguage(language);
   }
 
-  /** Sample builder class */
-  @RequiredArgsConstructor(access = AccessLevel.PRIVATE)
-  public static class Builder2 {
-    private final SAPDocumentTranslationOutput.TypeEnum translationType;
+  /**
+   * Build and return the input translation configuration
+   *
+   * @return The SAPDocumentTranslationInput configuration
+   */
+  @Nonnull
+  SAPDocumentTranslationInput createSAPDocumentTranslationInput() {
+    return inputConfig;
+  }
 
-    /**
-     * Get the output translation config with default values.
-     *
-     * @return The SAPDocumentTranslationOutput instance.
-     */
-    @Nonnull
-    public SAPDocumentTranslationOutput getOutputTranslationConfig() {
-      return SAPDocumentTranslationOutput.create()
-          .type(translationType)
-          .config(
-              SAPDocumentTranslationOutputConfig.create()
-                  .targetLanguage(SAPDocumentTranslationOutputTargetLanguage.create("de-DE"))
-                  .sourceLanguage("en-US"));
-    }
+  /**
+   * Build and return the output translation configuration
+   *
+   * @return The SAPDocumentTranslationOutput configuration
+   */
+  @Nonnull
+  SAPDocumentTranslationOutput createSAPDocumentTranslationOutput() {
+    return outputConfig;
   }
 }

orchestration/src/main/resources/spec/orchestration.yaml

@@ -112,7 +112,7 @@ components:
           $ref: "#/components/schemas/EmbeddingsInputText"
         type:
           type: string
-          enum: ["text", "document", "query"]
+          enum: [ "text", "document", "query" ]
     EmbeddingsInputText:
       oneOf:
         - type: string
@@ -124,9 +124,9 @@ components:
           items:
             type: string
             minLength: 1
-          example: ["Hello", "World", "!"]
+          example: [ "Hello", "World", "!" ]
       description: Text input for which embeddings need to be generated
-      example: ["This is an input string.", "This is another input string."]
+      example: [ "This is an input string.", "This is another input string." ]
     EmbeddingsModuleConfigs:
       type: object
       required:
@@ -181,7 +181,7 @@ components:
             The number of dimensions the resulting output embeddings should have.
         encoding_format:
           type: string
-          enum: [float, base64, binary]
+          enum: [ float, base64, binary ]
           description: >
             OpenAI's spec allows for 'float' and 'base64' encoding formats.
         normalize:
@@ -465,7 +465,7 @@ components:
       properties:
         type:
           type: string
-          enum: ["text"]
+          enum: [ "text" ]
         text:
           type: string
     ChatDelta:
@@ -639,7 +639,7 @@ components:
           description: List of delimiters to split the input text into chunks.Please note, this is a required parameter when `input_translation_module_config` or `output_translation_module_config` are configured.
           items:
             type: string
-          example: ["\n", ".", "?", "!"]
+          example: [ "\n", ".", "?", "!" ]
 
     GenericModuleResult:
       type: object
@@ -682,8 +682,8 @@ components:
                   type: string
               example:
                 user:
-                  ["translated user content", "another translated user content"]
-                system: ["translated system message"]
+                  [ "translated user content", "another translated user content" ]
+                system: [ "translated system message" ]
             translated_placeholders:
               type: object
               additionalProperties:
@@ -1356,7 +1356,7 @@ components:
         allowlist:
           description: List of strings that should not be masked
           type: array
-          example: ["SAP", "Joule"]
+          example: [ "SAP", "Joule" ]
           items:
             type: string
         mask_grounding_input:
@@ -1475,7 +1475,7 @@ components:
           anyOf:
             - enum:
                 - document_grounding_service
-            - {}
+            - { }
           example: document_grounding_service
         config:
           type: object

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfigTest.java

@@ -140,28 +140,27 @@ void testDpiMaskingRegex() {
 
   @Test
   void testTranslationConfig() {
-    var translationConfig = TranslationConfig.inputTranslation().getInputTranslationConfig();
+    var inputTranslationConfig =
+        TranslationConfig.createInputConfig("en-US").sourceLanguage("de-DE");
+    var outputTranslationConfig =
+        TranslationConfig.createOutputConfig("de-DE").sourceLanguage("en-US");
     var config =
         new OrchestrationModuleConfig()
             .withLlmConfig(GPT_4O)
-            .withInputTranslationConfig(translationConfig);
+            .withInputTranslationConfig(inputTranslationConfig)
+            .withOutputTranslationConfig(outputTranslationConfig);
 
     assertThat(config.getInputTranslationConfig()).isNotNull();
-    assertThat(config.getInputTranslationConfig().getType()).isEqualTo(translationConfig.getType());
     assertThat(config.getInputTranslationConfig().getConfig().getTargetLanguage())
-        .isEqualTo(translationConfig.getConfig().getTargetLanguage());
-
-    var translationConfig2 = TranslationConfig.inputTranslation().getInputTranslationConfig();
-    var config2 =
-        new OrchestrationModuleConfig()
-            .withLlmConfig(GPT_4O)
-            .withInputTranslationConfig(translationConfig2);
-
-    assertThat(config2.getInputTranslationConfig()).isNotNull();
-    assertThat(config2.getInputTranslationConfig().getType())
-        .isEqualTo(translationConfig2.getType());
-    assertThat(config2.getInputTranslationConfig().getConfig().getTargetLanguage())
-        .isEqualTo(translationConfig2.getConfig().getTargetLanguage());
+        .isEqualTo("en-US");
+    assertThat(config.getInputTranslationConfig().getConfig().getSourceLanguage())
+        .isEqualTo(inputTranslationConfig.getInputConfig().getConfig().getSourceLanguage());
+
+    assertThat(config.getOutputTranslationConfig()).isNotNull();
+    assertThat(config.getOutputTranslationConfig().getConfig().getTargetLanguage())
+        .isEqualTo(outputTranslationConfig.getOutputConfig().getConfig().getTargetLanguage());
+    assertThat(config.getOutputTranslationConfig().getConfig().getSourceLanguage())
+        .isEqualTo(outputTranslationConfig.getOutputConfig().getConfig().getSourceLanguage());
   }
 
   @Test

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OrchestrationService.java

@@ -616,11 +616,10 @@ public OrchestrationChatResponse translation() {
     // https://help.sap.com/docs/translation-hub/sap-translation-hub/supported-languages?version=Cloud#translation-provider-sap-machine-translation
     val configWithTranslation =
         config
-            .withInputTranslationConfig(
-                TranslationConfig.inputTranslation().getInputTranslationConfig())
+            .withInputTranslationConfig(TranslationConfig.createInputConfig("en-US"))
             .withOutputTranslationConfig(
-                TranslationConfig.outputTranslation()
-                    .getOutputTranslationConfig()); // optional source language
+                TranslationConfig.createOutputConfig("de-DE")
+                    .sourceLanguage("en-US")); // optional source language
 
     return client.chatCompletion(prompt, configWithTranslation);
   }