Skip to content

Commit 5088e7d

Browse files
removed warnings
1 parent 0fd5e10 commit 5088e7d

File tree

3 files changed

+15
-24
lines changed

3 files changed

+15
-24
lines changed

orchestration/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationChatModel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public ChatResponse call(@Nonnull final Prompt prompt) {
4646

4747
val orchestrationPrompt = toOrchestrationPrompt(prompt);
4848
val response = client.chatCompletion(orchestrationPrompt, options.getConfig());
49-
return OrchestrationChatResponse.fromOrchestrationResponse(response.getOriginalResponse());
49+
return new OrchestrationSpringChatResponse(response);
5050
}
5151
throw new IllegalArgumentException(
5252
"Please add OrchestrationChatOptions to the Prompt: new Prompt(\"message\", new OrchestrationChatOptions(config))");

orchestration/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationChatResponse.java renamed to orchestration/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationSpringChatResponse.java

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.sap.ai.sdk.orchestration.spring;
22

3-
import com.google.common.annotations.Beta;
4-
import com.sap.ai.sdk.orchestration.model.CompletionPostResponse;
3+
import com.sap.ai.sdk.orchestration.OrchestrationChatResponse;
54
import com.sap.ai.sdk.orchestration.model.LLMChoice;
65
import com.sap.ai.sdk.orchestration.model.LLMModuleResultSynchronous;
76
import com.sap.ai.sdk.orchestration.model.TokenUsage;
@@ -18,34 +17,26 @@
1817
import org.springframework.ai.chat.model.ChatResponse;
1918
import org.springframework.ai.chat.model.Generation;
2019

21-
/**
22-
* Response from the orchestration service in a Spring AI {@link ChatResponse}.
23-
*
24-
* @since 1.2.0
25-
*/
26-
@Beta
20+
/** Response from the orchestration service in a Spring AI {@link ChatResponse}. */
2721
@Value
2822
@EqualsAndHashCode(callSuper = true)
29-
public class OrchestrationChatResponse extends ChatResponse {
23+
class OrchestrationSpringChatResponse extends ChatResponse {
3024

31-
private OrchestrationChatResponse(
32-
@Nonnull final List<Generation> generations, @Nonnull final ChatResponseMetadata metadata) {
33-
super(generations, metadata);
34-
}
25+
OrchestrationChatResponse response;
3526

36-
@Nonnull
37-
static OrchestrationChatResponse fromOrchestrationResponse(
38-
@Nonnull final CompletionPostResponse response) {
39-
val result = (LLMModuleResultSynchronous) response.getOrchestrationResult();
40-
val generations = toGenerations(result);
41-
val metadata = toChatResponseMetadata(result);
42-
return new OrchestrationChatResponse(generations, metadata);
27+
OrchestrationSpringChatResponse(@Nonnull final OrchestrationChatResponse response) {
28+
super(
29+
toGenerations(
30+
(LLMModuleResultSynchronous) response.getOriginalResponse().getOrchestrationResult()),
31+
toChatResponseMetadata(
32+
(LLMModuleResultSynchronous) response.getOriginalResponse().getOrchestrationResult()));
33+
this.response = response;
4334
}
4435

4536
@Nonnull
4637
static List<Generation> toGenerations(@Nonnull final LLMModuleResultSynchronous result) {
4738
return result.getChoices().stream()
48-
.map(OrchestrationChatResponse::toAssistantMessage)
39+
.map(OrchestrationSpringChatResponse::toAssistantMessage)
4940
.map(Generation::new)
5041
.toList();
5142
}

orchestration/src/test/java/com/sap/ai/sdk/orchestration/spring/OrchestrationChatResponseTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ void testToAssistantMessage() {
2020
.message(ChatMessage.create().role("assistant").content("Hello, world!"))
2121
.finishReason("stop");
2222

23-
AssistantMessage message = OrchestrationChatResponse.toAssistantMessage(choice);
23+
AssistantMessage message = OrchestrationSpringChatResponse.toAssistantMessage(choice);
2424

2525
assertThat(message.getContent()).isEqualTo("Hello, world!");
2626
assertThat(message.getMetadata()).containsEntry("finish_reason", "stop");
@@ -38,7 +38,7 @@ void testToChatResponseMetadata() {
3838
.choices(List.of())
3939
.usage(TokenUsage.create().completionTokens(20).promptTokens(10).totalTokens(30));
4040

41-
var metadata = OrchestrationChatResponse.toChatResponseMetadata(moduleResult);
41+
var metadata = OrchestrationSpringChatResponse.toChatResponseMetadata(moduleResult);
4242

4343
assertThat(metadata.getId()).isEqualTo("test-id");
4444
assertThat(metadata.getModel()).isEqualTo("test-model");

0 commit comments

Comments
 (0)