Skip to content

Commit 61a5fcd

Browse files
authored
Run Checkstyle by default (#111)
1 parent 2d712cb commit 61a5fcd

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

.pipeline/checkstyle-suppressions.xml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66

77
<suppressions>
88
<!-- Suppress generated clients -->
9-
<suppress files="[/\\]core/client[/\\]" checks=".*"/>
10-
<suppress files="[/\\]orchestration/client[/\\]" checks=".*"/>
9+
<suppress files="/core/client/" checks=".*"/>
10+
<suppress files="/orchestration/client/" checks=".*"/>
11+
<!-- Suppress TODOs -->
12+
<suppress files="OpenAiChatCompletionParameters.java" checks="TodoComment" lines="95" />
13+
<suppress files="OpenAiChatMessage.java" checks="TodoComment" lines="255,271" />
1114
</suppressions>

.pipeline/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ stages:
2020
class: 67
2121
codeCheck:
2222
checkstyle:
23-
high: '3'# Open tasks (to do or fix me)
23+
high: '0'
2424
normal: '0'
2525
low: '0'
2626
spotbugs:

pom.xml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,9 +396,9 @@
396396
<artifactId>maven-checkstyle-plugin</artifactId>
397397
<version>3.5.0</version>
398398
<configuration>
399-
<configLocation>.pipeline/checkstyle.xml</configLocation>
399+
<configLocation>${project.rootdir}/.pipeline/checkstyle.xml</configLocation>
400400
<!-- Exclude generated clients -->
401-
<suppressionsLocation>.pipeline/checkstyle-suppressions.xml</suppressionsLocation>
401+
<suppressionsLocation>${project.rootdir}/.pipeline/checkstyle-suppressions.xml</suppressionsLocation>
402402
<linkXRef>false</linkXRef>
403403
</configuration>
404404
<dependencies>
@@ -408,6 +408,14 @@
408408
<version>${checkstyle.version}</version>
409409
</dependency>
410410
</dependencies>
411+
<executions>
412+
<execution>
413+
<goals>
414+
<goal>check</goal>
415+
</goals>
416+
<phase>verify</phase>
417+
</execution>
418+
</executions>
411419
</plugin>
412420
<plugin>
413421
<groupId>org.apache.maven.plugins</groupId>

0 commit comments

Comments
 (0)