Fix maven dependency scope issue

Author: rpanackal

sample-code/spring-app/pom.xml

@@ -191,10 +191,6 @@
       <artifactId>jackson-module-jsonSchema</artifactId>
       <version>2.18.2</version>
     </dependency>
-    <dependency>
-      <groupId>io.vavr</groupId>
-      <artifactId>vavr</artifactId>
-    </dependency>
   </dependencies>
 
   <build>
@@ -229,20 +225,6 @@
           <skipAddThirdParty>true</skipAddThirdParty>
         </configuration>
       </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-dependency-plugin</artifactId>
-        <executions>
-          <execution>
-            <id>analyze</id>
-            <configuration>
-              <ignoredDependencies>
-                <ignoredDependency>com.fasterxml.jackson.core:jackson-core</ignoredDependency>
-              </ignoredDependencies>
-            </configuration>
-          </execution>
-        </executions>
-      </plugin>
     </plugins>
   </build>
 </project>

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OpenAiService.java

@@ -5,6 +5,9 @@
 import static com.sap.ai.sdk.foundationmodels.openai.OpenAiModel.TEXT_EMBEDDING_3_SMALL;
 import static com.sap.ai.sdk.foundationmodels.openai.model.OpenAiChatCompletionTool.ToolType.FUNCTION;
 
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.module.jsonSchema.JsonSchemaGenerator;
 import com.sap.ai.sdk.core.AiCoreService;
@@ -17,7 +20,6 @@
 import com.sap.ai.sdk.foundationmodels.openai.model.OpenAiChatMessage;
 import com.sap.ai.sdk.foundationmodels.openai.model.OpenAiEmbeddingOutput;
 import com.sap.ai.sdk.foundationmodels.openai.model.OpenAiEmbeddingParameters;
-import io.vavr.control.Try;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -128,13 +130,14 @@ public OpenAiChatCompletionOutput chatCompletionTools(final int months) {
   public OpenAiChatCompletionOutput chatCompletionToolExecution(
       @Nonnull final String location, @Nonnull final String unit) {
 
-    final var schemaMap =
-        Try.of(() -> new JsonSchemaGenerator(JACKSON).generateSchema(WeatherMethod.Request.class))
-            .map(schema -> JACKSON.convertValue(schema, Map.class))
-            .getOrElseThrow(
-                e ->
-                    new IllegalArgumentException(
-                        "Could not generate schema for WeatherMethod.Request", e));
+    final var jsonSchemaGenerator = new JsonSchemaGenerator(JACKSON);
+    Map<String, Object> schemaMap;
+    try {
+      final var schema = jsonSchemaGenerator.generateSchema(WeatherMethod.Request.class);
+      schemaMap = JACKSON.convertValue(schema, new TypeReference<>() {});
+    } catch (JsonMappingException e) {
+      throw new IllegalArgumentException("Could not generate schema for WeatherMethod.Request", e);
+    }
 
     final var function =
         new OpenAiChatCompletionFunction()
@@ -163,7 +166,7 @@ public OpenAiChatCompletionOutput chatCompletionToolExecution(
           JACKSON.readValue(toolCall.getFunction().getArguments(), WeatherMethod.Request.class);
       final var toolResponse = new WeatherMethod().getCurrentWeather(weatherRequest);
       toolResponseJson = JACKSON.writeValueAsString(toolResponse);
-    } catch (Exception e) {
+    } catch (JsonProcessingException e) {
       throw new IllegalArgumentException("Error parsing tool call arguments", e);
     }
 

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/services/OpenAiServiceV2.java

@@ -6,6 +6,8 @@
 import static com.sap.ai.sdk.foundationmodels.openai.generated.model.ChatCompletionTool.TypeEnum.FUNCTION;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.JsonMappingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.module.jsonSchema.JsonSchemaGenerator;
 import com.sap.ai.sdk.core.AiCoreService;
@@ -28,7 +30,6 @@
 import com.sap.ai.sdk.foundationmodels.openai.generated.model.CreateChatCompletionRequest;
 import com.sap.ai.sdk.foundationmodels.openai.generated.model.CreateChatCompletionResponse;
 import com.sap.ai.sdk.foundationmodels.openai.generated.model.FunctionObject;
-import io.vavr.control.Try;
 import java.util.List;
 import java.util.Map;
 import java.util.stream.Stream;
@@ -134,13 +135,14 @@ public OpenAiChatCompletionResponse chatCompletionTools(final int months) {
   public CreateChatCompletionResponse chatCompletionToolExecution(
       @Nonnull final String location, @Nonnull final String unit) {
 
-    final var schemaMap =
-        Try.of(() -> new JsonSchemaGenerator(JACKSON).generateSchema(WeatherMethod.Request.class))
-            .map(schema -> JACKSON.convertValue(schema, Map.class))
-            .getOrElseThrow(
-                e ->
-                    new IllegalArgumentException(
-                        "Could not generate schema for WeatherMethod.Request", e));
+    final var jsonSchemaGenerator = new JsonSchemaGenerator(JACKSON);
+    Map<String, Object> schemaMap;
+    try {
+      var schema = jsonSchemaGenerator.generateSchema(WeatherMethod.Request.class);
+      schemaMap = JACKSON.convertValue(schema, new TypeReference<Map<String, Object>>() {});
+    } catch (JsonMappingException e) {
+      throw new IllegalArgumentException("Could not generate schema for WeatherMethod.Request", e);
+    }
 
     final var function =
         new FunctionObject()