Splitting TranslationConfig class (Alex's Idea)

Author: n-o-u-r-h-a-n

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfig.java

@@ -330,8 +330,8 @@ public OrchestrationModuleConfig withTemplateConfig(
   @Tolerate
   @Nonnull
   public OrchestrationModuleConfig withInputTranslationConfig(
-      @Nonnull final TranslationConfig translationConfig) {
-    return this.withInputTranslationConfig(translationConfig.getInputConfig());
+      @Nonnull final TranslationConfig.Input translationConfig) {
+    return this.withInputTranslationConfig(translationConfig.createSAPDocumentTranslationInput());
   }
 
   /**
@@ -343,7 +343,7 @@ public OrchestrationModuleConfig withInputTranslationConfig(
   @Tolerate
   @Nonnull
   public OrchestrationModuleConfig withOutputTranslationConfig(
-      @Nonnull final TranslationConfig translationConfig) {
-    return this.withOutputTranslationConfig(translationConfig.getOutputConfig());
+      @Nonnull final TranslationConfig.Output translationConfig) {
+    return this.withOutputTranslationConfig(translationConfig.createSAPDocumentTranslationOutput());
   }
 }

orchestration/src/main/java/com/sap/ai/sdk/orchestration/TranslationConfig.java

@@ -7,7 +7,6 @@
 import com.sap.ai.sdk.orchestration.model.SAPDocumentTranslationOutputTargetLanguage;
 import javax.annotation.Nonnull;
 import lombok.AccessLevel;
-import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 import lombok.Value;
 import lombok.With;
@@ -21,14 +20,50 @@
  *     AI Core: Orchestration - SAP Document Translation</a>
  * @since 1.14.0
  */
-@Value
-@With
-@Getter(AccessLevel.PACKAGE)
-@RequiredArgsConstructor(access = AccessLevel.PRIVATE)
-public class TranslationConfig {
-  SAPDocumentTranslationInput inputConfig;
-  SAPDocumentTranslationOutput outputConfig;
-  String sourceLanguage;
+public interface TranslationConfig {
+  /** Input configuration for translation. */
+  @Value
+  @With
+  @RequiredArgsConstructor(access = AccessLevel.PRIVATE)
+  class Input implements TranslationConfig {
+    @With(AccessLevel.NONE)
+    String targetLanguage;
+
+    String sourceLanguage;
+
+    @With(AccessLevel.NONE)
+    Object ApplyTo; // Can be null
+
+    @Nonnull
+    SAPDocumentTranslationInput createSAPDocumentTranslationInput() {
+      val translationType = SAPDocumentTranslationInput.TypeEnum.SAP_DOCUMENT_TRANSLATION;
+      val conf =
+          SAPDocumentTranslationInputConfig.create().targetLanguage(targetLanguage).applyTo(null);
+      return SAPDocumentTranslationInput.create().type(translationType).config(conf);
+    }
+  }
+
+  /** Output configuration for translation. */
+  @Value
+  @With
+  @RequiredArgsConstructor(access = AccessLevel.PRIVATE)
+  class Output implements TranslationConfig {
+    @With(AccessLevel.NONE)
+    String targetLanguage;
+
+    String sourceLanguage;
+
+    @Nonnull
+    SAPDocumentTranslationOutput createSAPDocumentTranslationOutput() {
+      val translationType = SAPDocumentTranslationOutput.TypeEnum.SAP_DOCUMENT_TRANSLATION;
+      val tLang = SAPDocumentTranslationOutputTargetLanguage.create(targetLanguage);
+      val conf =
+          SAPDocumentTranslationOutputConfig.create()
+              .targetLanguage(tLang)
+              .sourceLanguage(sourceLanguage);
+      return SAPDocumentTranslationOutput.create().type(translationType).config(conf);
+    }
+  }
 
   /**
    * Create a new input translation configuration.
@@ -37,16 +72,9 @@ public class TranslationConfig {
    * @return A TranslationConfig configured for input translation
    */
   @Nonnull
-  public static TranslationConfig createInput(@Nonnull final String targetLanguage) {
-    val translationType = SAPDocumentTranslationInput.TypeEnum.SAP_DOCUMENT_TRANSLATION;
-    val inputConfig =
-        SAPDocumentTranslationInput.create()
-            .type(translationType)
-            .config(
-                SAPDocumentTranslationInputConfig.create()
-                    .targetLanguage(targetLanguage)
-                    .applyTo(null));
-    return new TranslationConfig(inputConfig, null, null);
+  static TranslationConfig.Input createInput(@Nonnull final String targetLanguage) {
+
+    return new TranslationConfig.Input(targetLanguage, null, null);
   }
 
   /**
@@ -56,26 +84,8 @@ public static TranslationConfig createInput(@Nonnull final String targetLanguage
    * @return A TranslationConfig configured for output translation
    */
   @Nonnull
-  public static TranslationConfig createOutput(@Nonnull final String targetLanguage) {
-    val translationType = SAPDocumentTranslationOutput.TypeEnum.SAP_DOCUMENT_TRANSLATION;
-    val outputConfig =
-        SAPDocumentTranslationOutput.create()
-            .type(translationType)
-            .config(
-                SAPDocumentTranslationOutputConfig.create()
-                    .targetLanguage(
-                        SAPDocumentTranslationOutputTargetLanguage.create(targetLanguage)));
-    return new TranslationConfig(null, outputConfig, null);
-  }
+  static TranslationConfig.Output createOutput(@Nonnull final String targetLanguage) {
 
-  /**
-   * Set the source language for translation
-   *
-   * @param language The source language code
-   * @return A new TranslationConfig with the specified source language
-   */
-  @Nonnull
-  public TranslationConfig sourceLanguage(@Nonnull final String language) {
-    return this.withSourceLanguage(language);
+    return new TranslationConfig.Output(targetLanguage, null);
   }
 }

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfigTest.java

@@ -140,8 +140,9 @@ void testDpiMaskingRegex() {
 
   @Test
   void testTranslationConfig() {
-    var inputTranslationConfig = TranslationConfig.createInput("en-US").sourceLanguage("de-DE");
-    var outputTranslationConfig = TranslationConfig.createOutput("de-DE").sourceLanguage("en-US");
+    var inputTranslationConfig = TranslationConfig.createInput("en-US").withSourceLanguage("de-DE");
+    var outputTranslationConfig =
+        TranslationConfig.createOutput("de-DE").withSourceLanguage("en-US");
     var config =
         new OrchestrationModuleConfig()
             .withLlmConfig(GPT_4O)
@@ -152,13 +153,25 @@ void testTranslationConfig() {
     assertThat(config.getInputTranslationConfig().getConfig().getTargetLanguage())
         .isEqualTo("en-US");
     assertThat(config.getInputTranslationConfig().getConfig().getSourceLanguage())
-        .isEqualTo(inputTranslationConfig.getInputConfig().getConfig().getSourceLanguage());
+        .isEqualTo(
+            inputTranslationConfig
+                .createSAPDocumentTranslationInput()
+                .getConfig()
+                .getSourceLanguage());
 
     assertThat(config.getOutputTranslationConfig()).isNotNull();
     assertThat(config.getOutputTranslationConfig().getConfig().getTargetLanguage())
-        .isEqualTo(outputTranslationConfig.getOutputConfig().getConfig().getTargetLanguage());
+        .isEqualTo(
+            outputTranslationConfig
+                .createSAPDocumentTranslationOutput()
+                .getConfig()
+                .getTargetLanguage());
     assertThat(config.getOutputTranslationConfig().getConfig().getSourceLanguage())
-        .isEqualTo(outputTranslationConfig.getOutputConfig().getConfig().getSourceLanguage());
+        .isEqualTo(
+            outputTranslationConfig
+                .createSAPDocumentTranslationOutput()
+                .getConfig()
+                .getSourceLanguage());
   }
 
   @Test

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OrchestrationService.java

@@ -619,7 +619,7 @@ public OrchestrationChatResponse translation() {
             .withInputTranslationConfig(TranslationConfig.createInput("en-US"))
             .withOutputTranslationConfig(
                 TranslationConfig.createOutput("de-DE")
-                    .sourceLanguage("en-US")); // optional source language
+                    .withSourceLanguage("en-US")); // optional source language
 
     return client.chatCompletion(prompt, configWithTranslation);
   }