Skip to content

Commit 71d0583

Browse files
committed
Moving created methods and tests to v2.
1 parent 54189bb commit 71d0583

File tree

5 files changed

+22
-33
lines changed

5 files changed

+22
-33
lines changed

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OpenAiController.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -41,19 +41,6 @@ Object chatCompletion(
4141
return response.getContent();
4242
}
4343

44-
@GetMapping("/messagesHistory")
45-
@Nonnull
46-
Object messagesHistory(
47-
@Nullable @RequestParam(value = "format", required = false) final String format,
48-
@Nonnull @RequestParam(value = "previousMessage", defaultValue = "What is the capital of France?")
49-
final String previousMessage) {
50-
final var response = service.messagesHistory(previousMessage);
51-
if ("json".equals(format)) {
52-
return response;
53-
}
54-
return response.getContent();
55-
}
56-
5744
@SuppressWarnings("unused") // The end-to-end test doesn't use this method
5845
@GetMapping("/streamChatCompletionDeltas")
5946
@Nonnull

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OpenAiService.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -56,21 +56,6 @@ public OpenAiChatCompletionOutput chatCompletion(@Nonnull final String prompt) {
5656
* @param previousMessage The request to send to the assistant
5757
* @return the assistant message response
5858
*/
59-
@Nonnull
60-
public OpenAiChatCompletionResponse messagesHistory(@Nonnull final String previousMessage) {
61-
val messagesList = new ArrayList<OpenAiMessage>();
62-
messagesList.add(OpenAiMessage.user(previousMessage));
63-
64-
final OpenAiChatCompletionResponse result =
65-
OpenAiClient.forModel(GPT_4O_MINI)
66-
.chatCompletion(new OpenAiChatCompletionRequest(messagesList));
67-
68-
messagesList.add(result.getMessage());
69-
messagesList.add(OpenAiMessage.user("What is the typical food there?"));
70-
71-
return OpenAiClient.forModel(GPT_4O_MINI)
72-
.chatCompletion(new OpenAiChatCompletionRequest(messagesList));
73-
}
7459

7560
/**
7661
* Asynchronous stream of an OpenAI chat request

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OpenAiServiceV2.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.util.stream.Stream;
2020
import javax.annotation.Nonnull;
2121
import lombok.extern.slf4j.Slf4j;
22+
import lombok.val;
2223
import org.springframework.stereotype.Service;
2324

2425
/** Service class for OpenAI service using latest convenience api */
@@ -37,6 +38,22 @@ public OpenAiChatCompletionResponse chatCompletion(@Nonnull final String prompt)
3738
.chatCompletion(new OpenAiChatCompletionRequest(prompt));
3839
}
3940

41+
@Nonnull
42+
public OpenAiChatCompletionResponse messagesHistory(@Nonnull final String previousMessage) {
43+
val messagesList = new ArrayList<OpenAiMessage>();
44+
messagesList.add(OpenAiMessage.user(previousMessage));
45+
46+
final OpenAiChatCompletionResponse result =
47+
OpenAiClient.forModel(GPT_4O_MINI)
48+
.chatCompletion(new OpenAiChatCompletionRequest(messagesList));
49+
50+
messagesList.add(result.getMessage());
51+
messagesList.add(OpenAiMessage.user("What is the typical food there?"));
52+
53+
return OpenAiClient.forModel(GPT_4O_MINI)
54+
.chatCompletion(new OpenAiChatCompletionRequest(messagesList));
55+
}
56+
4057
/**
4158
* Asynchronous stream of an OpenAI chat request
4259
*

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OpenAiTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,6 @@ void chatCompletion() {
3131
assertThat(message.getContent()).isNotEmpty();
3232
}
3333

34-
@Test
35-
void testMessagesHistory() {
36-
assertThat(service.messagesHistory("What is the capital of France?").getContent()).isNotEmpty();
37-
}
38-
3934
@Test
4035
void chatCompletionImage() {
4136
final var completion =

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OpenAiV2Test.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,11 @@ void chatCompletion() {
3333
assertThat(completion.getContent()).isNotEmpty();
3434
}
3535

36+
@Test
37+
void testMessagesHistory() {
38+
assertThat(service.messagesHistory("What is the capital of France?").getContent()).isNotEmpty();
39+
}
40+
3641
@Test
3742
void chatCompletionImage() {
3843
final var completion =

0 commit comments

Comments
 (0)