improve tests

Author: Jonas-Isr

core/src/main/java/com/sap/ai/sdk/core/AiCoreServiceKeyAccessor.java

@@ -81,7 +81,7 @@ static ServiceBinding createServiceBinding(@Nonnull final String serviceKey)
           new AiCoreCredentialsInvalidException("Missing clientid in service key"));
     }
 
-    if (credentials.get("clientsecret") != null && credentials.get("credentials-type") == null) {
+    if (credentials.get("clientsecret") != null && credentials.get("credential-type") == null) {
       // add missing "credential-type: binding-secret"
       credentials.put("credential-type", "binding-secret");
     }

core/src/test/java/com/sap/ai/sdk/core/AiCoreServiceKeyAccessorTest.java

@@ -55,4 +55,32 @@ void testMalformedDotenv() {
     assertThatThrownBy(accessor::getServiceBindings)
         .isInstanceOf(ServiceBindingAccessException.class);
   }
+
+  @Test
+  void testServiceBindingCreation() {
+    var serviceKeyWithoutCredentialType =
+        """
+        {
+          "clientid": "",
+          "clientsecret": ""
+        }
+        """;
+    var binding1 = AiCoreServiceKeyAccessor.createServiceBinding(serviceKeyWithoutCredentialType);
+    assertThat(binding1.getCredentials().containsKey("credential-type"))
+        .describedAs("The missing 'credential-type' should have automatically been added")
+        .isTrue();
+    var serviceKeyWithCredentialType =
+        """
+        {
+          "clientid": "",
+          "clientsecret": "",
+          "credential-type": "foo"
+          }
+        }
+        """;
+    var binding2 = AiCoreServiceKeyAccessor.createServiceBinding(serviceKeyWithCredentialType);
+    assertThat(binding2.getCredentials().get("credential-type"))
+        .describedAs("The 'credential-type' field should not get overwritten")
+        .isEqualTo("foo");
+  }
 }

core/src/test/java/com/sap/ai/sdk/core/DestinationResolverTest.java

@@ -30,9 +30,6 @@ void testGetDestinationFromBinding() {
     var binding = AiCoreServiceKeyAccessor.createServiceBinding(serviceKey);
     var resolver = new DestinationResolver(() -> List.of(binding));
     var result = resolver.getDestination();
-    assertThat(binding.getCredentials().containsKey("credential-type"))
-        .describedAs("The missing 'credential-type' should have automatically been added")
-        .isTrue();
     assertThat(result.getUri())
         .describedAs("The destination should already contain the /v2 base path")
         .hasToString("https://api.ai.core/v2/");