Green

Author: CharlesDuboisSAP

orchestration/pom.xml

@@ -31,10 +31,10 @@
   </developers>
   <properties>
     <project.rootdir>${project.basedir}/../</project.rootdir>
-    <coverage.complexity>77%</coverage.complexity>
-    <coverage.line>92%</coverage.line>
-    <coverage.instruction>92%</coverage.instruction>
-    <coverage.branch>70%</coverage.branch>
+    <coverage.complexity>80%</coverage.complexity>
+    <coverage.line>93%</coverage.line>
+    <coverage.instruction>93%</coverage.instruction>
+    <coverage.branch>73%</coverage.branch>
     <coverage.method>92%</coverage.method>
     <coverage.class>100%</coverage.class>
   </properties>

orchestration/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationChatOptions.java

@@ -49,7 +49,7 @@ public class OrchestrationChatOptions implements FunctionCallingOptions {
 
   private List<FunctionCallback> functionCallbacks;
 
-  private Map<String, Object> toolContext;
+  private Map<String, Object> toolContext = Map.of();
 
   /**
    * Returns the model to use for the chat.
@@ -208,29 +208,23 @@ public void setFunctionCallbacks(@Nonnull final List<FunctionCallback> functionC
 
   @Override
   public void setFunctions(@Nonnull final Set<String> functionNames) {
-    this.functions = functionNames;
-    val template =
-        Objects.requireNonNullElse(
-            (Template) config.getTemplateConfig(), Template.create().template());
-    val tools =
-        functionNames.stream()
-            .map(
-                functionName ->
-                    ChatCompletionTool.create()
-                        .type(TypeEnum.FUNCTION)
-                        .function(FunctionObject.create().name(functionName)))
-            .toList();
-    config = config.withTemplateConfig(template.tools(tools));
-  }
-
-  @Nonnull
-  @Override
-  public Map<String, Object> getToolContext() {
-    return toolContext;
+    //    val template =
+    //        Objects.requireNonNullElse(
+    //            (Template) config.getTemplateConfig(), Template.create().template());
+    //    val tools =
+    //        functionNames.stream()
+    //            .map(
+    //                functionName ->
+    //                    ChatCompletionTool.create()
+    //                        .type(TypeEnum.FUNCTION)
+    //                        .function(FunctionObject.create().name(functionName)))
+    //            .toList();
+    //    config = config.withTemplateConfig(template.tools(tools));
+    throw new UnsupportedOperationException("Not implemented yet");
   }
 
   @Override
   public void setToolContext(@Nonnull final Map<String, Object> toolContext) {
-    this.toolContext = toolContext;
+    throw new UnsupportedOperationException("Not implemented yet");
   }
 }

orchestration/src/test/java/com/sap/ai/sdk/orchestration/spring/MockWeatherService.java

@@ -1,20 +1,44 @@
 package com.sap.ai.sdk.orchestration.spring;
 
+import javax.annotation.Nonnull;
 import java.util.function.Function;
 
+/** Function for tool calls in Spring AI */
 public class MockWeatherService
     implements Function<MockWeatherService.Request, MockWeatherService.Response> {
 
+  /** Unit of temperature */
   public enum Unit {
+    /** Celsius */
     C,
+    /** Fahrenheit */
     F
   }
 
+  /**
+   * Request for the weather
+   *
+   * @param location the city
+   * @param unit the unit of temperature
+   */
   public record Request(String location, Unit unit) {}
 
+  /**
+   * Response for the weather
+   *
+   * @param temp the temperature
+   * @param unit the unit of temperature
+   */
   public record Response(double temp, Unit unit) {}
 
-  public Response apply(Request request) {
+  /**
+   * Apply the function
+   *
+   * @param request the request
+   * @return the response
+   */
+  @Nonnull
+  public Response apply(@Nonnull Request request) {
     return new Response(30.0, Unit.C);
   }
 }

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/AsynchronousConfiguration.java

@@ -4,11 +4,8 @@
 
 import com.sap.cloud.sdk.cloudplatform.thread.ThreadContextExecutors;
 import java.util.concurrent.Executor;
-import java.util.function.Function;
 import javax.annotation.Nonnull;
-import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
-import org.springframework.context.annotation.Description;
 import org.springframework.scheduling.annotation.Async;
 import org.springframework.scheduling.annotation.AsyncConfigurer;
 import org.springframework.scheduling.annotation.EnableAsync;
@@ -26,11 +23,4 @@ public class AsynchronousConfiguration implements AsyncConfigurer {
   public Executor getAsyncExecutor() {
     return ThreadContextExecutors.getExecutor();
   }
-
-  @Bean
-  // GPT uses the description
-  @Description("Get the weather in location")
-  public Function<String, String> getWeather() {
-    return location -> "The weather is sunny in " + location;
-  }
 }

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/MockWeatherService.java

@@ -3,19 +3,43 @@
 import com.sap.ai.sdk.app.services.MockWeatherService.Request;
 import com.sap.ai.sdk.app.services.MockWeatherService.Response;
 import java.util.function.Function;
+import javax.annotation.Nonnull;
 
+/** Function for tool calls in Spring AI */
 public class MockWeatherService implements Function<Request, Response> {
 
+  /** Unit of temperature */
   public enum Unit {
+    /** Celsius */
     C,
+    /** Fahrenheit */
     F
   }
 
+  /**
+   * Request for the weather
+   *
+   * @param location the city
+   * @param unit the unit of temperature
+   */
   public record Request(String location, Unit unit) {}
 
+  /**
+   * Response for the weather
+   *
+   * @param temp the temperature
+   * @param unit the unit of temperature
+   */
   public record Response(double temp, Unit unit) {}
 
-  public Response apply(Request request) {
+  /**
+   * Apply the function
+   *
+   * @param request the request
+   * @return the response
+   */
+  @Nonnull
+  public Response apply(@Nonnull Request request) {
     return new Response(30.0, Unit.C);
   }
 }