Skip to content

Commit 7ded1f7

Browse files
committed
Increase test coverage.
1 parent 36a66e5 commit 7ded1f7

File tree

5 files changed

+15
-17
lines changed

5 files changed

+15
-17
lines changed

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@ class OrchestrationUnitTest {
7070
.withParam(MAX_TOKENS, 50)
7171
.withParam(TEMPERATURE, 0.1)
7272
.withParam(FREQUENCY_PENALTY, 0)
73-
.withParam(PRESENCE_PENALTY, 0);
73+
.withParam(PRESENCE_PENALTY, 0)
74+
.withParam(TOP_P, 1)
75+
.withParam(N, 1);
7476

7577
private final Function<String, InputStream> fileLoader =
7678
filename -> Objects.requireNonNull(getClass().getClassLoader().getResourceAsStream(filename));
@@ -614,16 +616,4 @@ void streamChatCompletionDeltas() throws IOException {
614616
Mockito.verify(inputStream, times(1)).close();
615617
}
616618
}
617-
618-
@Test
619-
void testOrchestrationError() {
620-
stubFor(
621-
post(urlPathEqualTo("/completion"))
622-
.willReturn(
623-
aResponse()
624-
.withBodyFile("templatingResponse.json")
625-
.withHeader("Content-Type", "application/json")));
626-
final var response = client.chatCompletion(prompt, config);
627-
OrchestrationError error = new OrchestrationError(response);
628-
}
629619
}

orchestration/src/test/resources/filteringLooseRequest.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
"temperature": 0.1,
88
"max_tokens": 50,
99
"frequency_penalty": 0,
10-
"presence_penalty": 0
10+
"presence_penalty": 0,
11+
"top_p" : 1,
12+
"n" : 1
1113
},
1214
"model_version": "latest"
1315
},

orchestration/src/test/resources/maskingRequest.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
"presence_penalty": 0,
88
"frequency_penalty": 0,
99
"max_tokens": 50,
10-
"temperature": 0.1
10+
"temperature": 0.1,
11+
"top_p" : 1,
12+
"n" : 1
1113
},
1214
"model_version": "latest"
1315
},

orchestration/src/test/resources/messagesHistoryRequest.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
"presence_penalty": 0,
88
"frequency_penalty": 0,
99
"max_tokens": 50,
10-
"temperature": 0.1
10+
"temperature": 0.1,
11+
"top_p" : 1,
12+
"n" : 1
1113
},
1214
"model_version": "latest"
1315
},

orchestration/src/test/resources/templatingRequest.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@
1515
"max_tokens": 50,
1616
"temperature": 0.1,
1717
"frequency_penalty": 0,
18-
"presence_penalty": 0
18+
"presence_penalty": 0,
19+
"top_p" : 1,
20+
"n" : 1
1921
},
2022
"model_version": "latest"
2123
}

0 commit comments

Comments
 (0)